Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5752158993514496: Issue 1578 - Add notransforms installer for installations using Group Policy Object (Closed)

Created:
Dec. 11, 2014, 3:01 a.m. by Oleksandr
Modified:
Dec. 16, 2014, 5:16 p.m.
Reviewers:
Eric
CC:
Felix Dahlke, sergei
Visibility:
Public.

Description

Issue 1578 - Add notransforms installer for installations using Group Policy Object

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -5 lines) Patch
M installer/installer.gyp View 6 chunks +59 lines, -4 lines 2 comments Download
M installer/msibuild.cmd View 2 chunks +5 lines, -0 lines 0 comments Download
M installer/src/msi/adblockplusie.wxs View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3
Oleksandr
Dec. 11, 2014, 3:03 a.m. (2014-12-11 03:03:15 UTC) #1
Eric
LGTM. Only code comments are very minor formatting points. http://codereview.adblockplus.org/5752158993514496/diff/5629499534213120/installer/installer.gyp File installer/installer.gyp (right): http://codereview.adblockplus.org/5752158993514496/diff/5629499534213120/installer/installer.gyp#newcode123 installer/installer.gyp:123: ...
Dec. 12, 2014, 3:39 p.m. (2014-12-12 15:39:32 UTC) #2
Oleksandr
Dec. 16, 2014, 5:16 p.m. (2014-12-16 17:16:14 UTC) #3
The formatting changes there would better be fixed when modifying the tabbing on
the whole file. Currently space tabbing and tab-tabbing are mixed there.

On 2014/12/12 15:39:32, Eric wrote:
> LGTM. Only code comments are very minor formatting points.
> 
>
http://codereview.adblockplus.org/5752158993514496/diff/5629499534213120/inst...
> File installer/installer.gyp (right):
> 
>
http://codereview.adblockplus.org/5752158993514496/diff/5629499534213120/inst...
> installer/installer.gyp:123: '>(installer_object)', '<(common_object_file)',
> I noticed we've got tabs here. They could be removed.
> 
>
http://codereview.adblockplus.org/5752158993514496/diff/5629499534213120/inst...
> installer/installer.gyp:310: # (Except the build which doesn't embed any
> transforms. That one uses notransforms)
> I'd indent these comments to match the declarations immediately below.

Powered by Google App Engine
This is Rietveld