Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/background.js

Issue 5817039037923328: Issue 1813 - Implement ext.showOptions() in Firefox (Closed)
Patch Set: Created Jan. 15, 2015, 1:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/background.js
===================================================================
--- a/ext/background.js
+++ b/ext/background.js
@@ -90,8 +90,16 @@ PageMap.prototype = {
},
delete: function(page)
{
this._map.delete(page._sender);
}
};
exports.PageMap = PageMap;
+
+exports.showOptions = function(callback)
+{
+ if (typeof callback != "undefined")
+ Cu.reportError("Unsupported callback parameter passed to ext.showOptions");
Sebastian Noack 2015/01/15 13:04:57 Just omit the callback argument? The rest of the a
Wladimir Palant 2015/01/15 14:47:34 It was meant mostly as a reminder, this will likel
+
+ require("ui").UI.openFiltersDialog();
+};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld