Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5915403922440192: Issue 2235 - Update jsshell to ESR31 to support new generator syntax (Closed)

Created:
March 31, 2015, 1:54 p.m. by Sebastian Noack
Modified:
April 1, 2015, 8:44 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2235 - Update jsshell to ESR31 to support new generator syntax

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use non-debug build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M utils.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 31, 2015, 1:55 p.m. (2015-03-31 13:55:13 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5915403922440192/diff/5629499534213120/utils.py File utils.py (right): http://codereview.adblockplus.org/5915403922440192/diff/5629499534213120/utils.py#newcode30 utils.py:30: download_url = 'https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015/03/2015-03-29-mozilla-esr31-debug/jsshell-%s.zip' % platform_map[sys.platform] Using a debug build ...
March 31, 2015, 2:28 p.m. (2015-03-31 14:28:37 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5915403922440192/diff/5629499534213120/utils.py File utils.py (right): http://codereview.adblockplus.org/5915403922440192/diff/5629499534213120/utils.py#newcode30 utils.py:30: download_url = 'https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015/03/2015-03-29-mozilla-esr31-debug/jsshell-%s.zip' % platform_map[sys.platform] On 2015/03/31 14:28:37, Wladimir ...
March 31, 2015, 5:54 p.m. (2015-03-31 17:54:23 UTC) #3
Wladimir Palant
March 31, 2015, 9:32 p.m. (2015-03-31 21:32:26 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld