Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: build.py

Issue 6018170477346816: 1588 - Integrate ensure_dependencies.py with the adblockplus repository (Closed)
Patch Set: 1588 - Integrate ensure_dependencies.py with the adblockplus repository Created Dec. 17, 2014, 4:17 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .hgsubstate ('k') | dependencies » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build.py
===================================================================
--- a/build.py
+++ b/build.py
@@ -3,5 +3,14 @@
import os, sys, subprocess
+DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies.py")
+
+if os.path.isfile(DEPENDENCY_SCRIPT):
+ try:
+ subprocess.check_call(["python", DEPENDENCY_SCRIPT])
+ except subprocess.CalledProcessError as e:
+ print >>sys.stderr, str(e)
Wladimir Palant 2014/12/17 16:22:18 Not addressed: print e rather than str(e)?
+ print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"
+
Wladimir Palant 2014/12/17 16:22:18 Nit: The indentation is wrong, we use two spaces f
import buildtools.build
buildtools.build.processArgs('.', sys.argv)
« no previous file with comments | « .hgsubstate ('k') | dependencies » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld