Issue 731 - Don't wrap filter in "Block element" dialog

Issue 731 - Don't wrap filter in "Block element" dialog

[Thomas Greiner, 2014-09-30 10:36:59]

http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/bloc...
File block.html (right):

http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/bloc...
block.html:77: <textarea id="filters" wrap="off"></textarea>
This works but the "off" value doesn't appear to be in the standard. We can
achieve the same effect with CSS using:

white-space: pre;
word-wrap: normal;

[Sebastian Noack, 2014-10-01 18:15:08]

http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/bloc...
File block.html (right):

http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/bloc...
block.html:77: <textarea id="filters" wrap="off"></textarea>
On 2014/09/30 10:37:00, Thomas Greiner wrote:
> This works but the "off" value doesn't appear to be in the standard. We can
> achieve the same effect with CSS using:
> 
> white-space: pre;
> word-wrap: normal;

Well, it is in the standard:
https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap

It's also documented on MDN:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap

[Wladimir Palant, 2014-10-01 18:35:50]

http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/bloc...
File block.html (right):

http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/bloc...
block.html:77: <textarea id="filters" wrap="off"></textarea>
On 2014/10/01 18:15:08, Sebastian Noack wrote:
> Well, it is in the standard:
> https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap
> 
> It's also documented on MDN:
> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap

Either I am overlooking something or both pages only document wrap="hard" and
wrap="soft" but not wrap="off". This value indeed appears to be non-standard and
deprecated.

[Sebastian Noack, 2014-10-29 12:17:05]

http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/bloc...
File block.html (right):

http://codereview.adblockplus.org/6194726097125376/diff/5629499534213120/bloc...
block.html:77: <textarea id="filters" wrap="off"></textarea>
On 2014/10/01 18:35:51, Wladimir Palant wrote:
> On 2014/10/01 18:15:08, Sebastian Noack wrote:
> > Well, it is in the standard:
> > https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-wrap
> > 
> > It's also documented on MDN:
> > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-wrap
> 
> Either I am overlooking something or both pages only document wrap="hard" and
> wrap="soft" but not wrap="off". This value indeed appears to be non-standard
and
> deprecated.

No, I overlooked it, you both were right. I'm using standard CSS properties now,
as suggested by Thomas.

[Thomas Greiner, 2014-10-29 13:03:48]

LGTM

[Wladimir Palant, 2014-12-09 21:27:10]

Better late than never: LGTM