Cleaned up CA exceptions. Integrated free-standing handle class.

Cleaned up exceptions in response to Windows API errors.

Eliminated Window_Handle, integrating it into the handle<> class.

[Oleksandr, 2014-03-31 07:35:49]

Code formatting issues and one nit aside, LGTM.

http://codereview.adblockplus.org/6197445574787072/diff/5629499534213120/inst...
File installer/src/installer-lib/record.cpp (right):

http://codereview.adblockplus.org/6197445574787072/diff/5629499534213120/inst...
installer/src/installer-lib/record.cpp:69: throw not_yet_supported( "retrieving
string values longer than 1023 from a record" ) ;
Still, why not just dynamically allocate the buffer here? Doesn't seem to
complicate things much.

[Eric, 2014-03-31 11:23:08]

http://codereview.adblockplus.org/6197445574787072/diff/5629499534213120/inst...
File installer/src/installer-lib/record.cpp (right):

http://codereview.adblockplus.org/6197445574787072/diff/5629499534213120/inst...
installer/src/installer-lib/record.cpp:69: throw not_yet_supported( "retrieving
string values longer than 1023 from a record" ) ;
On 2014/03/31 07:35:49, Oleksandr wrote:
> Still, why not just dynamically allocate the buffer here? Doesn't seem to
> complicate things much.

It wouldn't. The main reason is that we have no need of it for this CA, and code
not written is code you don't need to test. If this were more of a general
publication library, it would be the right thing to do.

Like most get-string functions in Windows API, this one would require a second
call to MsiRecordGetStringW.

[Oleksandr, 2014-07-15 14:22:37]

This can be closed, since it's not the up to date code anymore and we have the
Whole Installer review now.

On 2014/03/31 11:23:08, Eric wrote:
>
http://codereview.adblockplus.org/6197445574787072/diff/5629499534213120/inst...
> File installer/src/installer-lib/record.cpp (right):
> 
>
http://codereview.adblockplus.org/6197445574787072/diff/5629499534213120/inst...
> installer/src/installer-lib/record.cpp:69: throw not_yet_supported(
"retrieving
> string values longer than 1023 from a record" ) ;
> On 2014/03/31 07:35:49, Oleksandr wrote:
> > Still, why not just dynamically allocate the buffer here? Doesn't seem to
> > complicate things much.
> 
> It wouldn't. The main reason is that we have no need of it for this CA, and
code
> not written is code you don't need to test. If this were more of a general
> publication library, it would be the right thing to do.
> 
> Like most get-string functions in Windows API, this one would require a second
> call to MsiRecordGetStringW.

[Eric, 2014-07-18 16:42:33]

See review for "Whole installer"
http://codereview.adblockplus.org/6202981292703744/