Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6275268058546176: Issue 2157 - Update Large Scale Deployments landing page (Closed)

Created:
June 11, 2015, 1:54 p.m. by saroyanm
Modified:
June 15, 2015, 8:33 a.m.
Reviewers:
Sebastian Noack
CC:
Felix Dahlke, sven, Thomas Greiner
Visibility:
Public.

Description

Related ticket: https://issues.adblockplus.org/ticket/2157

Patch Set 1 #

Total comments: 10

Patch Set 2 : Images Compressed #

Total comments: 4

Patch Set 3 : Updated MSG descriptions and tried to use less lsd #

Patch Set 4 : cut lsd supply and remove description #

Patch Set 5 : Rename deployments.html to deployments.tmpl #

Patch Set 6 : Convert deployments to Jinja2 template #

Total comments: 8

Patch Set 7 : Some fixes according to "Patch Set 6" comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -49 lines) Patch
M locales/de/deployments.json View 1 2 3 4 5 6 1 chunk +70 lines, -16 lines 0 comments Download
A locales/es/deployments.json View 1 2 3 4 5 6 1 chunk +80 lines, -0 lines 0 comments Download
A locales/ru/deployments.json View 1 2 3 4 5 6 1 chunk +83 lines, -0 lines 0 comments Download
M locales/zh_CN/deployments.json View 1 2 3 4 5 6 1 chunk +71 lines, -16 lines 0 comments Download
M pages/deployments.tmpl View 1 2 3 4 5 6 1 chunk +115 lines, -17 lines 0 comments Download
A static/css/lsd.css View 1 chunk +117 lines, -0 lines 0 comments Download
A static/img/lsd/7energy-logo.png View 1 Binary file 0 comments Download
A static/img/lsd/compnology-logo.png View 1 Binary file 0 comments Download
A static/img/lsd/holstebro-logo.png View 1 Binary file 0 comments Download
A static/img/lsd/is-geneva-logo.png View 1 Binary file 0 comments Download
A static/img/lsd/lsd-sprite.png View 1 Binary file 0 comments Download
A static/img/lsd/unalaska-logo.png View 1 Binary file 0 comments Download

Messages

Total messages: 15
saroyanm
@Sebastian can you please have a look ? Actually I had a question which I ...
June 11, 2015, 2:02 p.m. (2015-06-11 14:02:38 UTC) #1
Sebastian Noack
Isn't the raw HTML format deprecated? Then this would probably be the right time to ...
June 11, 2015, 2:34 p.m. (2015-06-11 14:34:00 UTC) #2
saroyanm
http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html File pages/deployments.html (right): http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html#newcode41 pages/deployments.html:41: <div class="toc"> On 2015/06/11 14:34:00, Sebastian Noack wrote: > ...
June 11, 2015, 2:44 p.m. (2015-06-11 14:44:29 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html File pages/deployments.html (right): http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html#newcode41 pages/deployments.html:41: <div class="toc"> On 2015/06/11 14:44:29, saroyanm wrote: > On ...
June 11, 2015, 2:53 p.m. (2015-06-11 14:53:58 UTC) #4
saroyanm
New patch uploaded. http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html File pages/deployments.html (right): http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html#newcode43 pages/deployments.html:43: <li><a href="#what-is-lsd">{{what-is-lsd-header What are large scale ...
June 11, 2015, 4:27 p.m. (2015-06-11 16:27:48 UTC) #5
Sebastian Noack
On 2015/06/11 14:34:00, Sebastian Noack wrote: > Isn't the raw HTML format deprecated? Then this ...
June 12, 2015, 11:22 a.m. (2015-06-12 11:22:58 UTC) #6
saroyanm
http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html File pages/deployments.html (right): http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html#newcode43 pages/deployments.html:43: <li><a href="#what-is-lsd">{{what-is-lsd-header What are large scale deployments?}}</a></li> On 2015/06/12 ...
June 12, 2015, 12:03 p.m. (2015-06-12 12:03:07 UTC) #7
Sebastian Noack
http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html File pages/deployments.html (right): http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html#newcode43 pages/deployments.html:43: <li><a href="#what-is-lsd">{{what-is-lsd-header What are large scale deployments?}}</a></li> On 2015/06/12 ...
June 12, 2015, 12:07 p.m. (2015-06-12 12:07:34 UTC) #8
saroyanm
New patch uploaded http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html File pages/deployments.html (right): http://codereview.adblockplus.org/6275268058546176/diff/5629499534213120/pages/deployments.html#newcode43 pages/deployments.html:43: <li><a href="#what-is-lsd">{{what-is-lsd-header What are large scale ...
June 12, 2015, 1:46 p.m. (2015-06-12 13:46:04 UTC) #9
Sebastian Noack
On 2015/06/12 11:22:58, Sebastian Noack wrote: > On 2015/06/11 14:34:00, Sebastian Noack wrote: > > ...
June 12, 2015, 5:20 p.m. (2015-06-12 17:20:17 UTC) #10
saroyanm
On 2015/06/12 17:20:17, Sebastian Noack wrote: > On 2015/06/12 11:22:58, Sebastian Noack wrote: > > ...
June 13, 2015, 1:48 p.m. (2015-06-13 13:48:16 UTC) #11
saroyanm
New patches uploaded.
June 13, 2015, 1:48 p.m. (2015-06-13 13:48:36 UTC) #12
Sebastian Noack
http://codereview.adblockplus.org/6275268058546176/diff/5167242941562880/pages/deployments.tmpl File pages/deployments.tmpl (right): http://codereview.adblockplus.org/6275268058546176/diff/5167242941562880/pages/deployments.tmpl#newcode7 pages/deployments.tmpl:7: <meta name="title" content="{{'Large Scale Deployment'|translate('meta-title')}}" /> Nit: Please double ...
June 13, 2015, 5:16 p.m. (2015-06-13 17:16:51 UTC) #13
saroyanm
New patch uploaded. http://codereview.adblockplus.org/6275268058546176/diff/5167242941562880/pages/deployments.tmpl File pages/deployments.tmpl (right): http://codereview.adblockplus.org/6275268058546176/diff/5167242941562880/pages/deployments.tmpl#newcode7 pages/deployments.tmpl:7: <meta name="title" content="{{'Large Scale Deployment'|translate('meta-title')}}" /> ...
June 14, 2015, 10:26 a.m. (2015-06-14 10:26:53 UTC) #14
Sebastian Noack
June 14, 2015, 11:44 a.m. (2015-06-14 11:44:29 UTC) #15
LGTM

Powered by Google App Engine
This is Rietveld