Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6353703170736128: Issue 1112 - Properly use polyfills in firstrun and settings pages (Closed)

Created:
July 23, 2014, 12:33 p.m. by Oleksandr
Modified:
July 24, 2014, 6:09 a.m.
Reviewers:
Felix Dahlke
CC:
sergei, Eric
Visibility:
Public.

Description

Properly use polyfills in firstrun and settings pages

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keeping the 'false' parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M html/static/js/IESettings.js View 4 chunks +4 lines, -4 lines 0 comments Download
M html/static/js/firstRun.js View 4 chunks +8 lines, -8 lines 0 comments Download
M html/static/js/settings.js View 1 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 4
Oleksandr
July 23, 2014, 12:33 p.m. (2014-07-23 12:33:58 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/6353703170736128/diff/5629499534213120/html/static/js/settings.js File html/static/js/settings.js (right): http://codereview.adblockplus.org/6353703170736128/diff/5629499534213120/html/static/js/settings.js#newcode8 html/static/js/settings.js:8: manageButton.addEventListener("click", toggleManage); Might keep the false too.
July 23, 2014, 12:45 p.m. (2014-07-23 12:45:17 UTC) #2
Oleksandr
July 23, 2014, 12:48 p.m. (2014-07-23 12:48:18 UTC) #3
Felix Dahlke
July 23, 2014, 12:53 p.m. (2014-07-23 12:53:18 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld