Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6377735828013056: Issue #1234 - conversion functions between std::wstring and ATL::CString (Closed)

Created:
Oct. 1, 2014, 7:38 p.m. by Eric
Modified:
Oct. 7, 2014, 2:43 p.m.
Visibility:
Public.

Description

Issue #1234 - conversion functions between std::wstring and ATL::CString CamelCase versions of the previously-used conversion functions.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/plugin/ATL_Deprecate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/plugin/ATL_Deprecate.cpp View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Eric
Oct. 1, 2014, 7:40 p.m. (2014-10-01 19:40:12 UTC) #1
Felix Dahlke
LGTM, assuming we can get rid of the underscore versions once all the current CString ...
Oct. 2, 2014, 7:56 p.m. (2014-10-02 19:56:26 UTC) #2
Eric
On 2014/10/02 19:56:26, Felix H. Dahlke wrote: > LGTM, assuming we can get rid of ...
Oct. 2, 2014, 8:04 p.m. (2014-10-02 20:04:57 UTC) #3
sergei
LGTM, Despite I doubt that we need any of these functions.
Oct. 6, 2014, 9:04 a.m. (2014-10-06 09:04:32 UTC) #4
Oleksandr
LGTM
Oct. 6, 2014, 9:07 a.m. (2014-10-06 09:07:45 UTC) #5
Eric
Oct. 7, 2014, 2:40 p.m. (2014-10-07 14:40:17 UTC) #6
On 2014/10/06 09:04:32, sergei wrote:
> Despite I doubt that we need any of these functions.

See recent discussion here:
http://codereview.adblockplus.org/6224768520945664/#msg4

Powered by Google App Engine
This is Rietveld