Issue 6453924974297088: Issue 1619 - Wrong return value of CPluginClass::Invoke

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453924974297088: Issue 1619 - Wrong return value of CPluginClass::Invoke (Closed)

Created:
Nov. 26, 2014, 8:51 p.m. by sergei

Modified:
Jan. 13, 2015, 1:24 p.m.

Reviewers:
Eric, Oleksandr

Visibility:
Public.

Patch Set 2 : clean CPluginClass::Invoke #

Total comments: 5

Created: Nov. 27, 2014, 11:40 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -80 lines)			Patch
	M	src/plugin/PluginClass.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/plugin/PluginClass.cpp	View	1	5 chunks	+15 lines, -79 lines	5 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Oleksandr

http://codereview.adblockplus.org/6453924974297088/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (left): http://codereview.adblockplus.org/6453924974297088/diff/5629499534213120/src/plugin/PluginClass.cpp#oldcode632 src/plugin/PluginClass.cpp:632: return VARIANT_TRUE; How about returns here? In fact most ...

Nov. 27, 2014, 9:52 a.m. (2014-11-27 09:52:56 UTC) #2

Eric

http://codereview.adblockplus.org/6453924974297088/diff/5649050225344512/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (right): http://codereview.adblockplus.org/6453924974297088/diff/5649050225344512/src/plugin/PluginClass.cpp#newcode661 src/plugin/PluginClass.cpp:661: ATL::CComPtr<IWebBrowser2> browser = GetBrowser(); We could declare this as ...

Dec. 30, 2014, 2:37 p.m. (2014-12-30 14:37:50 UTC) #4

sergei

Jan. 13, 2015, 1:24 p.m. (2015-01-13 13:24:21 UTC) #5

I'm closing it because http://codereview.adblockplus.org/4937147073167360/
supersedes it.

http://codereview.adblockplus.org/6453924974297088/diff/5649050225344512/src/...
File src/plugin/PluginClass.cpp (right):

http://codereview.adblockplus.org/6453924974297088/diff/5649050225344512/src/...
src/plugin/PluginClass.cpp:661: ATL::CComPtr<IWebBrowser2> browser =
GetBrowser();
On 2014/12/30 14:37:50, Eric wrote:
> We could declare this as IWebBrowser2* with one small modification below.

I find it as a bad practice, `GetBrowser()` returns smart pointer, if we store
merely raw pointer the smart pointer object is destroyed. It works here but it
smells a lot.

Expand All Messages | Collapse All Messages