Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include.preload.js

Issue 6646117731139584: Issue 1613 - Don't collapse elements with non-HTTP URL (Closed)
Patch Set: Created Nov. 26, 2014, 3:06 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include.preload.js
===================================================================
--- a/include.preload.js
+++ b/include.preload.js
@@ -33,7 +33,7 @@
{
// This element failed loading, did we block it?
var url = element.src;
- if (!url)
+ if (!url || !/^https:/i.test(url))
kzar 2014/11/26 16:41:10 Shouldn't we also match HTTP as well as HTTPS here
Sebastian Noack 2014/11/26 16:53:13 Ouch, this was a typo.
kzar 2014/11/26 16:58:29 Easily done! Works for me now
return;
ext.backgroundPage.sendMessage(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld