Visual Studio Express readyness. No MFC.

Visual Studio Express readyness. No MFC. 

Please ignore the v8 references for now.

[Oleksandr, 2012-12-17 07:21:04]

Up for review

[Wladimir Palant, 2012-12-17 07:25:09]

That's all the dependencies on MFC? Nice!

http://codereview.adblockplus.org/9043003/diff/1/AdPlugin.sln
File AdPlugin.sln (right):

http://codereview.adblockplus.org/9043003/diff/1/AdPlugin.sln#newcode3
AdPlugin.sln:3: Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") =
"SimpleAdblock", "AdBlocker\AdBlocker.vcxproj",
"{24AAF1A9-ACC0-4BEB-B781-084734D939B5}"
This references AdBlocker.vcxproj which isn't part of the repository - maybe
keep the unconverted sln file for now?

[Oleksandr, 2012-12-18 00:10:03]

http://codereview.adblockplus.org/9043003/diff/1/AdPlugin.sln
File AdPlugin.sln (right):

http://codereview.adblockplus.org/9043003/diff/1/AdPlugin.sln#newcode3
AdPlugin.sln:3: Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") =
"SimpleAdblock", "AdBlocker\AdBlocker.vcxproj",
"{24AAF1A9-ACC0-4BEB-B781-084734D939B5}"
I'm not sure about that. We will be adding/removing files during development. As
well as changing build settings (linker input, preporcessor definitions etc) -
all those are reflected in project file. On 2012/12/17 07:25:09, Wladimir Palant
wrote:
> This references AdBlocker.vcxproj which isn't part of the repository - maybe
> keep the unconverted sln file for now?

[Wladimir Palant, 2012-12-18 06:40:14]

http://codereview.adblockplus.org/9043003/diff/1/AdPlugin.sln
File AdPlugin.sln (right):

http://codereview.adblockplus.org/9043003/diff/1/AdPlugin.sln#newcode3
AdPlugin.sln:3: Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") =
"SimpleAdblock", "AdBlocker\AdBlocker.vcxproj",
"{24AAF1A9-ACC0-4BEB-B781-084734D939B5}"
The alternative would be removing AdBlocker.vcproj and adding AdBlocker.vcxproj
instead - keeping both around will necessarily mean that one of them goes out of
sync. That would mean however that we no longer support Visual Studio 2008 as
build environment, probably not a popular move with you and Alex.

I don't really want to push for makefiles but isn't there some
version-independent project description format?

[Oleksandr, 2012-12-18 07:42:39]

On 2012/12/18 06:40:14, Wladimir Palant wrote:
> http://codereview.adblockplus.org/9043003/diff/1/AdPlugin.sln
> File AdPlugin.sln (right):
> 
> http://codereview.adblockplus.org/9043003/diff/1/AdPlugin.sln#newcode3
> AdPlugin.sln:3: Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") =
> "SimpleAdblock", "AdBlocker\AdBlocker.vcxproj",
> "{24AAF1A9-ACC0-4BEB-B781-084734D939B5}"
> The alternative would be removing AdBlocker.vcproj and adding
AdBlocker.vcxproj
> instead - keeping both around will necessarily mean that one of them goes out
of
> sync. That would mean however that we no longer support Visual Studio 2008 as
> build environment, probably not a popular move with you and Alex.
> 
> I don't really want to push for makefiles but isn't there some
> version-independent project description format?

I don't actually mind working in Visual Studio 2012 Express on this. Alex, do
you?

[alex, 2012-12-18 09:59:39]

I don't mind.

[Wladimir Palant, 2012-12-18 15:17:21]

Sounds like we will be requiring Visual Studio 2012 Express then. Will you
replace AdBlocker.vcproj by AdBlocker.vcxproj?

[Oleksandr, 2012-12-18 15:21:38]

On 2012/12/18 15:17:21, Wladimir Palant wrote:
> Sounds like we will be requiring Visual Studio 2012 Express then. Will you
> replace AdBlocker.vcproj by AdBlocker.vcxproj?

Yep