Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9616008: Handle compile time exceptions (Closed)

Created:
March 6, 2013, 3:17 p.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 10 a.m.
Visibility:
Public.

Description

Without this, a syntax error in a script would cause a segfault.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M src/JsEngine.cpp View 3 chunks +10 lines, -5 lines 0 comments Download
M test/JsEngine.cpp View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 5
Felix Dahlke
March 6, 2013, 3:20 p.m. (2013-03-06 15:20:54 UTC) #1
Wladimir Palant
I'm not the reviewer but LGTM.
March 11, 2013, 11:30 a.m. (2013-03-11 11:30:00 UTC) #2
Oleksandr
On 2013/03/11 11:30:00, Wladimir Palant wrote: > I'm not the reviewer but LGTM. Looks good ...
March 11, 2013, 11:53 a.m. (2013-03-11 11:53:12 UTC) #3
Felix Dahlke
On 2013/03/11 11:53:12, Oleksandr wrote: > On 2013/03/11 11:30:00, Wladimir Palant wrote: > > I'm ...
March 11, 2013, 12:06 p.m. (2013-03-11 12:06:02 UTC) #4
Oleksandr
March 13, 2013, 9:05 a.m. (2013-03-13 09:05:13 UTC) #5
On 2013/03/11 12:06:02, Felix H. Dahlke wrote:
> On 2013/03/11 11:53:12, Oleksandr wrote:
> > On 2013/03/11 11:30:00, Wladimir Palant wrote:
> > > I'm not the reviewer but LGTM.
> > 
> > Looks good to me as well
> 
> You have to actually write "LGTM", but I'll imply that :)

hmm. LGTM

Powered by Google App Engine
This is Rietveld