Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9763002: Add command to initiate garbage collection (Closed)

Created:
March 11, 2013, 11:07 a.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 10 a.m.
Visibility:
Public.

Description

Just added a command to trigger a GC in V8. Hacked something like that in to investigate a possible memory leak and thought I'd add it properly for debugging purposes.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M include/AdblockPlus/JsEngine.h View 1 chunk +1 line, -0 lines 0 comments Download
M shell/shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A shell/src/GcCommand.h View 1 chunk +21 lines, -0 lines 0 comments Download
A shell/src/GcCommand.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M shell/src/Main.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/JsEngine.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Felix Dahlke
March 11, 2013, 11:09 a.m. (2013-03-11 11:09:36 UTC) #1
Wladimir Palant
I'm not the reviewer but LGTM.
March 11, 2013, 11:26 a.m. (2013-03-11 11:26:11 UTC) #2
Oleksandr
March 13, 2013, 9:13 a.m. (2013-03-13 09:13:54 UTC) #3
On 2013/03/11 11:26:11, Wladimir Palant wrote:
> I'm not the reviewer but LGTM.

LGTM

Powered by Google App Engine
This is Rietveld