Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9986038: Fix jsshell download URL (Closed)

Created:
April 2, 2013, 10:41 a.m. by Felix Dahlke
Modified:
April 3, 2013, 11:25 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Seems like the following path does not exist anymore: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/11.0-candidates So I went with 12.0-candidates instead.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Felix Dahlke
April 2, 2013, 10:43 a.m. (2013-04-02 10:43:20 UTC) #1
Wladimir Palant
April 3, 2013, 11:24 a.m. (2013-04-03 11:24:33 UTC) #2
Sorry, this change isn't sufficient - 12.0 builds produce different results
because they convert for (let i = 0; i < l; i++) into let (i = 0) for (; i < l;
i++) internally. I've put a more complete patch for review under
http://codereview.adblockplus.org/10000013.

Powered by Google App Engine
This is Rietveld