Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10209008: Compiler error c1091 fixed (65K string limit). GetClassName resolved (Closed)

Created:
April 27, 2013, 8:03 a.m. by Oleksandr
Modified:
April 30, 2013, 8:58 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Compiler error c1091 fixed (65K string limit). GetClassName resolved

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M include/AdblockPlus/JsValue.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Oleksandr
April 27, 2013, 8:04 a.m. (2013-04-27 08:04:26 UTC) #1
Wladimir Palant
I don't think that doing many string concatenations is a good solution. I have a ...
April 27, 2013, 11:36 p.m. (2013-04-27 23:36:12 UTC) #2
Oleksandr
April 30, 2013, 8:57 a.m. (2013-04-30 08:57:47 UTC) #3
On 2013/04/27 23:36:12, Wladimir Palant wrote:
> I don't think that doing many string concatenations is a good solution. I have
a
> different solution under http://codereview.adblockplus.org/10259051/ - use a
> char array instead of a string literal, these don't seem to have any length
> limitations even in MSVC. I also make sure there to specify a length
explicitly
> in std::string constructor (this is generally a good idea).


Your's is better. Mine was causing some memory management errors inside
std::string. (Didn't dive into it). Closing this.

Powered by Google App Engine
This is Rietveld