Issue 29328597: Prepare the Adblock Browser notification for the second test (Closed)
|
Created:
Sept. 24, 2015, 4:34 p.m. by Felix Dahlke Modified:
Sept. 24, 2015, 9:18 p.m. Reviewers:
Wladimir Palant CC:
tamara, Sebastian Noack, mathias Visibility:
Public. |
DescriptionPrepare the Adblock Browser notification for the second test
I've removed the range, changed the samples and updated the message translations.
Patch Set 1 #
Total comments: 48
Patch Set 2 : Fixed translations #
Total comments: 2
Patch Set 3 : Fixed more translations #MessagesTotal messages: 7
Could either of you review this until 10pm CEST?
I've only commented on the first variant - the translation issues seem to be consistent across all three variants. https://codereview.adblockplus.org/29328597/diff/29328598/2 File 2 (right): https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode30 2:30: title.fi = Rakastatko Adblock Plus -lisäosaa? I strongly suspect that - here is a typo. It's consistent in all three variants however. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode42 2:42: title.mn = “Адблок Плас” таалагдаж байна уу? We don't translate "Adblock Plus" in Mongolian, and the quotation marks are definitely misplaced. Should definitely be: Adblock Plus таалагдаж байна уу? https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode83 2:83: message.es-419 = <a>Obtén nuestro nuevo Navegador Adblock</a> para teléfonos inteligentes y tabletas. Replacing "Navegador Adblock" by "Adblock Browser" in the four translations above and pt-PT below should fix them. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode96 2:96: message.fi = <a>Lataa uusi Adblock-selain</a> älypuhelimille ja tableteille. Replacing "Adblock-selain" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode99 2:99: message.ro = <a>Descărcați noul nostru browser Adblock</a> pentru smartphone-uri şi tablete. Replacing "browser Adblock" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode101 2:101: message.ko = 스마트폰과 태블릿 전용 <a>새로운 Adblock Plus를 가져가세요</a>. This should say "Adblock Browser," not "Adblock Plus" (message appears to be fine other than that). https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode102 2:102: message.vi = <a>Hãy nhận Trình duyệt Adblock mới của chúng tôi</a> dành cho điện thoại thông minh và máy tính bảng. This message is definitely wrong (Browser being translated) but I have no idea how we could fix it. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode104 2:104: message.ms = <a>Dapatkan Pelayar Adblock kami</a> untuk telefon pintar dan tablet. I think we can replace "Pelayar Adblock" by "Adblock Browser", should be ok then. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode108 2:108: message.mn = <a>Манай шинэ “Адблок” хөтчийг</a> ухаалаг гар утас, таблет дээрээ татаж аваарай. This is pretty bad... We can try replacing "“Адблок” хөтчийг" by "Adblock Browser" but I'm not sure whether the grammatical structure of the sentence will still be intact. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode114 2:114: message.kn = ಸ್ಮಾರ್ಟ್ಪೋನ್ಗಳು ಮತ್ತು ಟ್ಯಾಬ್ಲೆಟ್ಗಳಿಗಾಗಿ ನಮ್ಮ ಹೊಸ ಆಡ್ಬ್ಲಾಕ್ ಬ್ರೌಸರ್ ಪಡೆದುಕೊಳ್ಳಿರಿ <a>Get our new Adblock Browser</a> Ok, this is completely broken, I don't think it can be fixed - maybe remove? https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode119 2:119: message.hr = <a>Preuzmite naš novi Adblock preglednik</a> za pametne telefone i tablete. Replacing "Adblock preglednik" by "Adblock Browser" should fix that. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode120 2:120: message.bs = <a>Preuzmite naš novi Adblock pregledač</a> za pametne telefone i tablične računare. Replacing "Adblock pregledač" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode122 2:122: message.sl = <a>Prenesite naš novi Adblock brskalnik</a> za pametne telefone in tablice. Replacing "Adblock brskalnik" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode124 2:124: message.bg = <a>Вземи нашия нов Adblock браузър</a> за смартфони и таблети. Replacing "Adblock браузър" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode125 2:125: message.mk = <a>Инсталирајте го нашиот нов Adblock Пребарувач</a> за паметни телефони и таблети. Replacing "Adblock Пребарувач" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode130 2:130: message.lv = <a>Saņem mūsu jauno Adblock pārlūku</a> viedtālruņiem un planšetdatoriem. Replacing "Adblock pārlūku" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode131 2:131: message.lt = <a>Gaukite mūsų naują Adblock naršyklę</a> išmaniesiems telefonams ir planšetėms. Replacing "Adblock naršyklę" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode132 2:132: message.be = <a>Атрымайце наш новы браўзэр Adblock</a> для смартфонаў і планшэтаў. Replacing "браўзэр Adblock" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode134 2:134: message.nb-NO = Elsker du Adblock Plus? <a>Få vår nye Adblock Browser</a> for smarttelefoner og nettbrett. "Elsker du Adblock Plus?" should be removed. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode135 2:135: message.is = <a>Fáðu þér nýja Adblock-vafrann okkar</a> fyrir snjallsíma og spjaldtölvur. Replacing "Adblock-vafrann" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode137 2:137: message.eu = <a>Eskuratu ezazu gure Adblock Bilatzaile berria</a> smartphone eta tabletentzako. Replacing "Adblock Bilatzaile" by "Adblock Browser" should fix this. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode138 2:138: message.af = <a>Kry ons nuwe Adblock Blaaier</a> vir slimfone en tablette. Replacing "Adblock Blaaier" by "Adblock Browser" should fix this.
New patch set is up. https://codereview.adblockplus.org/29328597/diff/29328598/2 File 2 (right): https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode30 2:30: title.fi = Rakastatko Adblock Plus -lisäosaa? On 2015/09/24 19:52:32, Wladimir Palant wrote: > I strongly suspect that - here is a typo. It's consistent in all three variants > however. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode42 2:42: title.mn = “Адблок Плас” таалагдаж байна уу? On 2015/09/24 19:52:32, Wladimir Palant wrote: > We don't translate "Adblock Plus" in Mongolian, and the quotation marks are > definitely misplaced. Should definitely be: Adblock Plus таалагдаж байна уу? Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode83 2:83: message.es-419 = <a>Obtén nuestro nuevo Navegador Adblock</a> para teléfonos inteligentes y tabletas. On 2015/09/24 19:52:32, Wladimir Palant wrote: > Replacing "Navegador Adblock" by "Adblock Browser" in the four translations > above and pt-PT below should fix them. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode96 2:96: message.fi = <a>Lataa uusi Adblock-selain</a> älypuhelimille ja tableteille. On 2015/09/24 19:52:32, Wladimir Palant wrote: > Replacing "Adblock-selain" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode99 2:99: message.ro = <a>Descărcați noul nostru browser Adblock</a> pentru smartphone-uri şi tablete. On 2015/09/24 19:52:32, Wladimir Palant wrote: > Replacing "browser Adblock" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode101 2:101: message.ko = 스마트폰과 태블릿 전용 <a>새로운 Adblock Plus를 가져가세요</a>. On 2015/09/24 19:52:33, Wladimir Palant wrote: > This should say "Adblock Browser," not "Adblock Plus" (message appears to be > fine other than that). Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode102 2:102: message.vi = <a>Hãy nhận Trình duyệt Adblock mới của chúng tôi</a> dành cho điện thoại thông minh và máy tính bảng. On 2015/09/24 19:52:32, Wladimir Palant wrote: > This message is definitely wrong (Browser being translated) but I have no idea > how we could fix it. Doesn't seem bad enough to throw it out - I'll just leave it here... https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode104 2:104: message.ms = <a>Dapatkan Pelayar Adblock kami</a> untuk telefon pintar dan tablet. On 2015/09/24 19:52:32, Wladimir Palant wrote: > I think we can replace "Pelayar Adblock" by "Adblock Browser", should be ok > then. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode108 2:108: message.mn = <a>Манай шинэ “Адблок” хөтчийг</a> ухаалаг гар утас, таблет дээрээ татаж аваарай. On 2015/09/24 19:52:32, Wladimir Palant wrote: > This is pretty bad... We can try replacing "“Адблок” хөтчийг" by "Adblock > Browser" but I'm not sure whether the grammatical structure of the sentence will > still be intact. I don't really dare... https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode114 2:114: message.kn = ಸ್ಮಾರ್ಟ್ಪೋನ್ಗಳು ಮತ್ತು ಟ್ಯಾಬ್ಲೆಟ್ಗಳಿಗಾಗಿ ನಮ್ಮ ಹೊಸ ಆಡ್ಬ್ಲಾಕ್ ಬ್ರೌಸರ್ ಪಡೆದುಕೊಳ್ಳಿರಿ <a>Get our new Adblock Browser</a> On 2015/09/24 19:52:33, Wladimir Palant wrote: > Ok, this is completely broken, I don't think it can be fixed - maybe remove? Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode119 2:119: message.hr = <a>Preuzmite naš novi Adblock preglednik</a> za pametne telefone i tablete. On 2015/09/24 19:52:32, Wladimir Palant wrote: > Replacing "Adblock preglednik" by "Adblock Browser" should fix that. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode120 2:120: message.bs = <a>Preuzmite naš novi Adblock pregledač</a> za pametne telefone i tablične računare. On 2015/09/24 19:52:33, Wladimir Palant wrote: > Replacing "Adblock pregledač" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode122 2:122: message.sl = <a>Prenesite naš novi Adblock brskalnik</a> za pametne telefone in tablice. On 2015/09/24 19:52:32, Wladimir Palant wrote: > Replacing "Adblock brskalnik" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode124 2:124: message.bg = <a>Вземи нашия нов Adblock браузър</a> за смартфони и таблети. On 2015/09/24 19:52:33, Wladimir Palant wrote: > Replacing "Adblock браузър" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode125 2:125: message.mk = <a>Инсталирајте го нашиот нов Adblock Пребарувач</a> за паметни телефони и таблети. On 2015/09/24 19:52:32, Wladimir Palant wrote: > Replacing "Adblock Пребарувач" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode130 2:130: message.lv = <a>Saņem mūsu jauno Adblock pārlūku</a> viedtālruņiem un planšetdatoriem. On 2015/09/24 19:52:32, Wladimir Palant wrote: > Replacing "Adblock pārlūku" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode131 2:131: message.lt = <a>Gaukite mūsų naują Adblock naršyklę</a> išmaniesiems telefonams ir planšetėms. On 2015/09/24 19:52:33, Wladimir Palant wrote: > Replacing "Adblock naršyklę" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode132 2:132: message.be = <a>Атрымайце наш новы браўзэр Adblock</a> для смартфонаў і планшэтаў. On 2015/09/24 19:52:33, Wladimir Palant wrote: > Replacing "браўзэр Adblock" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode134 2:134: message.nb-NO = Elsker du Adblock Plus? <a>Få vår nye Adblock Browser</a> for smarttelefoner og nettbrett. On 2015/09/24 19:52:32, Wladimir Palant wrote: > "Elsker du Adblock Plus?" should be removed. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode135 2:135: message.is = <a>Fáðu þér nýja Adblock-vafrann okkar</a> fyrir snjallsíma og spjaldtölvur. On 2015/09/24 19:52:32, Wladimir Palant wrote: > Replacing "Adblock-vafrann" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode137 2:137: message.eu = <a>Eskuratu ezazu gure Adblock Bilatzaile berria</a> smartphone eta tabletentzako. On 2015/09/24 19:52:33, Wladimir Palant wrote: > Replacing "Adblock Bilatzaile" by "Adblock Browser" should fix this. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode138 2:138: message.af = <a>Kry ons nuwe Adblock Blaaier</a> vir slimfone en tablette. On 2015/09/24 19:52:33, Wladimir Palant wrote: > Replacing "Adblock Blaaier" by "Adblock Browser" should fix this. Done.
https://codereview.adblockplus.org/29328597/diff/29328598/2 File 2 (right): https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode108 2:108: message.mn = <a>Манай шинэ “Адблок” хөтчийг</a> ухаалаг гар утас, таблет дээрээ татаж аваарай. > I don't really dare... Well, the alternative is throwing it out completely. Given the obvious issues, the rest of the translation is likely problematic as well - so might be the best solution indeed. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode114 2:114: message.kn = ಸ್ಮಾರ್ಟ್ಪೋನ್ಗಳು ಮತ್ತು ಟ್ಯಾಬ್ಲೆಟ್ಗಳಿಗಾಗಿ ನಮ್ಮ ಹೊಸ ಆಡ್ಬ್ಲಾಕ್ ಬ್ರೌಸರ್ ಪಡೆದುಕೊಳ್ಳಿರಿ <a>Get our new Adblock Browser</a> On 2015/09/24 20:26:39, Felix Dahlke wrote: > Done. What about the corresponding title? https://codereview.adblockplus.org/29328597/diff/29328621/2 File 2 (right): https://codereview.adblockplus.org/29328597/diff/29328621/2#newcode234 2:234: message.ro = Fiţi primul care <a>descarcă browser-ul Adblock</a> pentru smartphone sau tabletă. Here as well: "browser-ul Adblock" should be "Adblock Browser".
New patch set is up. https://codereview.adblockplus.org/29328597/diff/29328598/2 File 2 (right): https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode108 2:108: message.mn = <a>Манай шинэ “Адблок” хөтчийг</a> ухаалаг гар утас, таблет дээрээ татаж аваарай. On 2015/09/24 20:45:55, Wladimir Palant wrote: > > I don't really dare... > > Well, the alternative is throwing it out completely. Given the obvious issues, > the rest of the translation is likely problematic as well - so might be the best > solution indeed. Done. https://codereview.adblockplus.org/29328597/diff/29328598/2#newcode114 2:114: message.kn = ಸ್ಮಾರ್ಟ್ಪೋನ್ಗಳು ಮತ್ತು ಟ್ಯಾಬ್ಲೆಟ್ಗಳಿಗಾಗಿ ನಮ್ಮ ಹೊಸ ಆಡ್ಬ್ಲಾಕ್ ಬ್ರೌಸರ್ ಪಡೆದುಕೊಳ್ಳಿರಿ <a>Get our new Adblock Browser</a> On 2015/09/24 20:45:55, Wladimir Palant wrote: > On 2015/09/24 20:26:39, Felix Dahlke wrote: > > Done. > > What about the corresponding title? Done. https://codereview.adblockplus.org/29328597/diff/29328621/2 File 2 (right): https://codereview.adblockplus.org/29328597/diff/29328621/2#newcode234 2:234: message.ro = Fiţi primul care <a>descarcă browser-ul Adblock</a> pentru smartphone sau tabletă. On 2015/09/24 20:45:55, Wladimir Palant wrote: > Here as well: "browser-ul Adblock" should be "Adblock Browser". Done.
LGTM
|
