Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29330798: Issue #3350 - Replace DISP_E_EXCEPTION returns with DISP_E_BADINDEX (Closed)

Created:
Nov. 25, 2015, 6:02 p.m. by Eric
Modified:
Dec. 14, 2015, 11:16 a.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #3350 - Replace DISP_E_EXCEPTION returns with DISP_E_BADINDEX

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/plugin/PluginUserSettings.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6
Eric
Don't see any need for inline documentation on this change. It's all in the ticket. ...
Nov. 25, 2015, 6:06 p.m. (2015-11-25 18:06:30 UTC) #1
Eric
See https://codereview.adblockplus.org/29331713/ for a live test that verifies that this change is fully supported in ...
Dec. 1, 2015, 5:54 p.m. (2015-12-01 17:54:48 UTC) #2
Oleksandr
Purely from the Javascript client point of view returning "Subscript out of range" exception isn't ...
Dec. 3, 2015, 12:09 p.m. (2015-12-03 12:09:44 UTC) #3
Eric
RangeError isn't incongruous; it's the javascript-standard way of returning this kind of error. Here's the ...
Dec. 3, 2015, 1:26 p.m. (2015-12-03 13:26:56 UTC) #4
Oleksandr
LGTM
Dec. 14, 2015, 12:42 a.m. (2015-12-14 00:42:10 UTC) #5
sergei
Dec. 14, 2015, 8:18 a.m. (2015-12-14 08:18:52 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld