Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29345505: Issue 4099 - Don't enforce Gecko build IDs to be numerical (Closed)

Created:
June 1, 2016, 2:31 p.m. by Wladimir Palant
Modified:
June 2, 2016, 6:38 p.m.
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Issue 4099 - Don't enforce Gecko build IDs to be numerical Repository: hg.adblockplus.org/buildtools

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary type conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build.py View 1 chunk +3 lines, -1 line 0 comments Download
M packager.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
June 1, 2016, 2:31 p.m. (2016-06-01 14:31:48 UTC) #1
Vasily Kuznetsov
https://codereview.adblockplus.org/29345505/diff/29345506/build.py File build.py (right): https://codereview.adblockplus.org/29345505/diff/29345506/build.py#newcode188 build.py:188: buildNum = value So now that `buildNum` is a ...
June 1, 2016, 4:08 p.m. (2016-06-01 16:08:53 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29345505/diff/29345506/build.py File build.py (right): https://codereview.adblockplus.org/29345505/diff/29345506/build.py#newcode188 build.py:188: buildNum = value On 2016/06/01 16:08:53, Vasily Kuznetsov wrote: ...
June 1, 2016, 5:16 p.m. (2016-06-01 17:16:43 UTC) #3
Vasily Kuznetsov
June 2, 2016, 6:08 a.m. (2016-06-02 06:08:21 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld