Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29357368: Issue 4525 - Filter Preferences: Move findbar to the top of the filters list (Closed)

Created:
Oct. 14, 2016, 8:09 a.m. by Wladimir Palant
Modified:
Oct. 17, 2016, 3:23 p.m.
Reviewers:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

Issue 4525 - Filter Preferences: Move findbar to the top of the filters list

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M chrome/content/ui/filters.xul View 2 chunks +12 lines, -12 lines 1 comment Download
M chrome/content/ui/filters-filterview.js View 2 chunks +11 lines, -3 lines 1 comment Download
M chrome/content/ui/filters-search.js View 1 chunk +4 lines, -5 lines 1 comment Download
M chrome/skin/filters.css View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Oct. 14, 2016, 8:09 a.m. (2016-10-14 08:09:20 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29357368/diff/29357369/chrome/content/ui/filters-filterview.js File chrome/content/ui/filters-filterview.js (right): https://codereview.adblockplus.org/29357368/diff/29357369/chrome/content/ui/filters-filterview.js#newcode500 chrome/content/ui/filters-filterview.js:500: this.selectRow(index, true); Selecting a filter (typically when coming from ...
Oct. 14, 2016, 8:12 a.m. (2016-10-14 08:12:13 UTC) #2
Thomas Greiner
Oct. 17, 2016, 3:15 p.m. (2016-10-17 15:15:21 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld