Issue 29367268: Issue 4474 - short version of Privacy Policy at eyeo.com (Closed)
|
Created:
Dec. 12, 2016, 6:34 p.m. by juliandoucette Modified:
Dec. 19, 2016, 3:32 p.m. CC:
Lisa Base URL:
https://hg.adblockplus.org/web.eyeo.com Visibility:
Public. |
Patch Set 1 #Patch Set 2 : Undid minor text change. #
Total comments: 7
Patch Set 3 : Fixed unconverted markdown email link. #
Total comments: 37
Patch Set 4 : Separated duplicates, corrected 'eyeo', and updated date #Patch Set 5 : Changed E case in address #
Total comments: 5
Patch Set 6 : Separated cookies in data collection list #
MessagesTotal messages: 19
@Manvel this should be a quick one. @Judith please find questions below. https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html#... pages/privacy.html:1: title=Privacy Policy Note: - Converted markdown to semantically correct HTML5 markup. - Added ids to headings - Long version content was not changed unless otherwise noted https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html#... pages/privacy.html:4: <h1>Privacy Policy <small>(eyeo.com)</small></h1> Note: I placed the privacy policies (short, long) one after another in this way: - Privacy Policy (eyeo.com) - Privacy Notice (short version) - Privacy Policy (long version) So that it's clear that the short and long versions are part of a whole. Is this OK @Judith? https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html#... pages/privacy.html:22: <li> Note: I changed the comma-separated sudo-list to an actual unordered list for accessibility/semantic correctness. Is this OK @Judith? https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html#... pages/privacy.html:190: Naturally you have the right to receive, upon request, information about the personal data stored by us about you. You also have the right to correct inaccurate personal data, to block and delete details. To do so, please contact us via <a href="mailto:privacy@eyeo.com">privacy@eyeo.com</a> or mail to: Note: - Added a mailto link to the email address - Made addresses consistent (semantically correct and multi-line) Is this OK @Judith?
Looks very good to me. Thanks so much for speeding that up. Very much appreciated. I know you guys are totally snowed under. https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html#... pages/privacy.html:4: <h1>Privacy Policy <small>(eyeo.com)</small></h1> On 2016/12/12 18:57:43, juliandoucette wrote: > Note: > > I placed the privacy policies (short, long) one after another in this way: > > - Privacy Policy (http://eyeo.com) > - Privacy Notice (short version) > - Privacy Policy (long version) > > So that it's clear that the short and long versions are part of a whole. > > Is this OK @Judith? That is perfect! https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html#... pages/privacy.html:22: <li> On 2016/12/12 18:57:42, juliandoucette wrote: > Note: > > I changed the comma-separated sudo-list to an actual unordered list for > accessibility/semantic correctness. Is this OK @Judith? Sure, like that https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html#... pages/privacy.html:190: Naturally you have the right to receive, upon request, information about the personal data stored by us about you. You also have the right to correct inaccurate personal data, to block and delete details. To do so, please contact us via <a href="mailto:privacy@eyeo.com">privacy@eyeo.com</a> or mail to: On 2016/12/12 18:57:42, juliandoucette wrote: > Note: > > - Added a mailto link to the email address > - Made addresses consistent (semantically correct and multi-line) > > Is this OK @Judith? perfect
Just small changes. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:1: title=Privacy Policy You converted the file from markdown to HTML I think it makes sense to change the extension. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:20: While using the Eyeo.com website: This list is almost same as the one below, maybe we can include them, otherwise we have duplication here. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:40: When applying for a job: Detail: As mentioned above, I think we can also make this consistent ? I assume the data collection is same on both places and we need not to duplicate them IMO https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:58: Log-files, data entered by user into the job application form and cookies. Detail: Why not to make it list same as other comma separated text were done above. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:211: <time datetime="2016-08">August 2016</time> I think the date should be changed accordingly, also make sense to generate the date according datetime, otherwise we need to update it separately each time we change it. Note: the date generation can be done separately, considering that the changes are urgent.
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:102: Your protection and data confidentiality is of utmost importance to us ("Eyeo" "we" "our"). We take the protection of your personal data very serious and collect as less data as possible. Nevertheless, some personal data are necessary to provide our website and/or our application tools for candidates. This privacy policy shall inform you about the personal data we collect and how exactly that data is used. We gather and use personal data firmly within the provisions of the data protection laws of Germany. In the following text we will inform you about the specific data, the scope and purpose of the collection and use of personal data by us when using Eyeo. Another one: AFAIK we decided to use lowercase eyeo.
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 15:09:54, saroyanm wrote: > This list is almost same as the one below, maybe we can include them, otherwise > we have duplication here. Please do not change any content. I know that this is double, but this is required according to the short form template. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:40: When applying for a job: On 2016/12/13 15:09:54, saroyanm wrote: > Detail: As mentioned above, I think we can also make this consistent ? I assume > the data collection is same on both places and we need not to duplicate them IMO Same here: Please do not change any content. I know that this is double, but this is required according to the short form template. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:58: Log-files, data entered by user into the job application form and cookies. On 2016/12/13 15:09:54, saroyanm wrote: > Detail: Why not to make it list same as other comma separated text were done > above. both is fine for me. I just had the comma list, to have a real short form. But I don't mind https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:102: Your protection and data confidentiality is of utmost importance to us ("Eyeo" "we" "our"). We take the protection of your personal data very serious and collect as less data as possible. Nevertheless, some personal data are necessary to provide our website and/or our application tools for candidates. This privacy policy shall inform you about the personal data we collect and how exactly that data is used. We gather and use personal data firmly within the provisions of the data protection laws of Germany. In the following text we will inform you about the specific data, the scope and purpose of the collection and use of personal data by us when using Eyeo. On 2016/12/13 15:11:46, saroyanm wrote: > Another one: AFAIK we decided to use lowercase eyeo. true, I can unfortunately not change it in the code review https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:211: <time datetime="2016-08">August 2016</time> On 2016/12/13 15:09:54, saroyanm wrote: > I think the date should be changed accordingly, also make sense to generate the > date according datetime, otherwise we need to update it separately each time we > change it. > Note: the date generation can be done separately, considering that the changes > are urgent. If this is easy to implement, this would be great
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 15:18:21, j.nink wrote: > On 2016/12/13 15:09:54, saroyanm wrote: > > This list is almost same as the one below, maybe we can include them, > otherwise > > we have duplication here. > > Please do not change any content. I know that this is double, but this is > required according to the short form template. Acknowledged. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:40: When applying for a job: On 2016/12/13 15:18:21, j.nink wrote: > On 2016/12/13 15:09:54, saroyanm wrote: > > Detail: As mentioned above, I think we can also make this consistent ? I > assume > > the data collection is same on both places and we need not to duplicate them > IMO > > Same here: Please do not change any content. I know that this is double, but > this is required according to the short form template. Acknowledged. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:110: <address> @Judith: What about address block ? I assume at least we can not duplicate this.
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:110: <address> On 2016/12/13 15:27:35, saroyanm wrote: > @Judith: What about address block ? I assume at least we can not duplicate this. Why not? This is a different document. Long version as well as short version require those information. If delete such information from one document it is not in compliance any more
Added notes from the quick meeting with @Judith https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 15:18:21, j.nink wrote: > On 2016/12/13 15:09:54, saroyanm wrote: > > This list is almost same as the one below, maybe we can include them, > otherwise > > we have duplication here. > > Please do not change any content. I know that this is double, but this is > required according to the short form template. Aligned with Judith and apparently there was misunderstanding and she agreed not to have duplication in the code. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:40: When applying for a job: On 2016/12/13 15:18:21, j.nink wrote: > On 2016/12/13 15:09:54, saroyanm wrote: > > Detail: As mentioned above, I think we can also make this consistent ? I > assume > > the data collection is same on both places and we need not to duplicate them > IMO > > Same here: Please do not change any content. I know that this is double, but > this is required according to the short form template. We will keep code duplicated, because the full version is is more comples https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:110: <address> On 2016/12/13 15:27:35, saroyanm wrote: > @Judith: What about address block ? I assume at least we can not duplicate this. @Judith also agreed not to have duplication in the code for address.
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 15:57:43, saroyanm wrote: > On 2016/12/13 15:18:21, j.nink wrote: > > On 2016/12/13 15:09:54, saroyanm wrote: > > > This list is almost same as the one below, maybe we can include them, > > otherwise > > > we have duplication here. > > > > Please do not change any content. I know that this is double, but this is > > required according to the short form template. > > Aligned with Judith and apparently there was misunderstanding and she agreed not > to have duplication in the code. agreed https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:40: When applying for a job: On 2016/12/13 15:57:43, saroyanm wrote: > On 2016/12/13 15:18:21, j.nink wrote: > > On 2016/12/13 15:09:54, saroyanm wrote: > > > Detail: As mentioned above, I think we can also make this consistent ? I > > assume > > > the data collection is same on both places and we need not to duplicate them > > IMO > > > > Same here: Please do not change any content. I know that this is double, but > > this is required according to the short form template. > > We will keep code duplicated, because the full version is is more comples agreed https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:110: <address> On 2016/12/13 15:57:43, saroyanm wrote: > On 2016/12/13 15:27:35, saroyanm wrote: > > @Judith: What about address block ? I assume at least we can not duplicate > this. > > @Judith also agreed not to have duplication in the code for address. agreed
Please find one question below @Judith (Should we change the date at the bottom to December 2016?) https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:1: title=Privacy Policy On 2016/12/13 15:09:54, saroyanm wrote: > You converted the file from markdown to HTML I think it makes sense to change > the extension. I did change the extension? https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 15:59:21, j.nink wrote: > On 2016/12/13 15:57:43, saroyanm wrote: > > On 2016/12/13 15:18:21, j.nink wrote: > > > On 2016/12/13 15:09:54, saroyanm wrote: > > > > This list is almost same as the one below, maybe we can include them, > > > otherwise > > > > we have duplication here. > > > > > > Please do not change any content. I know that this is double, but this is > > > required according to the short form template. > > > > Aligned with Judith and apparently there was misunderstanding and she agreed > not > > to have duplication in the code. > > agreed Will-do. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:40: When applying for a job: On 2016/12/13 15:59:21, j.nink wrote: > On 2016/12/13 15:57:43, saroyanm wrote: > > On 2016/12/13 15:18:21, j.nink wrote: > > > On 2016/12/13 15:09:54, saroyanm wrote: > > > > Detail: As mentioned above, I think we can also make this consistent ? I > > > assume > > > > the data collection is same on both places and we need not to duplicate > them > > > IMO > > > > > > Same here: Please do not change any content. I know that this is double, but > > > this is required according to the short form template. > > > > We will keep code duplicated, because the full version is is more comples > > agreed Will-do. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:58: Log-files, data entered by user into the job application form and cookies. On 2016/12/13 15:18:21, j.nink wrote: > On 2016/12/13 15:09:54, saroyanm wrote: > > Detail: Why not to make it list same as other comma separated text were done > > above. > > both is fine for me. I just had the comma list, to have a real short form. But I > don't mind I didn't know that this was a two item list. I thought it was a sentence. Will-do. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:102: Your protection and data confidentiality is of utmost importance to us ("Eyeo" "we" "our"). We take the protection of your personal data very serious and collect as less data as possible. Nevertheless, some personal data are necessary to provide our website and/or our application tools for candidates. This privacy policy shall inform you about the personal data we collect and how exactly that data is used. We gather and use personal data firmly within the provisions of the data protection laws of Germany. In the following text we will inform you about the specific data, the scope and purpose of the collection and use of personal data by us when using Eyeo. On 2016/12/13 15:18:21, j.nink wrote: > On 2016/12/13 15:11:46, saroyanm wrote: > > Another one: AFAIK we decided to use lowercase eyeo. > > true, I can unfortunately not change it in the code review Will-do. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:110: <address> On 2016/12/13 15:59:21, j.nink wrote: > On 2016/12/13 15:57:43, saroyanm wrote: > > On 2016/12/13 15:27:35, saroyanm wrote: > > > @Judith: What about address block ? I assume at least we can not duplicate > > this. > > > > @Judith also agreed not to have duplication in the code for address. > > agreed Will-do. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:211: <time datetime="2016-08">August 2016</time> On 2016/12/13 15:18:21, j.nink wrote: > On 2016/12/13 15:09:54, saroyanm wrote: > > I think the date should be changed accordingly, also make sense to generate > the > > date according datetime, otherwise we need to update it separately each time > we > > change it. > > Note: the date generation can be done separately, considering that the changes > > are urgent. > > If this is easy to implement, this would be great - I'll remove the datetime property for now - @Judith are you saying that we should change this to "December 2016"?
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:1: title=Privacy Policy On 2016/12/13 16:41:09, juliandoucette wrote: > On 2016/12/13 15:09:54, saroyanm wrote: > > You converted the file from markdown to HTML I think it makes sense to change > > the extension. > > I did change the extension? Yes you did, sorry maybe I mixed some reviews, just ignore my comment.
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:211: <time datetime="2016-08">August 2016</time> On 2016/12/13 16:41:09, juliandoucette wrote: > On 2016/12/13 15:18:21, j.nink wrote: > > On 2016/12/13 15:09:54, saroyanm wrote: > > > I think the date should be changed accordingly, also make sense to generate > > the > > > date according datetime, otherwise we need to update it separately each time > > we > > > change it. > > > Note: the date generation can be done separately, considering that the > changes > > > are urgent. > > > > If this is easy to implement, this would be great > > - I'll remove the datetime property for now > - @Judith are you saying that we should change this to "December 2016"? Thanks, agreed
Thanks everyone! Sorry about the delay on this one. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:1: title=Privacy Policy On 2016/12/13 17:07:17, saroyanm wrote: > On 2016/12/13 16:41:09, juliandoucette wrote: > > On 2016/12/13 15:09:54, saroyanm wrote: > > > You converted the file from markdown to HTML I think it makes sense to > change > > > the extension. > > > > I did change the extension? > > Yes you did, sorry maybe I mixed some reviews, just ignore my comment. Done. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 16:41:09, juliandoucette wrote: > On 2016/12/13 15:59:21, j.nink wrote: > > On 2016/12/13 15:57:43, saroyanm wrote: > > > On 2016/12/13 15:18:21, j.nink wrote: > > > > On 2016/12/13 15:09:54, saroyanm wrote: > > > > > This list is almost same as the one below, maybe we can include them, > > > > otherwise > > > > > we have duplication here. > > > > > > > > Please do not change any content. I know that this is double, but this is > > > > required according to the short form template. > > > > > > Aligned with Judith and apparently there was misunderstanding and she agreed > > not > > > to have duplication in the code. > > > > agreed > > Will-do. Done. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:40: When applying for a job: On 2016/12/13 16:41:09, juliandoucette wrote: > On 2016/12/13 15:59:21, j.nink wrote: > > On 2016/12/13 15:57:43, saroyanm wrote: > > > On 2016/12/13 15:18:21, j.nink wrote: > > > > On 2016/12/13 15:09:54, saroyanm wrote: > > > > > Detail: As mentioned above, I think we can also make this consistent ? I > > > > assume > > > > > the data collection is same on both places and we need not to duplicate > > them > > > > IMO > > > > > > > > Same here: Please do not change any content. I know that this is double, > but > > > > this is required according to the short form template. > > > > > > We will keep code duplicated, because the full version is is more comples > > > > agreed > > Will-do. Done. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:58: Log-files, data entered by user into the job application form and cookies. On 2016/12/13 16:41:09, juliandoucette wrote: > On 2016/12/13 15:18:21, j.nink wrote: > > On 2016/12/13 15:09:54, saroyanm wrote: > > > Detail: Why not to make it list same as other comma separated text were done > > > above. > > > > both is fine for me. I just had the comma list, to have a real short form. But > I > > don't mind > > I didn't know that this was a two item list. I thought it was a sentence. > > Will-do. Done. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:102: Your protection and data confidentiality is of utmost importance to us ("Eyeo" "we" "our"). We take the protection of your personal data very serious and collect as less data as possible. Nevertheless, some personal data are necessary to provide our website and/or our application tools for candidates. This privacy policy shall inform you about the personal data we collect and how exactly that data is used. We gather and use personal data firmly within the provisions of the data protection laws of Germany. In the following text we will inform you about the specific data, the scope and purpose of the collection and use of personal data by us when using Eyeo. On 2016/12/13 16:41:09, juliandoucette wrote: > On 2016/12/13 15:18:21, j.nink wrote: > > On 2016/12/13 15:11:46, saroyanm wrote: > > > Another one: AFAIK we decided to use lowercase eyeo. > > > > true, I can unfortunately not change it in the code review > > Will-do. Done. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:110: <address> On 2016/12/13 16:41:09, juliandoucette wrote: > On 2016/12/13 15:59:21, j.nink wrote: > > On 2016/12/13 15:57:43, saroyanm wrote: > > > On 2016/12/13 15:27:35, saroyanm wrote: > > > > @Judith: What about address block ? I assume at least we can not duplicate > > > this. > > > > > > @Judith also agreed not to have duplication in the code for address. > > > > agreed > > Will-do. Done. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#... pages/privacy.html:211: <time datetime="2016-08">August 2016</time> On 2016/12/13 21:09:44, j.nink wrote: > On 2016/12/13 16:41:09, juliandoucette wrote: > > On 2016/12/13 15:18:21, j.nink wrote: > > > On 2016/12/13 15:09:54, saroyanm wrote: > > > > I think the date should be changed accordingly, also make sense to > generate > > > the > > > > date according datetime, otherwise we need to update it separately each > time > > > we > > > > change it. > > > > Note: the date generation can be done separately, considering that the > > changes > > > > are urgent. > > > > > > If this is easy to implement, this would be great > > > > - I'll remove the datetime property for now > > - @Judith are you saying that we should change this to "December 2016"? > > Thanks, agreed Done.
https://codereview.adblockplus.org/29367268/diff/29369059/includes/address.html File includes/address.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/includes/address.ht... includes/address.html:1: <address> We do include address also in the contacts page, we can replace it as well to avoid duplication. But while the contacts page is Markdown file I'll leave it up to you to use mixture of HTML and Markdown there or convert to HTML and include address afterward. https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html#... pages/privacy.html:43: <li>Data entered by user into the job application form and cookies</li> Detail: "cookies" is separate item in the list IMO.
https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html#... pages/privacy.html:43: <li>Data entered by user into the job application form and cookies</li> On 2016/12/19 14:57:28, saroyanm wrote: > Detail: "cookies" is separate item in the list IMO. That's the template form the Federal Ministry. We have to use it as it is and it is a summary. Please don't change it
https://codereview.adblockplus.org/29367268/diff/29369059/includes/address.html File includes/address.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/includes/address.ht... includes/address.html:1: <address> On 2016/12/19 14:57:28, saroyanm wrote: > We do include address also in the contacts page, we can replace it as well to > avoid duplication. > But while the contacts page is Markdown file I'll leave it up to you to use > mixture of HTML and Markdown there or convert to HTML and include address > afterward. We decided to do this seprately.
LGTM https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html#... pages/privacy.html:43: <li>Data entered by user into the job application form and cookies</li> On 2016/12/19 14:59:57, j.nink wrote: > On 2016/12/19 14:57:28, saroyanm wrote: > > Detail: "cookies" is separate item in the list IMO. > > That's the template form the Federal Ministry. We have to use it as it is and it > is a summary. Please don't change it There was a misunderstanding, Judith agreed to have Cookies as separate list item.
> LGTM Pushed: https://hg.adblockplus.org/web.eyeo.com/rev/d1e83b36ee55 
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
