Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29416579: Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty() (Closed)

Created:
April 18, 2017, 9:17 p.m. by hub
Modified:
April 19, 2017, 3:18 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 5034 - Part 1: Pass a JsValue directly to SetProperty() and return from GetProperty()

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove JsValue test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -121 lines) Patch
M include/AdblockPlus/JsEngine.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/JsValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/src/FiltersCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M shell/src/MatchesCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/src/SubscriptionsCommand.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/AppInfoJsObject.h View 1 chunk +1 line, -1 line 0 comments Download
M src/AppInfoJsObject.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/ConsoleJsObject.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ConsoleJsObject.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/FileSystemJsObject.h View 1 chunk +1 line, -1 line 0 comments Download
M src/FileSystemJsObject.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/FilterEngine.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/GlobalJsObject.h View 1 chunk +1 line, -1 line 0 comments Download
M src/GlobalJsObject.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M src/JsEngine.cpp View 1 2 chunks +6 lines, -7 lines 0 comments Download
M src/JsValue.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/Notification.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M src/WebRequestJsObject.h View 1 chunk +1 line, -1 line 0 comments Download
M src/WebRequestJsObject.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M test/FilterEngine.cpp View 6 chunks +31 lines, -31 lines 0 comments Download
M test/JsEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/JsValue.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4
hub
April 18, 2017, 9:17 p.m. (2017-04-18 21:17:53 UTC) #1
sergei
https://codereview.adblockplus.org/29416579/diff/29416580/src/JsEngine.cpp File src/JsEngine.cpp (right): https://codereview.adblockplus.org/29416579/diff/29416580/src/JsEngine.cpp#newcode333 src/JsEngine.cpp:333: if (global.IsUndefined() || global.IsNull()) It's different, previously it was ...
April 19, 2017, 10:24 a.m. (2017-04-19 10:24:31 UTC) #2
hub
updated patch. https://codereview.adblockplus.org/29416579/diff/29416580/src/JsEngine.cpp File src/JsEngine.cpp (right): https://codereview.adblockplus.org/29416579/diff/29416580/src/JsEngine.cpp#newcode333 src/JsEngine.cpp:333: if (global.IsUndefined() || global.IsNull()) On 2017/04/19 10:24:31, ...
April 19, 2017, 2:47 p.m. (2017-04-19 14:47:11 UTC) #3
sergei
April 19, 2017, 3:02 p.m. (2017-04-19 15:02:22 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld