Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(420)

Issue 29422625: Issue 5189 - use r-value references when objects should be transferred (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by sergei
Modified:
2 years, 11 months ago
Reviewers:
hub
CC:
Felix Dahlke, anton
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# I have also made changes even when it was not required to compile it, in particular compiler was able to convert a function accepting a const reference to a function accepting r-value reference. I made it for consistency and expect that it will simplify the maintenance of this code.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -89 lines) Patch
M include/AdblockPlus/FilterEngine.h View 3 chunks +3 lines, -8 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/FilterEngine.cpp View 6 chunks +28 lines, -47 lines 0 comments Download
M src/GlobalJsObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/JsEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M test/FilterEngine.cpp View 3 chunks +5 lines, -16 lines 0 comments Download
M test/JsEngine.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M test/Notification.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M test/UpdateCheck.cpp View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 2
sergei
2 years, 11 months ago (2017-04-26 14:19:06 UTC) #1
hub
2 years, 11 months ago (2017-04-26 15:18:48 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5