Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 29458572: Issue 5301 - Edge prepends extension path to URL when using tabs.create (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by Oleksandr
Modified:
2 years, 7 months ago
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 5301 - Edge prepends extension path to URL when using tabs.create

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ext/background.js View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 3
Oleksandr
2 years, 8 months ago (2017-06-07 12:00:50 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29458572/diff/29458573/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29458572/diff/29458573/ext/background.js#newcode704 ext/background.js:704: // NOTE: we expect this else branch to run ...
2 years, 8 months ago (2017-06-07 12:05:25 UTC) #2
Oleksandr
2 years, 8 months ago (2017-06-07 12:09:29 UTC) #3
https://codereview.adblockplus.org/29458572/diff/29458573/ext/background.js
File ext/background.js (right):

https://codereview.adblockplus.org/29458572/diff/29458573/ext/background.js#n...
ext/background.js:704: // NOTE: we expect this else branch to run only on Edge.
On 2017/06/07 12:05:25, Sebastian Noack wrote:
> Well, if we should ever merge this upstream it will not only run on Edge. Is
> this bug expected to be fixed in MS Edge soon enough in a version we can
require
> as minimum version? What would happen on Chrome and Firefox, if we use a
> relative URL here?

From what I understand only Edge does not support
chrome.runtime.openOptionsPage(). Which is why this code is ran only on Edge.
This patch is meant to be submitted to the master branch. There's also only 6
other small patches to make master compatible with Edge.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5