Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/ConsoleJsObject.cpp

Issue 29498576: Issue 4832 - remove API allowing changing of LogSystem after Initialization of JsEngine (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: address comment Created July 26, 2017, 4:48 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/BaseJsTest.cpp ('k') | test/JsEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ConsoleJsObject.cpp
diff --git a/test/ConsoleJsObject.cpp b/test/ConsoleJsObject.cpp
index 9405a01514c19343e7269076239a54c3a4f85e09..c3aae06e4803f8464f2886040988610a6d5f3237 100644
--- a/test/ConsoleJsObject.cpp
+++ b/test/ConsoleJsObject.cpp
@@ -35,18 +35,16 @@ namespace
}
};
- typedef std::shared_ptr<MockLogSystem> MockLogSystemPtr;
-
class ConsoleJsObjectTest : public BaseJsTest
{
protected:
- MockLogSystemPtr mockLogSystem;
+ MockLogSystem* mockLogSystem;
void SetUp()
{
- BaseJsTest::SetUp();
- mockLogSystem = MockLogSystemPtr(new MockLogSystem);
- jsEngine->SetLogSystem(mockLogSystem);
+ JsEngineCreationParameters jsEngineParams;
+ jsEngineParams.logSystem.reset(mockLogSystem = new MockLogSystem());
+ jsEngine = CreateJsEngine(std::move(jsEngineParams));
}
};
}
« no previous file with comments | « test/BaseJsTest.cpp ('k') | test/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld