Issue 29508569: Issue 5450 - don't expose std::shared_ptr<JsEngine>

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29508569: Issue 5450 - don't expose std::shared_ptr<JsEngine> (Closed)

Created:
Aug. 7, 2017, 8:39 a.m. by sergei

Modified:
Aug. 7, 2017, 2:51 p.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29508555/

Patch Set 1 #

Created: Aug. 7, 2017, 8:39 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+251 lines, -267 lines)			Patch
M	include/AdblockPlus/FilterEngine.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/Platform.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	shell/src/GcCommand.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	shell/src/GcCommand.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	shell/src/Main.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	shell/src/PrefsCommand.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/FilterEngine.cpp	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/Platform.cpp	View	1 chunk	+17 lines, -16 lines	0 comments	Download
M	test/AppInfoJsObject.cpp	View	1 chunk	+12 lines, -13 lines	0 comments	Download
M	test/BaseJsTest.h	View	1 chunk	+14 lines, -1 line	0 comments	Download
M	test/ConsoleJsObject.cpp	View	6 chunks	+7 lines, -10 lines	0 comments	Download
M	test/FileSystemJsObject.cpp	View	6 chunks	+36 lines, -38 lines	0 comments	Download
M	test/FilterEngine.cpp	View	9 chunks	+8 lines, -10 lines	0 comments	Download
M	test/GlobalJsObject.cpp	View	1 chunk	+14 lines, -30 lines	0 comments	Download
M	test/JsEngine.cpp	View	10 chunks	+30 lines, -37 lines	0 comments	Download
M	test/JsValue.cpp	View	11 chunks	+15 lines, -15 lines	0 comments	Download
M	test/Notification.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	test/Prefs.cpp	View	7 chunks	+18 lines, -19 lines	0 comments	Download
M	test/UpdateCheck.cpp	View	4 chunks	+6 lines, -7 lines	0 comments	Download
M	test/WebRequest.cpp	View	14 chunks	+55 lines, -51 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages

Issue 29508569: Issue 5450 - don't expose std::shared_ptr&lt;JsEngine> (Closed)

Description

Patch Set 1 #

Messages

Issue 29508569: Issue 5450 - don't expose std::shared_ptr<JsEngine> (Closed)