Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29549903: Issue 5664 - assert now accept one parameter. (Closed)

Created:
Sept. 19, 2017, 6:45 p.m. by hub
Modified:
Sept. 22, 2017, 1:18 p.m.
Reviewers:
sergei, Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5664 - assert now accept one parameter.

Patch Set 1 #

Patch Set 2 : Also StringMap #

Patch Set 3 : Used the wrong preprocessor operation for assert() #

Total comments: 2

Patch Set 4 : Leave assert() alone now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M compiled/String.h View 2 chunks +3 lines, -3 lines 0 comments Download
M compiled/StringMap.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/debug.h View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M compiled/intrusive_ptr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/storage/FilterStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M compiled/subscription/UserDefinedSubscription.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8
hub
Sept. 19, 2017, 6:45 p.m. (2017-09-19 18:45:50 UTC) #1
hub
I think we should instead rename the macros to something unique to us and leave ...
Sept. 19, 2017, 6:46 p.m. (2017-09-19 18:46:49 UTC) #2
sergei
`assert` with two arguments is also used in `compiled/StringMap.h`. Although in the issue I actually ...
Sept. 20, 2017, 7:42 a.m. (2017-09-20 07:42:56 UTC) #3
hub
On 2017/09/20 07:42:56, sergei wrote: > `assert` with two arguments is also used in `compiled/StringMap.h`. ...
Sept. 20, 2017, 1:06 p.m. (2017-09-20 13:06:31 UTC) #4
Wladimir Palant
I don't really like assert2 as a name but I don't have a better suggestion ...
Sept. 21, 2017, 8:01 a.m. (2017-09-21 08:01:19 UTC) #5
hub
https://codereview.adblockplus.org/29549903/diff/29550779/compiled/debug.h File compiled/debug.h (right): https://codereview.adblockplus.org/29549903/diff/29550779/compiled/debug.h#newcode55 compiled/debug.h:55: assert2(condition, u"Assertion failed: "#condition""_str) On 2017/09/21 08:01:19, Wladimir Palant ...
Sept. 21, 2017, 12:49 p.m. (2017-09-21 12:49:39 UTC) #6
Wladimir Palant
LGTM
Sept. 22, 2017, 10:13 a.m. (2017-09-22 10:13:58 UTC) #7
sergei
Sept. 22, 2017, 10:15 a.m. (2017-09-22 10:15:20 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld