Issue 5664 - assert now accept one parameter.

Issue 5664 - assert now accept one parameter.

[hub, 2017-09-19 18:46:49]

I think we should instead rename the macros to something unique to us and leave
the standard "assert()" alone.

But this patch doesn't do that.

[sergei, 2017-09-20 07:42:56]

`assert` with two arguments is also used in `compiled/StringMap.h`.

Although in the issue I actually didn't mean the exact name `assert2`, here it
looks fine for me. If there is some better name I have no objections.

On 2017/09/19 18:46:49, hub wrote:
> I think we should instead rename the macros to something unique to us and
leave
> the standard "assert()" alone.
I agree.
> 
> But this patch doesn't do that.

[hub, 2017-09-20 13:06:31]

On 2017/09/20 07:42:56, sergei wrote:
> `assert` with two arguments is also used in `compiled/StringMap.h`.

Oops, the compiler didn't catch it.

[Wladimir Palant, 2017-09-21 08:01:19]

I don't really like assert2 as a name but I don't have a better suggestion
either.

https://codereview.adblockplus.org/29549903/diff/29550779/compiled/debug.h
File compiled/debug.h (right):

https://codereview.adblockplus.org/29549903/diff/29550779/compiled/debug.h#ne...
compiled/debug.h:55: assert2(condition, u"Assertion failed: "#condition""_str)
Please don't define the assert() macro. The whole point of the issue is avoiding
conflict with the standard macro as defined in assert.h.

[hub, 2017-09-21 12:49:39]

https://codereview.adblockplus.org/29549903/diff/29550779/compiled/debug.h
File compiled/debug.h (right):

https://codereview.adblockplus.org/29549903/diff/29550779/compiled/debug.h#ne...
compiled/debug.h:55: assert2(condition, u"Assertion failed: "#condition""_str)
On 2017/09/21 08:01:19, Wladimir Palant wrote:
> Please don't define the assert() macro. The whole point of the issue is
avoiding
> conflict with the standard macro as defined in assert.h.

ok. done.

[Wladimir Palant, 2017-09-22 10:13:58]

LGTM

[sergei, 2017-09-22 10:15:20]

LGTM