Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29567798: Noissue - Replace ext.pages.open with tabs.create (Closed)

Created:
Oct. 6, 2017, 3:16 p.m. by Manish Jethani
Modified:
Oct. 8, 2017, 10:43 p.m.
Reviewers:
Sebastian Noack
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Replace ext.pages.open with tabs.create

Patch Set 1 #

Patch Set 2 : Remove ext.pages.open implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M ext/background.js View 1 1 chunk +0 lines, -4 lines 0 comments Download
M lib/notificationHelper.js View 1 chunk +4 lines, -2 lines 0 comments Download
M lib/subscriptionInit.js View 1 chunk +1 line, -1 line 0 comments Download
M notification.js View 1 1 chunk +1 line, -1 line 0 comments Download
M stats.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
Oct. 6, 2017, 3:16 p.m. (2017-10-06 15:16:36 UTC) #1
Manish Jethani
Patch Set 1
Oct. 6, 2017, 3:18 p.m. (2017-10-06 15:18:15 UTC) #2
Sebastian Noack
Shouldn't this commit also remove the implementation of ext.pages.open() from ext/background.js?
Oct. 8, 2017, 1:06 a.m. (2017-10-08 01:06:01 UTC) #3
Manish Jethani
Patch Set 2: Remove ext.pages.open implementation On 2017/10/08 01:06:01, Sebastian Noack wrote: > Shouldn't this ...
Oct. 8, 2017, 9:46 p.m. (2017-10-08 21:46:30 UTC) #4
Sebastian Noack
Oct. 8, 2017, 10:38 p.m. (2017-10-08 22:38:08 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld