Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29569615: Noissue - Replace ext.pages.query with tabs.query (Closed)

Created:
Oct. 8, 2017, 11:37 p.m. by Manish Jethani
Modified:
Oct. 9, 2017, 3:26 a.m.
Reviewers:
Sebastian Noack
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Replace ext.pages.query with tabs.query

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M ext/background.js View 1 chunk +0 lines, -18 lines 0 comments Download
M lib/filterComposer.js View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/icon.js View 1 chunk +3 lines, -1 line 0 comments Download
M lib/options.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/stats.js View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/whitelisting.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Oct. 8, 2017, 11:37 p.m. (2017-10-08 23:37:32 UTC) #1
Manish Jethani
Patch Set 1
Oct. 8, 2017, 11:39 p.m. (2017-10-08 23:39:46 UTC) #2
Sebastian Noack
Oct. 9, 2017, 2:35 a.m. (2017-10-09 02:35:24 UTC) #3
While for now this is slightly increasing the boilerplate, by redundantly
calling the ext.Page constructor, I think this is a step in the right direction,
towards removing ext. It seems there is no way around progressively removing
APIs and manually creating tab objects where necessary to interact with legacy
APIs until they have been replaced as well.

LGTM

Powered by Google App Engine
This is Rietveld