Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 29601581: Issue 5872 - apply style changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by saroyanm
Modified:
8 months ago
Reviewers:
ire
Visibility:
Public.

Description

Issue 5872 - apply style changes

Patch Set 1 : #

Total comments: 38

Patch Set 2 : Addressed Ire's comments #

Total comments: 27

Patch Set 3 : Additional style fixes #

Total comments: 2

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -106 lines) Patch
M desktop-options.html View 1 2 3 4 chunks +12 lines, -9 lines 0 comments Download
M skin/desktop-options.css View 1 2 3 4 44 chunks +125 lines, -92 lines 0 comments Download
A skin/icons/checkbox.svg View 1 chunk +10 lines, -0 lines 0 comments Download
M skin/icons/toggle.svg View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10
saroyanm
@Ire can you please have a look. If you will test in the Chrome please ...
8 months, 1 week ago (2017-11-08 15:46:46 UTC) #1
ire
On 2017/11/08 15:46:46, saroyanm wrote: > @Ire can you please have a look. > > ...
8 months, 1 week ago (2017-11-09 09:08:30 UTC) #2
saroyanm
Thanks Ire Sorry that it took so long to address your comments. Just got back ...
8 months, 1 week ago (2017-11-13 17:07:15 UTC) #3
ire
On 2017/11/13 17:07:15, saroyanm wrote: > Thanks Ire > Sorry that it took so long ...
8 months ago (2017-11-14 16:55:23 UTC) #4
saroyanm
Thanks for the comments, new patch is uploaded and ready for the review. https://codereview.adblockplus.org/29601581/diff/29601610/skin/desktop-options.css File ...
8 months ago (2017-11-14 19:19:01 UTC) #5
ire
https://codereview.adblockplus.org/29601581/diff/29606580/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29601581/diff/29606580/skin/desktop-options.css#newcode300 skin/desktop-options.css:300: box-shadow: inset 0 0 0 3px #077CA6; On 2017/11/14 ...
8 months ago (2017-11-15 07:00:47 UTC) #6
saroyanm
Thanks Ire, New patch is uploaded and ready for the review. https://codereview.adblockplus.org/29601581/diff/29606580/skin/desktop-options.css File skin/desktop-options.css (right): ...
8 months ago (2017-11-15 10:39:04 UTC) #7
ire
Thanks! A couple more comments but otherwise LGTM https://codereview.adblockplus.org/29601581/diff/29609564/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29601581/diff/29609564/skin/desktop-options.css#newcode59 skin/desktop-options.css:59: margin: ...
8 months ago (2017-11-15 13:49:28 UTC) #8
saroyanm
Thanks, addressed last comments, ready for the review https://codereview.adblockplus.org/29601581/diff/29609564/skin/desktop-options.css File skin/desktop-options.css (right): https://codereview.adblockplus.org/29601581/diff/29609564/skin/desktop-options.css#newcode59 skin/desktop-options.css:59: margin: ...
8 months ago (2017-11-15 14:51:23 UTC) #9
ire
8 months ago (2017-11-15 16:49:31 UTC) #10
On 2017/11/15 14:51:23, saroyanm wrote:
> Thanks, addressed last comments,
> ready for the review

Thanks LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5