Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 29611624: Issue 6047 - Updated templates and uninstalled pages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months ago by juliandoucette
Modified:
7 months ago
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

- Refactored default, minimal, and raw templates - Deprecated simple template - Updated uninstalled pages styles --- Please ignore defaults.css changes in this patchset. They have been provided here for the sake of convenience and should be reviewed separately here: - https://codereview.adblockplus.org/29612659/ - https://codereview.adblockplus.org/29612684/

Patch Set 1 #

Patch Set 2 : Fixed missing -1px in tablet media query #

Patch Set 3 : Updated button stytles #

Patch Set 4 : Changed document macro in html-attribute include, removed simple template, and removed temporary/unused resources include #

Total comments: 30

Patch Set 5 : Addressed comments #

Total comments: 14

Patch Set 6 : Addressed comments #

Total comments: 4

Patch Set 7 : Addressed #14 #

Total comments: 5

Patch Set 8 : Addressed comments in #15 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -632 lines) Patch
A includes/footer.tmpl View 1 chunk +69 lines, -0 lines 0 comments Download
A includes/html-attributes.tmpl View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
A includes/meta/favicon.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
A includes/meta/social.tmpl View 1 chunk +17 lines, -0 lines 0 comments Download
A includes/meta/standard.tmpl View 1 chunk +8 lines, -0 lines 0 comments Download
A includes/navbar.tmpl View 1 chunk +38 lines, -0 lines 0 comments Download
A includes/polyfills.tmpl View 1 chunk +14 lines, -0 lines 0 comments Download
A includes/reinstall.tmpl View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
A includes/scripts.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
A includes/styles.tmpl View 1 chunk +2 lines, -0 lines 0 comments Download
A macros/pageitem.tmpl View 1 chunk +7 lines, -0 lines 0 comments Download
M pages/index.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/uninstalled.tmpl View 1 2 3 4 5 6 1 chunk +63 lines, -145 lines 0 comments Download
A pages/uninstalled-submit.html View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
R pages/uninstalled-submit.md View 1 2 3 4 1 chunk +0 lines, -22 lines 0 comments Download
M static/css/defaults.css View 1 2 2 chunks +15 lines, -2 lines 0 comments Download
M static/css/main.css View 1 2 3 4 5 4 chunks +93 lines, -1 line 0 comments Download
R static/css/simple.css View 1 2 3 4 1 chunk +0 lines, -257 lines 0 comments Download
A static/css/uninstalled.css View 1 2 3 4 5 6 1 chunk +80 lines, -0 lines 0 comments Download
A static/js/uninstalled.js View 1 chunk +93 lines, -0 lines 0 comments Download
M templates/default.tmpl View 1 2 3 2 chunks +11 lines, -162 lines 0 comments Download
M templates/minimal.tmpl View 1 2 3 1 chunk +20 lines, -3 lines 0 comments Download
M templates/raw.tmpl View 1 2 3 1 chunk +15 lines, -1 line 0 comments Download
R templates/simple.tmpl View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 18
juliandoucette
8 months ago (2017-11-17 18:53:19 UTC) #1
juliandoucette
@Jeen @Paul: See https://drive.google.com/open?id=1B8rxkuGDGM9qh5M7SUccJPzmfJKkIz6q This change was meant to be an improvement, not a redesign. ...
8 months ago (2017-11-17 19:04:17 UTC) #2
jeen
On 2017/11/17 19:04:17, juliandoucette wrote: > @Jeen @Paul: > > See https://drive.google.com/open?id=1B8rxkuGDGM9qh5M7SUccJPzmfJKkIz6q > > This ...
8 months ago (2017-11-20 09:18:08 UTC) #3
juliandoucette
On 2017/11/20 09:18:08, jeen wrote: > @Julian, I like the overall design and layout of ...
8 months ago (2017-11-20 15:55:47 UTC) #4
juliandoucette
On 2017/11/20 15:55:47, juliandoucette wrote: > I'm still waiting on feedback about the primary (red) ...
7 months, 4 weeks ago (2017-11-22 15:36:33 UTC) #5
ire
Thanks Julian! Here are my first impressions: https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html File pages/uninstalled-submit.html (right): https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html#newcode14 pages/uninstalled-submit.html:14: <aside id="reinstall" ...
7 months, 3 weeks ago (2017-11-27 19:48:22 UTC) #6
juliandoucette
Thanks Ire :) https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html File pages/uninstalled-submit.html (right): https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html#newcode14 pages/uninstalled-submit.html:14: <aside id="reinstall" class="bg-accent" > On 2017/11/27 ...
7 months, 2 weeks ago (2017-12-04 13:34:05 UTC) #7
ire
https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html File pages/uninstalled-submit.html (right): https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html#newcode18 pages/uninstalled-submit.html:18: <a href="index" class="button"> On 2017/12/04 13:34:04, juliandoucette wrote: > ...
7 months, 2 weeks ago (2017-12-05 10:28:01 UTC) #8
juliandoucette
Thanks Ire, I will update and separate this a bit. https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html File pages/uninstalled-submit.html (right): https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html#newcode18 ...
7 months, 2 weeks ago (2017-12-06 16:05:07 UTC) #9
juliandoucette
Updated. https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html File pages/uninstalled-submit.html (right): https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html#newcode17 pages/uninstalled-submit.html:17: {{ reinstall-headline[Text next to the Reinstallation button] Did ...
7 months, 2 weeks ago (2017-12-06 16:30:54 UTC) #10
ire
Thanks Julian! https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html File pages/uninstalled-submit.html (right): https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html#newcode14 pages/uninstalled-submit.html:14: <aside id="reinstall" class="bg-accent" > On 2017/12/04 13:34:04, ...
7 months, 1 week ago (2017-12-07 12:36:27 UTC) #11
juliandoucette
Updated. https://codereview.adblockplus.org/29611624/diff/29631675/includes/html-attributes.tmpl File includes/html-attributes.tmpl (right): https://codereview.adblockplus.org/29611624/diff/29631675/includes/html-attributes.tmpl#newcode1 includes/html-attributes.tmpl:1: lang="{{ locale }}" On 2017/12/07 12:36:26, ire wrote: ...
7 months, 1 week ago (2017-12-08 16:49:53 UTC) #12
ire
I think you missed these comments: On 2017/12/07 12:36:27, ire wrote: > Thanks Julian! > ...
7 months, 1 week ago (2017-12-11 15:53:49 UTC) #13
juliandoucette
Thanks Ire! https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html File pages/uninstalled-submit.html (right): https://codereview.adblockplus.org/29611624/diff/29618555/pages/uninstalled-submit.html#newcode14 pages/uninstalled-submit.html:14: <aside id="reinstall" class="bg-accent" > On 2017/12/07 12:36:26, ...
7 months ago (2017-12-14 18:35:23 UTC) #14
ire
LGTM + NITs https://codereview.adblockplus.org/29611624/diff/29639595/includes/reinstall.tmpl File includes/reinstall.tmpl (right): https://codereview.adblockplus.org/29611624/diff/29639595/includes/reinstall.tmpl#newcode1 includes/reinstall.tmpl:1: <aside id="reinstall" class="bg-accent" > NIT: Extra ...
7 months ago (2017-12-18 08:43:09 UTC) #15
juliandoucette
Thanks Ire, Fixed. https://codereview.adblockplus.org/29611624/diff/29639595/includes/reinstall.tmpl File includes/reinstall.tmpl (right): https://codereview.adblockplus.org/29611624/diff/29639595/includes/reinstall.tmpl#newcode1 includes/reinstall.tmpl:1: <aside id="reinstall" class="bg-accent" > On 2017/12/18 ...
7 months ago (2017-12-18 12:58:12 UTC) #16
ire
(forgot to publish this) https://codereview.adblockplus.org/29611624/diff/29639595/includes/reinstall.tmpl File includes/reinstall.tmpl (right): https://codereview.adblockplus.org/29611624/diff/29639595/includes/reinstall.tmpl#newcode5 includes/reinstall.tmpl:5: {{ "index" | linkify(class="button inverse") ...
7 months ago (2017-12-20 08:12:59 UTC) #17
juliandoucette
7 months ago (2017-12-20 18:18:28 UTC) #18

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5