Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 29663688: Issue 6220 - add travis-ci configuration for adblockpluscore

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by sergei
Modified:
2 days, 14 hours ago
Reviewers:
tlucas, hub
CC:
kzar
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

only linux and osx # This part is for emscripten branch.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
.travis.yml View 1 chunk +40 lines, -0 lines 3 comments Download
.travis/prepare-emscripten.sh View 1 chunk +13 lines, -0 lines 0 comments Download
.travis/prepare-ninja.sh View 1 chunk +12 lines, -0 lines 3 comments Download

Messages

Total messages: 8
sergei
However it is not working right now because precompiled emscripten is linked with libraries which ...
1 week, 1 day ago (2018-01-11 21:48:12 UTC) #1
sergei
https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml#newcode28 .travis.yml:28: - pip3 install -q --user meson we cannot install ...
1 week, 1 day ago (2018-01-11 22:04:10 UTC) #2
hub
On 2018/01/11 21:48:12, sergei wrote: > However it is not working right now because precompiled ...
1 week ago (2018-01-12 14:36:30 UTC) #3
kzar
I don't have time (and am probably not the best person) to review this, but ...
4 days, 18 hours ago (2018-01-15 12:01:11 UTC) #4
kzar
4 days, 18 hours ago (2018-01-15 12:03:00 UTC) #5
tlucas
Hey there, sorry for the late reply. Please find the comments below. https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml File .travis.yml ...
2 days, 17 hours ago (2018-01-17 12:41:40 UTC) #6
sergei
https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml#newcode40 .travis.yml:40: email: false On 2018/01/17 12:41:39, tlucas wrote: > Do ...
2 days, 16 hours ago (2018-01-17 14:26:26 UTC) #7
tlucas
2 days, 14 hours ago (2018-01-17 16:39:03 UTC) #8
On 2018/01/17 14:26:26, sergei wrote:
> https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml
> File .travis.yml (right):
> 
>
https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml#newcode40
> .travis.yml:40: email: false
> On 2018/01/17 12:41:39, tlucas wrote:
> > Do we not want to be notified about failed builds?
> > Also, FWIW we could add some sugar and notify #adblockplus about succeeded
> > builds ;)
> 
> See
>
https://codereview.adblockplus.org/29663680/diff/29663681/.travis.yml#newcode22.
> 
>
https://codereview.adblockplus.org/29663688/diff/29663689/.travis/prepare-nin...
> File .travis/prepare-ninja.sh (right):
> 
>
https://codereview.adblockplus.org/29663688/diff/29663689/.travis/prepare-nin...
> .travis/prepare-ninja.sh:11: unzip third_party/ninja-build.zip -d
> third_party/ninja
> On 2018/01/17 12:41:39, tlucas wrote:
> > Please help me out here - can we be sure, that "unzip" is always given? If
> not,
> > you might want to add it to the "install"-section in .travis.yml
> 
> As far as I know travis-ci servers usually include a plenty of already
installed
> tools which can be absent on a fresh linux, in our case they are at least
wget,
> unzip and nvm. Since we are targeting only travis-ci here, I think we should
not
> include those tools because otherwise we would have to include a long list of
> tools (just imagine how difficult to follow this convention with android
> builds).

Well - at least it's not mentioned in their travis-ci's official environment
description:

https://docs.travis-ci.com/user/reference/trusty/

However - in case you verified it being available, then LGTM :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5