Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(271)

Issue 29663688: Issue 6220 - add travis-ci configuration for adblockpluscore (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by sergei
Modified:
4 months, 2 weeks ago
Reviewers:
Oleksandr, hub, tlucas
CC:
kzar, René Jeschke
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

only linux and osx # This part is for emscripten branch.

Patch Set 1 #

Total comments: 6

Patch Set 2 : add docker #

Patch Set 3 : rebase & fix openssl version on osx #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -0 lines) Patch
A .travis.yml View 1 2 1 chunk +33 lines, -0 lines 1 comment Download
A .travis/Dockerfile View 1 1 chunk +92 lines, -0 lines 0 comments Download
A .travis/activate-nodejs.sh View 1 1 chunk +10 lines, -0 lines 0 comments Download
A .travis/docker-run.sh View 1 1 chunk +13 lines, -0 lines 0 comments Download
A .travis/prepare-docker.sh View 1 1 chunk +17 lines, -0 lines 0 comments Download
A .travis/prepare-emscripten.sh View 1 1 chunk +13 lines, -0 lines 0 comments Download
A .travis/prepare-ninja.sh View 1 chunk +12 lines, -0 lines 0 comments Download
A .travis/travis-before_script.sh View 1 1 chunk +9 lines, -0 lines 0 comments Download
A .travis/travis-install.sh View 1 1 chunk +18 lines, -0 lines 0 comments Download
A .travis/travis-script.sh View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 16
sergei
However it is not working right now because precompiled emscripten is linked with libraries which ...
6 months, 1 week ago (2018-01-11 21:48:12 UTC) #1
sergei
https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml#newcode28 .travis.yml:28: - pip3 install -q --user meson we cannot install ...
6 months, 1 week ago (2018-01-11 22:04:10 UTC) #2
hub
On 2018/01/11 21:48:12, sergei wrote: > However it is not working right now because precompiled ...
6 months, 1 week ago (2018-01-12 14:36:30 UTC) #3
kzar
I don't have time (and am probably not the best person) to review this, but ...
6 months ago (2018-01-15 12:01:11 UTC) #4
kzar
6 months ago (2018-01-15 12:03:00 UTC) #5
tlucas
Hey there, sorry for the late reply. Please find the comments below. https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml File .travis.yml ...
6 months ago (2018-01-17 12:41:40 UTC) #6
sergei
https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml#newcode40 .travis.yml:40: email: false On 2018/01/17 12:41:39, tlucas wrote: > Do ...
6 months ago (2018-01-17 14:26:26 UTC) #7
tlucas
On 2018/01/17 14:26:26, sergei wrote: > https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml > File .travis.yml (right): > > https://codereview.adblockplus.org/29663688/diff/29663689/.travis.yml#newcode40 > ...
6 months ago (2018-01-17 16:39:03 UTC) #8
sergei
I have added docker config. Since regular init and some other system parts are not ...
5 months, 3 weeks ago (2018-01-26 16:34:33 UTC) #9
Oleksandr
LGTM. Is there support for Windows containers on Travis? That would be pretty useful as ...
4 months, 3 weeks ago (2018-02-23 10:19:31 UTC) #10
sergei
On 2018/02/23 10:19:31, Oleksandr wrote: > LGTM. Is there support for Windows containers on Travis? ...
4 months, 3 weeks ago (2018-02-23 10:27:09 UTC) #11
hub
Why can't we make a Docker image with all the requirements that would be fetched ...
4 months, 3 weeks ago (2018-02-24 18:35:43 UTC) #12
sergei
On 2018/02/24 18:35:43, hub wrote: > Why can't we make a Docker image with all ...
4 months, 3 weeks ago (2018-02-27 16:17:23 UTC) #13
hub
On 2018/02/27 16:17:23, sergei wrote: > On 2018/02/24 18:35:43, hub wrote: > > Why can't ...
4 months, 3 weeks ago (2018-02-27 16:54:21 UTC) #14
sergei
https://codereview.adblockplus.org/29663688/diff/29712568/.travis.yml File .travis.yml (right): https://codereview.adblockplus.org/29663688/diff/29712568/.travis.yml#newcode23 .travis.yml:23: - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then export ...
4 months, 2 weeks ago (2018-03-01 10:56:01 UTC) #15
hub
4 months, 2 weeks ago (2018-03-01 16:12:05 UTC) #16
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5