Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools) (Closed)

Created:
April 19, 2018, 12:58 p.m. by Sebastian Noack

Modified:
April 20, 2018, 11:21 a.m.

Reviewers:
tlucas

CC:
Vasily Kuznetsov

Visibility:
Public.

Description

Noissue - Adapt best practices for trailing commas (buildtools)

Patch Set 1 #

Patch Set 2 : Re-run script on Python 2, added flake8-commas extension #

Total comments: 1

Created: April 19, 2018, 2:09 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -42 lines)			Patch
M	build.py	View	1	8 chunks	+11 lines, -11 lines	0 comments	Download
M	chainedconfigparser.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ensure_dependencies.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	localeTools.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	packagerChrome.py	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download
M	packagerEdge.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	releaseAutomation.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/test_packagerEdge.py	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/test_packagerWebExt.py	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	tox.ini	View	1	2 chunks	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Sebastian Noack

see https://codereview.adblockplus.org/29756624/

April 19, 2018, 12:59 p.m. (2018-04-19 12:59:43 UTC) #1

Sebastian Noack

After re-running my script, flake8-commas found some more missing commas. Also I added the flake8-commas ...

April 19, 2018, 2:11 p.m. (2018-04-19 14:11:26 UTC) #2

tlucas

April 20, 2018, 7:14 a.m. (2018-04-20 07:14:43 UTC) #3

On 2018/04/19 14:11:26, Sebastian Noack wrote:
> After re-running my script, flake8-commas found some more missing commas. Also
I
> added the flake8-commas extenstion to the tox.ini.
> 
> https://codereview.adblockplus.org/29756673/diff/29756709/tox.ini
> File tox.ini (right):
> 
> https://codereview.adblockplus.org/29756673/diff/29756709/tox.ini#newcode6
> tox.ini:6: ignore = D1,C815
> C185 are commas after varargs which are a syntax error in Python 2.

LGTM

Expand All Messages | Collapse All Messages