Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 29796577: Issue 6720 - Do not package the qunit test files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by hub
Modified:
1 year, 5 months ago
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6720 - Do not package the qunit test files.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M metadata.chrome View 1 chunk +0 lines, -5 lines 2 comments Download

Messages

Total messages: 4
hub
1 year, 5 months ago (2018-06-01 18:03:43 UTC) #1
tlucas
Hey Hub, sorry for intruding this review, but i thought i might add something here ...
1 year, 5 months ago (2018-06-04 09:52:28 UTC) #2
hub
https://codereview.adblockplus.org/29796577/diff/29796578/metadata.chrome File metadata.chrome (left): https://codereview.adblockplus.org/29796577/diff/29796578/metadata.chrome#oldcode159 metadata.chrome:159: qunit/tests.js = On 2018/06/04 09:52:27, tlucas wrote: > This ...
1 year, 5 months ago (2018-06-04 12:21:19 UTC) #3
kzar
1 year, 5 months ago (2018-06-04 17:45:17 UTC) #4
LGTM, but remember to push to the next branch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5