Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29983597: Noissue - Fixed: extension_id_* option was ignored in builds for MS Edge (Closed)

Created:
Jan. 17, 2019, 1:19 a.m. by Sebastian Noack
Modified:
Jan. 17, 2019, 2:15 a.m.
Reviewers:
tlucas
Visibility:
Public.

Description

Noissue - Fixed: extension_id_* option was ignored in builds for MS Edge

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M packager.py View 1 chunk +5 lines, -4 lines 0 comments Download
M packagerEdge.py View 3 chunks +13 lines, -1 line 0 comments Download
M tests/expecteddata/AppxManifest_edge_release_build.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Sebastian Noack
This change already landed, and was used to create the release build of Adblock Plus ...
Jan. 17, 2019, 1:22 a.m. (2019-01-17 01:22:08 UTC) #1
tlucas
Jan. 17, 2019, 1:34 a.m. (2019-01-17 01:34:07 UTC) #2
On 2019/01/17 01:22:08, Sebastian Noack wrote:
> This change already landed, and was used to create the release build of
Adblock
> Plus 0.9.12 for Microsoft Edge.
> 
> Sorry for landing this change, before passing review. However, this was the
only
> way to move forward with the release.

It's ok, FWIW -> LGTM

Powered by Google App Engine
This is Rietveld