Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4677112304762880: Issue #1237 - Remove unused substitution marker (Closed)

Created:
Jan. 9, 2015, 4:32 a.m. by Eric
Modified:
Jan. 13, 2015, 3:07 p.m.
Reviewers:
Oleksandr
Visibility:
Public.

Description

Issue #1237 - Remove unused substitution marker The translation key "update-error-text" contains wording to provide the error text returned by libadblockplus, including an unused string substitution marker. Remove that wording. It's a good idea to provide the relevant error text to the user, but putting into a tooltip (the only place it appears) is definitely the wrong place for it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M locales/en.ini View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Eric
Jan. 9, 2015, 4:35 a.m. (2015-01-09 04:35:08 UTC) #1
Oleksandr
I think a better solution would be to fix the substitution instead of removing it.
Jan. 10, 2015, 11:13 p.m. (2015-01-10 23:13:14 UTC) #2
Eric
I've replied in the ticket. https://issues.adblockplus.org/ticket/1237
Jan. 12, 2015, 1 p.m. (2015-01-12 13:00:56 UTC) #3
Eric
Jan. 13, 2015, 3:07 p.m. (2015-01-13 15:07:41 UTC) #4
Closing as "won't fix in this way".

Powered by Google App Engine
This is Rietveld