Issue #1186 - Rename symbols defined in 'installer-lib'

Issue #1186 - Rename symbols defined in 'installer-lib'

The scope of this renaming set are the symbols that are defined in
'installer-lib'. Most of the changes are confined to the installer library
code itself. Some changes propagate to the unit tests for the installer
library.

-----

It is out of scope for this change set to change all the names in the
unit tests. Note that there's no renaming in the CA code; this was done
earlier

Also out of scope are formatting issues (although a few
are present).

[Oleksandr, 2015-06-11 07:07:39]

I think at this point i would be much easier and faster to just fix the code
style completely on all files in one patchset. Checking what is and is not in
scope of changesets like this takes more time than the actual change IMHO.

http://codereview.adblockplus.org/5992177905696768/diff/5668600916475904/inst...
File installer/src/installer-lib/DLL.h (right):

http://codereview.adblockplus.org/5992177905696768/diff/5668600916475904/inst...
installer/src/installer-lib/DLL.h:24: static DllModule & module();
How about Module()?

http://codereview.adblockplus.org/5992177905696768/diff/5668600916475904/inst...
File installer/src/installer-lib/process.cpp (right):

http://codereview.adblockplus.org/5992177905696768/diff/5668600916475904/inst...
installer/src/installer-lib/process.cpp:73: virtual result_type operator()(
first_argument_type result, second_argument_type return_value ) = 0 ;
Probably should be "returnValue"?

[Eric, 2015-06-19 16:14:04]

On 2015/06/11 07:07:39, Oleksandr wrote:
> I think at this point i would be much easier and faster to just fix the code
> style completely on all files in one patchset. Checking what is and is not in
> scope of changesets like this takes more time than the actual change IMHO.

We have two issues #1185 (formatting) and #1186 (symbol names) for this task.
I'm following the lead of the issues.

As far as splitting things up, these reviews are already too large by the
informal standard we've used for other changes. I've tried to keep them as small
as feasible.

https://codereview1.adblockplus.org/5992177905696768/diff/5668600916475904/in...
File installer/src/installer-lib/DLL.h (right):

https://codereview1.adblockplus.org/5992177905696768/diff/5668600916475904/in...
installer/src/installer-lib/DLL.h:24: static DllModule & module();
On 2015/06/11 07:07:39, Oleksandr wrote:
> How about Module()?

Done.

https://codereview1.adblockplus.org/5992177905696768/diff/5668600916475904/in...
File installer/src/installer-lib/process.cpp (right):

https://codereview1.adblockplus.org/5992177905696768/diff/5668600916475904/in...
installer/src/installer-lib/process.cpp:73: virtual result_type operator()(
first_argument_type result, second_argument_type return_value ) = 0 ;
On 2015/06/11 07:07:39, Oleksandr wrote:
> Probably should be "returnValue"?

Done.

[Eric, 2015-10-09 16:25:31]

Issue #1186 is a P2 issue.
The most recent activity, a new patch set, I posted a week shy of four months
ago.
It has had no activity since then.
The only changes are in the change set are capitalization.

Ping.

[Oleksandr, 2015-10-11 16:06:10]

LGTM