Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8432019: Added acceptable ads list to the options UI (Closed)

Created:
Sept. 24, 2012, 7:52 p.m. by Wladimir Palant
Modified:
Sept. 25, 2012, 6:38 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This adds the acceptable ads checkbox to the options that is just a simpler way to add/remove the subscription; All locale changes have been generated by update_locales.py (strings taken over from ABP/Firefox)

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -30 lines) Patch
M _locales/ar/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/bg/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/cs/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/da/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/de/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/el/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/en/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/en_GB/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/es/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/es_419/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/et/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/fi/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/fr/messages.json View 1 chunk +15 lines, -6 lines 0 comments Download
M _locales/he/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/hr/messages.json View 1 chunk +29 lines, -8 lines 0 comments Download
M _locales/hu/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/it/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/ja/messages.json View 2 chunks +10 lines, -1 line 0 comments Download
M _locales/ko/messages.json View 3 chunks +10 lines, -1 line 0 comments Download
M _locales/lt/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/nl/messages.json View 2 chunks +10 lines, -1 line 0 comments Download
M _locales/pl/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/pt_BR/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/pt_PT/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/ro/messages.json View 2 chunks +10 lines, -1 line 0 comments Download
M _locales/ru/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/sk/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/sl/messages.json View 2 chunks +6 lines, -0 lines 0 comments Download
M _locales/sr/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/sv/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/th/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/tr/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M _locales/uk/messages.json View 1 chunk +3 lines, -0 lines 0 comments Download
M _locales/zh_CN/messages.json View 2 chunks +16 lines, -7 lines 0 comments Download
M _locales/zh_TW/messages.json View 2 chunks +9 lines, -0 lines 0 comments Download
M background.js View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/adblockplus_compat.js View 1 chunk +2 lines, -0 lines 0 comments Download
M options.html View 1 2 chunks +19 lines, -0 lines 0 comments Download
M options.js View 4 chunks +47 lines, -5 lines 0 comments Download
M update_locales.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Sept. 24, 2012, 7:52 p.m. (2012-09-24 19:52:49 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/8432019/diff/1/_locales/de/messages.json File _locales/de/messages.json (right): http://codereview.adblockplus.org/8432019/diff/1/_locales/de/messages.json#newcode68 _locales/de/messages.json:68: "message": "Einige nicht aufdringliche Werbung zulassen" This sounds a ...
Sept. 25, 2012, 12:51 p.m. (2012-09-25 12:51:55 UTC) #2
Wladimir Palant
Only fixed the newline - see below on the locale changes. http://codereview.adblockplus.org/8432019/diff/1/_locales/de/messages.json File _locales/de/messages.json (right): ...
Sept. 25, 2012, 2:19 p.m. (2012-09-25 14:19:30 UTC) #3
Felix Dahlke
Sept. 25, 2012, 2:21 p.m. (2012-09-25 14:21:27 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld