Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(709)

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by hub
Modified:
1 week, 1 day ago
Reviewers:
sergei, Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5870 - Implement the new ElemHideEmulation filter type Applies on top: https://codereview.adblockplus.org/29594607/

Patch Set 1 #

Total comments: 2

Patch Set 2 : properly handle exception filters. some test fixes. #

Patch Set 3 : Rebased patch. Fix assertion. #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -43 lines) Patch
M compiled/filter/ElemHideBase.cpp View 1 2 3 chunks +97 lines, -2 lines 0 comments Download
M compiled/filter/Filter.cpp View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M test/elemHideEmulation.js View 1 2 2 chunks +30 lines, -13 lines 0 comments Download
M test/filterClasses.js View 1 2 5 chunks +21 lines, -23 lines 0 comments Download
M test/subscriptionClasses.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
hub
1 month, 1 week ago (2017-11-02 23:42:43 UTC) #1
hub
Also on top of my other patches. https://codereview.adblockplus.org/29595633/diff/29595634/compiled/filter/ElemHideEmulationFilter.cpp File compiled/filter/ElemHideEmulationFilter.cpp (right): https://codereview.adblockplus.org/29595633/diff/29595634/compiled/filter/ElemHideEmulationFilter.cpp#newcode24 compiled/filter/ElemHideEmulationFilter.cpp:24: OwnedString ConvertFilter(const ...
1 month, 1 week ago (2017-11-02 23:47:50 UTC) #2
hub
1 month, 1 week ago (2017-11-02 23:48:52 UTC) #3
also we need to merge the changes to the content script here. Not exactly sure
how we proceed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5