Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(617)

Issue 29748587: Issue 6063, 6531 - Update V8 to 6.5.254.41, use C++14 and NDK-r16b (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by sergei
Modified:
5 months ago
CC:
anton
Base URL:
https://github.com/adblockplus/libadblockplus@549616e865707b89e95659d55c70e22d63130ce5
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix for android and set proper V8 commits #

Patch Set 3 : update CI #

Patch Set 4 : fix and simplify build for Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -26 lines) Patch
M .travis.yml View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M Makefile View 2 chunks +3 lines, -1 line 0 comments Download
M android-v8-options.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M appveyor.yml View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M build-v8.cmd View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M build-v8.gypi View 1 1 chunk +12 lines, -0 lines 0 comments Download
M common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M createsolution.bat View 1 chunk +2 lines, -2 lines 0 comments Download
M dependencies View 1 1 chunk +7 lines, -7 lines 0 comments Download
M v8.gypi View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9
sergei
I will update V8 binaries and CI after landing https://codereview.adblockplus.org/29747555/ and receiving the confirmation from ...
5 months, 1 week ago (2018-04-10 13:56:49 UTC) #1
hub
LGTM https://codereview.adblockplus.org/29748587/diff/29748588/Makefile File Makefile (right): https://codereview.adblockplus.org/29748587/diff/29748588/Makefile#newcode142 Makefile:142: LOCAL_LDFLAGS="-Wl,--allow-multiple-definition" \ On 2018/04/10 13:56:48, sergei wrote: > ...
5 months, 1 week ago (2018-04-11 01:57:41 UTC) #2
hub
in https://issues.adblockplus.org/ticket/6063#comment:16 you mention the gn files need to be updated. Is it still the ...
5 months, 1 week ago (2018-04-11 02:01:04 UTC) #3
sergei
On 2018/04/11 02:01:04, hub wrote: > in https://issues.adblockplus.org/ticket/6063#comment:16 you mention the gn > files need ...
5 months, 1 week ago (2018-04-11 08:00:04 UTC) #4
sergei
I hope it's the final version, if there are some CI issues I will let ...
5 months ago (2018-04-18 16:00:18 UTC) #5
hub
LGTM
5 months ago (2018-04-18 18:29:14 UTC) #6
sergei
On 2018/04/18 18:29:14, hub wrote: > LGTM I have just submitted the patch set 4, ...
5 months ago (2018-04-18 18:44:54 UTC) #7
sergei
BTW, the CI for linux/android/osx passed, I had also prepared on the server binaries of ...
5 months ago (2018-04-18 18:48:26 UTC) #8
hub
5 months ago (2018-04-18 18:50:28 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5