Issue 6632 - Add missing translations and new languages

Issue 6632 - Add missing translations and new languages

[hub, 2018-04-27 16:25:50]

1. I don't use computers in French so I might miss nuances in the jargon.

2. I commented on what I find being obviously wrong in French.

3. I don't know the justification for having both a fr_CA and a fr translation
when the difference is the use of the word "annonce" instead of "publicité" in
fr_CA. It seems to not be the appropriate translation for "ad" in that context.
After all an "ad blocker" is a "bloqueur de publicité" not "bloqueur d'annonce".

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
File
libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml:10:
<string name="fragment_adblock_settings_wl_title">Domaines de liste
blanche</string>
Should be "Domaines sur liste blanche", like in plain "fr"

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml:13:
<string name="fragment_adblock_settings_wl_domains">Domaines de liste
blanche</string>
Exact same as above.

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
File libadblockplus-android-settings/res/values-fr/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
libadblockplus-android-settings/res/values-fr/adblock_settings_strings.xml:5:
<string name="fragment_adblock_settings_enabled_summary">Autoriser le blocage de
publicités sur les sites web dans cette appli</string>
should be "application" not "appli". Like in fr_CA.

[hub, 2018-04-27 16:28:51]

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
File libadblockplus-android-settings/res/values-fr/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
libadblockplus-android-settings/res/values-fr/adblock_settings_strings.xml:5:
<string name="fragment_adblock_settings_enabled_summary">Autoriser le blocage de
publicités sur les sites web dans cette appli</string>
On 2018/04/27 16:25:50, hub wrote:
> should be "application" not "appli". Like in fr_CA.

don't take my absolute word on this one though, just that it is inconsistent
with the fr_CA translation and the complete word is "application" (like in
English where the orginal word for "app" is "application")

[hub, 2018-04-27 16:47:40]

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
File
libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml:10:
<string name="fragment_adblock_settings_wl_title">Domaines de liste
blanche</string>
On 2018/04/27 16:25:50, hub wrote:
> Should be "Domaines sur liste blanche", like in plain "fr"

Just to clarify. Proposed translation mean "Domains of the whitelist".
Translation in "fr" and corrected above mean "Domains in the whitelist"

[Oleksandr, 2018-04-27 16:53:57]

On 2018/04/27 16:47:40, hub wrote:
>
https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
> File
> libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml
> (right):
> 
>
https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
>
libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml:10:
> <string name="fragment_adblock_settings_wl_title">Domaines de liste
> blanche</string>
> On 2018/04/27 16:25:50, hub wrote:
> > Should be "Domaines sur liste blanche", like in plain "fr"
> 
> Just to clarify. Proposed translation mean "Domains of the whitelist".
> Translation in "fr" and corrected above mean "Domains in the whitelist"

LGTM as far as I am concerned

[jens, 2018-04-27 16:57:10]

On 2018/04/27 16:47:40, hub wrote:
>
https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
> File
> libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml
> (right):
> 
>
https://codereview.adblockplus.org/29763638/diff/29763807/libadblockplus-andr...
>
libadblockplus-android-settings/res/values-fr-rCA/adblock_settings_strings.xml:10:
> <string name="fragment_adblock_settings_wl_title">Domaines de liste
> blanche</string>
> On 2018/04/27 16:25:50, hub wrote:
> > Should be "Domaines sur liste blanche", like in plain "fr"
> 
> Just to clarify. Proposed translation mean "Domains of the whitelist".
> Translation in "fr" and corrected above mean "Domains in the whitelist"

Thanks for the quick review Hubert. Maybe I should have pointed out that you
don't need to review the translations itself. That was done by Tamara and the
agency. I think Microsoft requested to also add fr-rCA, but I am not entirely
sure about the background of having this language translated.
Reviewing added translations for Android is more about checking if no copy&paste
or volatility errors happened. As a reference you can check the english
translations. Sometimes there can be the same string two times, just with a
different key.

[hub, 2018-04-27 17:05:54]

On 2018/04/27 16:57:10, jens wrote:

> Thanks for the quick review Hubert. Maybe I should have pointed out that you
> don't need to review the translations itself. That was done by Tamara and the
> agency. I think Microsoft requested to also add fr-rCA, but I am not entirely
> sure about the background of having this language translated.
> Reviewing added translations for Android is more about checking if no
copy&paste
> or volatility errors happened. As a reference you can check the english
> translations. Sometimes there can be the same string two times, just with a
> different key.

Having the string twice is not the problem I'm pointing out. I'm pointing out
that the translation doesn't actually make sense. The French (fr) is correct,
the fr_CA isn't (including based off the original string).

String ids are:
fragment_adblock_settings_wl_title
fragment_adblock_settings_wl_domains

[jens, 2018-04-27 19:24:50]

On 2018/04/27 17:05:54, hub wrote:
> On 2018/04/27 16:57:10, jens wrote:
> 
> > Thanks for the quick review Hubert. Maybe I should have pointed out that you
> > don't need to review the translations itself. That was done by Tamara and
the
> > agency. I think Microsoft requested to also add fr-rCA, but I am not
entirely
> > sure about the background of having this language translated.
> > Reviewing added translations for Android is more about checking if no
> copy&paste
> > or volatility errors happened. As a reference you can check the english
> > translations. Sometimes there can be the same string two times, just with a
> > different key.
> 
> Having the string twice is not the problem I'm pointing out. I'm pointing out
> that the translation doesn't actually make sense. The French (fr) is correct,
> the fr_CA isn't (including based off the original string).
> 
> String ids are:
> fragment_adblock_settings_wl_title
> fragment_adblock_settings_wl_domains

Thanks for pointing that out, but this is exactly what I got from Tamara (and
what she got from the translators), I just double-checked it.
Please talk to Simonetta what to do now.
Since the translations are quite urgent and the mistakes are minor, maybe we can
adjust the two strings in a separate issue.

[hub, 2018-04-27 19:30:36]

is that's good enough for you then LGTM.

Definitely an issue should be filed with the translators.

[jens, 2018-04-27 23:04:05]

On 2018/04/27 19:30:36, hub wrote:
> is that's good enough for you then LGTM.
> 
> Definitely an issue should be filed with the translators.

As I said before, the decision should be made by Simonetta. 
Please ask her about it. I will be off on Monday and Tuesday.

[s.batteiger, 2018-05-02 09:35:47]

I just spoke with Tamara about the two strings Hubert mentioned and we agree
with his requested changes.
Tamara will update the translation file for you accordingly.

Background on why we even have both locales: We got a request to support all
Android language locales and French Canadian is one of them. If we currently
don't have differences between French French and Canadian French, then they will
have the same content. If at some point we were to add strings that would be
different, we could support it.

[jens, 2018-05-02 11:14:59]

On 2018/05/02 09:35:47, s.batteiger wrote:
> I just spoke with Tamara about the two strings Hubert mentioned and we agree
> with his requested changes.
> Tamara will update the translation file for you accordingly.
> 
> Background on why we even have both locales: We got a request to support all
> Android language locales and French Canadian is one of them. If we currently
> don't have differences between French French and Canadian French, then they
will
> have the same content. If at some point we were to add strings that would be
> different, we could support it.

I just uploaded another patch set with the updated French Canadian translations.

[Oleksandr, 2018-05-02 11:23:52]

Still LGTM

[hub, 2018-05-02 12:26:49]

LGTM