Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 30011555: Issue 7303 - Deprecate the use of String.prototype.substr() (Closed)

Created:
Feb. 19, 2019, 4:47 p.m. by hub
Modified:
Feb. 21, 2019, 8:11 p.m.
Reviewers:
Manish Jethani
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 7303 - Deprecate the use of String.prototype.substr()

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Rebase. Revert changes in hot path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M lib/common.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M lib/content/elemHideEmulation.js View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/filterClasses.js View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M lib/matcher.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/rsa.js View 2 chunks +6 lines, -3 lines 0 comments Download
M test/_common.js View 1 chunk +5 lines, -5 lines 0 comments Download
M test/matcher.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/signatures.js View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9
hub
Feb. 19, 2019, 4:47 p.m. (2019-02-19 16:47:11 UTC) #1
Manish Jethani
This needs a rebase.
Feb. 21, 2019, 2:46 p.m. (2019-02-21 14:46:34 UTC) #2
Manish Jethani
This needs a rebase.
Feb. 21, 2019, 2:46 p.m. (2019-02-21 14:46:34 UTC) #3
hub
rebased
Feb. 21, 2019, 2:49 p.m. (2019-02-21 14:49:04 UTC) #4
Manish Jethani
There are two places where I think we should leave the call to substr() as ...
Feb. 21, 2019, 3:04 p.m. (2019-02-21 15:04:39 UTC) #5
hub
updated. https://codereview.adblockplus.org/30011555/diff/30013594/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/30011555/diff/30013594/lib/filterClasses.js#newcode915 lib/filterClasses.js:915: pattern = pattern.substring(2); On 2019/02/21 15:04:39, Manish Jethani ...
Feb. 21, 2019, 6:09 p.m. (2019-02-21 18:09:42 UTC) #6
Manish Jethani
LGTM
Feb. 21, 2019, 7:58 p.m. (2019-02-21 19:58:55 UTC) #7
Manish Jethani
On 2019/02/21 19:58:55, Manish Jethani wrote: > LGTM Can we remove the unnecessary dot from ...
Feb. 21, 2019, 7:59 p.m. (2019-02-21 19:59:20 UTC) #8
hub
Feb. 21, 2019, 8:10 p.m. (2019-02-21 20:10:26 UTC) #9
On 2019/02/21 19:59:20, Manish Jethani wrote:
> On 2019/02/21 19:58:55, Manish Jethani wrote:
> > LGTM
> 
> Can we remove the unnecessary dot from the end of the summary?

Will do. Thanks !

Powered by Google App Engine
This is Rietveld