Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(740)

Issue 29574591: Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by Wladimir Palant
Modified:
1 week ago
Reviewers:
hub, sergei
CC:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Issue 5258 - Implement Filter::As<>() method to make working with filters easier from C++ code

Patch Set 1 #

Total comments: 7

Patch Set 2 : Use static classType member #

Total comments: 4

Patch Set 3 : Removed unnecessary base class check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -68 lines) Patch
M compiled/filter/ActiveFilter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/BlockingFilter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/BlockingFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/CommentFilter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/CommentFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/ElemHideBase.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/ElemHideEmulationFilter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/ElemHideEmulationFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/ElemHideException.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/ElemHideException.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/ElemHideFilter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/ElemHideFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/Filter.h View 1 2 1 chunk +26 lines, -6 lines 0 comments Download
M compiled/filter/Filter.cpp View 1 1 chunk +7 lines, -7 lines 0 comments Download
M compiled/filter/InvalidFilter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/InvalidFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/RegExpFilter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/WhitelistFilter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiled/filter/WhitelistFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/subscription/DownloadableSubscription.h View 1 2 chunks +1 line, -9 lines 0 comments Download
M compiled/subscription/DownloadableSubscription.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M compiled/subscription/Subscription.h View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M compiled/subscription/UserDefinedSubscription.h View 1 1 chunk +1 line, -9 lines 0 comments Download
M compiled/subscription/UserDefinedSubscription.cpp View 1 1 chunk +13 lines, -27 lines 0 comments Download

Messages

Total messages: 11
Wladimir Palant
1 week, 1 day ago (2017-10-12 12:14:01 UTC) #1
sergei
https://codereview.adblockplus.org/29574591/diff/29574592/compiled/filter/ActiveFilter.h File compiled/filter/ActiveFilter.h (right): https://codereview.adblockplus.org/29574591/diff/29574592/compiled/filter/ActiveFilter.h#newcode75 compiled/filter/ActiveFilter.h:75: if ((mType & Type::ACTIVE) == Type::ACTIVE) I wonder whether ...
1 week, 1 day ago (2017-10-12 12:24:34 UTC) #2
hub
https://codereview.adblockplus.org/29574591/diff/29574592/compiled/filter/ActiveFilter.h File compiled/filter/ActiveFilter.h (right): https://codereview.adblockplus.org/29574591/diff/29574592/compiled/filter/ActiveFilter.h#newcode75 compiled/filter/ActiveFilter.h:75: if ((mType & Type::ACTIVE) == Type::ACTIVE) On 2017/10/12 12:24:34, ...
1 week, 1 day ago (2017-10-12 13:51:33 UTC) #3
sergei
https://codereview.adblockplus.org/29574591/diff/29574592/compiled/filter/ActiveFilter.h File compiled/filter/ActiveFilter.h (right): https://codereview.adblockplus.org/29574591/diff/29574592/compiled/filter/ActiveFilter.h#newcode75 compiled/filter/ActiveFilter.h:75: if ((mType & Type::ACTIVE) == Type::ACTIVE) On 2017/10/12 13:51:33, ...
1 week, 1 day ago (2017-10-12 13:57:31 UTC) #4
hub
https://codereview.adblockplus.org/29574591/diff/29574592/compiled/filter/ActiveFilter.h File compiled/filter/ActiveFilter.h (right): https://codereview.adblockplus.org/29574591/diff/29574592/compiled/filter/ActiveFilter.h#newcode75 compiled/filter/ActiveFilter.h:75: if ((mType & Type::ACTIVE) == Type::ACTIVE) > A method ...
1 week, 1 day ago (2017-10-12 14:03:01 UTC) #5
Wladimir Palant
Making this consistent pulled in a large number of changes unfortunately - very straightforward still. ...
1 week ago (2017-10-13 11:43:29 UTC) #6
sergei
LGTM, just in case, I have left a couple of thoughts. https://codereview.adblockplus.org/29574591/diff/29575605/compiled/subscription/Subscription.h File compiled/subscription/Subscription.h (right): ...
1 week ago (2017-10-13 12:34:37 UTC) #7
hub
LGTM
1 week ago (2017-10-13 14:47:29 UTC) #8
Wladimir Palant
https://codereview.adblockplus.org/29574591/diff/29575605/compiled/subscription/Subscription.h File compiled/subscription/Subscription.h (right): https://codereview.adblockplus.org/29574591/diff/29575605/compiled/subscription/Subscription.h#newcode103 compiled/subscription/Subscription.h:103: typename std::enable_if<std::is_base_of<Subscription, T>::value>::type* = nullptr> On 2017/10/13 12:34:36, sergei ...
1 week ago (2017-10-13 16:58:18 UTC) #9
hub
LGTM
1 week ago (2017-10-13 18:12:02 UTC) #10
sergei
1 week ago (2017-10-13 18:40:53 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5