Issue 29363713: No issue - Help Center Adblock Plus topics (Closed)
|
Created:
Nov. 21, 2016, 11:32 p.m. by juliandoucette Modified:
July 5, 2017, 9:32 p.m. CC:
ire Visibility:
Public. |
DescriptionThe following is the help center content for Adblock Plus.
COLLABORATOR=lisa@adblockplus.org
Patch Set 1 : Draft 1 #
Total comments: 163
Patch Set 2 : Draft 2 #
Total comments: 132
Patch Set 3 : Draft 3 #
Total comments: 33
Patch Set 4 : Draft 4 #
Total comments: 12
Patch Set 5 : Draft 5 #MessagesTotal messages: 56
- I renamed all files from camelCase to dash-separated
- I replaced all strong tags surrounding platform names with H3s
- I was going to separate these files by platform
- However I am having second thoughts about that
- Separating them by platform duplicates all of the title/description
combinations and logically requires more includes (for the beginning content of
each page)
- Maybe there is a better sitescripts solution?
- If we are able to do browser detection (like we do on ABP.org) then we
can hide/show content based on a class applied to the body
- Thoughts @Manvel?
- title and description are currently missing from all pages @Lisa
- I don't think that this number of articles and the ability to search by
"### chrome" (or other platform) blocks QA
- Thoughts @Philip?
https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-chrome.md:3: 1. **Mac OS X and Linux**: Click **Chrome** and select **Preferences**. I am not sure about Linux, but on OS X I don't quite understand where the user is meant to navigate to? If this is implying that 'whilst in Chrome, select preferences' then this should be clearly stated. We can't assume that users when reading the help page, are already in the correct browser. In addition to this, OS X (for me at least) worked more like Windows Chrome than Linux - as in, whilst in Chrome in OS X, the user would need to 'Click the **Chrome menu icon** and select **Settings** and not 'Click **Chrome** and select **Preferences**'.
https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-chrome.md:3: 1. **Mac OS X and Linux**: Click **Chrome** and select **Preferences**. On 2016/11/23 08:02:22, scott wrote: > I am not sure about Linux, but on OS X I don't quite understand where the user > is meant to navigate to? If this is implying that 'whilst in Chrome, select > preferences' then this should be clearly stated. We can't assume that users when > reading the help page, are already in the correct browser. > > In addition to this, OS X (for me at least) worked more like Windows Chrome than > Linux - as in, whilst in Chrome in OS X, the user would need to 'Click the > **Chrome menu icon** and select **Settings** and not 'Click **Chrome** and > select **Preferences**'. On Linux, you have the same Chrome menu as on Windows, no fancy mac-like menu bar.
https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-maxthon.md:8: 5. Close the window. Step 4 already closes the window in Maxthon 5. https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-opera.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-opera.md:3: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. 'Opera menu icon' would sound better. To make this even clearer, but would be significantly more text, you could put 'Click the Opera menu icon in the top left....' https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:10: It's stated that 'A default list - Easylist - based on your browser's language settings is automatically activated'. This is a tad confusing, as, if the user is French, then the default list would not be - Easylist -, but rather - ListeFR + Easylist -. As not to confuse other language browser users, restructuring the sentence to 'A default filter list based on your browser's language settings is automatically activated when you install Adblock Plus.' https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:21: For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Chrome, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:26: There are two issues here. The first one is, that the state of the 'Disable Everywhere' button needs to be taken into account first. If the button is not enabled and they select this option, then they are disabling the app everywhere, which counteracts the point of this help article. So, we need to word this differently. Secondly, in Firefox, you are able to also disable and enable the extension via the add-ons page of the browser. So, as well as the 'Disable Everywhere' option, the add-ons page also needs to be checked to ensure that ABP is enabled in Firefox. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:31: The same issue as the above Firefox issue applies to Internet Explorer. The state of the 'Disable Everywhere' button needs to be taken into account. If the button is not enabled and they select this option, then they are disabling the app everywhere, which counteracts the point of this help article. So, we need to word this differently. Additionally, in Internet Explorer, you are able to also disable and enable the extension via the add-ons page of the browser. So, as well as the 'Disable Everywhere' option, the add-ons page also needs to be checked to ensure that ABP is enabled. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:36: This is currently different for the latest Maxthon 5 version. With Maxthon 5 the user needs to select the settings menu, then select tools and then extensions. After this, just like Chrome, they then need to select the check box to enable the extension. Do we want to have two entries here, one for Maxthon 4.9 and below and one from 5.0 and up? https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:41: For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Opera, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:47: Speaking purely from a non-OS-X user here - I think it might be easier for the user to understand step 1. if it stated 'From the OS-X Menu bar at the top of the screen, click **Safari** and select **Preferences**'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:52: For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Yandex, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first.
Minor point. https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-chrome.md:3: 1. **Mac OS X and Linux**: Click **Chrome** and select **Preferences**. On 2016/11/23 13:33:15, Philip Hill wrote: > On 2016/11/23 08:02:22, scott wrote: > > I am not sure about Linux, but on OS X I don't quite understand where the user > > is meant to navigate to? If this is implying that 'whilst in Chrome, select > > preferences' then this should be clearly stated. We can't assume that users > when > > reading the help page, are already in the correct browser. > > > > In addition to this, OS X (for me at least) worked more like Windows Chrome > than > > Linux - as in, whilst in Chrome in OS X, the user would need to 'Click the > > **Chrome menu icon** and select **Settings** and not 'Click **Chrome** and > > select **Preferences**'. > > On Linux, you have the same Chrome menu as on Windows, no fancy mac-like menu > bar. - **GNU + Linux** menu bar is generally the same as windows - **Gnome** 3.0+ also contains a mac-like application menu item - EG Chrome -> Preferences, Firefox -> Preferences
https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-firefox.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-firefox.md:12: 7. If a filter rule appears in the right window, do one of the following: Should this be worded more 'If a filter rule appears in the right Window for the website you are seeing ads on'? Otherwise, they could well just delete a whole bunch of filter rules that don't relate to the issue at hand? https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-maxthon.md:3: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Maxthon, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first. In Maxthon 5+ the steps are as follows: Select the Options Menu from the top right Select Tools Select Extensions https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-safari.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-safari.md:3: 1. Click the **Adblock Plus icon** and select **Options**. For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Safari, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first. To navigate to the extensions page in Safari: With Safari open, select Safari in the OS X option bar at the top of the screen Select Preferences Select Extensions https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/adblock-plus-will-not-install.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:24: <br> The version is displayed next to the Firefox icon. If your browser is out-of-date, Chrome will automatically start the update process. 'Chrome will automatically start the update process.' Should be 'Firefox will automatically start the update process.' https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:33: 2. Click the **Help icon**. There is no help icon. The user needs to select the options menu (the cog on the top right of the browser), to then be able to select 'About Internet Explorer'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:37: 3. [Uninstall](https://support.microsoft.com/en-us/search?query=uninstall%20a%20program) and reinstall Adblock Plus. Why do we suggest to re-install Adblock Plus here, but no on other browsers? I understand that resetting settings from browsers like Chrome and Firefox is good advice, but if we suggest an uninstall and re-install in IE, then we should also suggest this in all other browsers. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:44: 2. Click the **Opera icon**. **Opera Menu icon** would help in guiding the user as the icon itself has 'Menu' on it. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:65: <br> The version is displayed below the Yandex.Browser icon. The version is displayed to the left of the Yandex Browser icon.
https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-maxthon.md:3: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/11/24 11:40:32, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Maxthon, if the user > has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. > > In Maxthon 5+ the steps are as follows: > > Select the Options Menu from the top right > Select Tools > Select Extensions Good points. What if we always go the short way via the ABP icon but add some "What if I don't see the ABP icon" section as include everywhere?
https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-maxthon.md:3: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/11/25 07:21:36, Philip Hill wrote: > On 2016/11/24 11:40:32, scott wrote: > > For consistency here, we should always have the same way to access the > > extension. For example, with the situation given here in Maxthon, if the user > > has > > the extension disabled, then there would not be any ABP icon for them to > select. > > In addition to this, some browsers allow hiding of icons in the extensions > bar, > > so it's safer for the user to navigate to the extensions page from within the > > browser menu first. > > > > In Maxthon 5+ the steps are as follows: > > > > Select the Options Menu from the top right > > Select Tools > > Select Extensions > > Good points. What if we always go the short way via the ABP icon but add some > "What if I don't see the ABP icon" section as include everywhere? I guess we could do this, but then we just add more content to the help centre. If creating more content isn't an issue, then we could just link that in-between the first and second step. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/adding-afilter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:3: Adblock Plus requires filter lists to block ads. A default filter list - EasyList - based on your browser's language settings is automatically activated when you install Adblock Plus. It blocks ads from the most popular (often English language-based) websites. However, it does not block ads on less popular national websites. For example, if you live in Germany you should subscribe to the national German filter list. As stated in a previous comment, if the user already has their browser in a different language, then that language filter list would have already been installed and not '- EasyList -' to stop confusion here, I would simply omit - EasyList - from the sentence. 'Adblock Plus requires filter lists to block ads. A default filter list, based on your browser's language settings, is automatically activated when you install Adblock Plus. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:19: 7. Close the tab. The user should make sure that the list has correctly been downloaded before closing the tab. The suggested step would be 'Make sure that the list you have selected show 'Last Updated' as 'Just Now'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:33: 8. Close the window. The user should make sure that the list has correctly been downloaded before closing the tab. The suggested step would be 'Make sure that the list you have selected show 'Last Updated' as 'Just Now' (Success). https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:38: <br>**Tip**: If you do not see the Adblock Plus icon, right-click the tab bar (the empty area near the tabs) and select **Status bar**. This is helpful, but in the case that ABP is disabled in add-ons even after selecting to view the status bar, the icon still might appear. It might be helpful to state or link to how to check if the extension is enabled also. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:50: 5. Click **Done**. The user should make sure that the list has correctly been downloaded before closing the tab. The suggested step would be 'Make sure that the list you have selected show 'Last Updated' as 'Just Now'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:54: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. It would help the user if it was 'Click on the Opera Menu icon' as Menu is what is written on the icon in question. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:62: 7. Close the tab. The user should make sure that the list has correctly been downloaded before closing the tab. The suggested step would be 'Make sure that the list you have selected show 'Last Updated' as 'Just Now'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:70: 4. Click **Add**. The step to close the window afterwards is missing here (it is shown in every last step above for each browser). In addition to this, the user should make sure that the list has correctly been downloaded before closing the tab. The suggested step would be 'Make sure that the list you have selected show 'Last Updated' as 'Just Now'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:76: 3. Select the **filter list** you would like to subscribe to below *Other Languages*. Because the app does not refresh it's UI state when a list is selected, I would suggest having the last step here as 'Select back', so that the user returns back and when entering the Filter List again, they can see that it has been successfully added. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:88: 7. Close the tab. The user should make sure that the list has correctly been downloaded before closing the tab. The suggested step would be 'Make sure that the list you have selected show 'Last Updated' as 'Just Now'.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/adding-awebsite-to-the-whitelist.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:15: 6. Close the tab. An additional step of 'Check that the domain has correctly entered the box below' so that the user can confirm the process completed correctly. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:19: 1. Go to the website that you want to whitelist. I am unsure as to why we are showing how to whitelist via icon here, but not above with Chrome or even vice versa? We should either always show the same way to whitelist or show both. Having one way on one browser and a different one on another when both options are available seems odd and inconsistent. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:26: <br>**Tip**: If you do not see the Adblock Plus icon, right-click the tab bar (the empty area near the tabs) and select **Status bar**. In the case that the extension is disabled, the icon will not display in the status bar at all. I wonder if it is worth us adding a link to a different article here about how to check if ABP is enabled, so, if the user hits this issue whilst following these steps, then they have a reference point to check against. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:29: 3. Enter the website URL and click **Add**. The user should also check that the URL has been correctly added to the box below before closing the window. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:35: 2. Tap **Whitelisted Websites**. Currently, each time the app is opened, the user needs to select the 'tool' icon a the bottom of the first run screen to get to the menu. This should probably be stated here as a step in between 1. and 2. currently. From what I am aware of, this will change in the future, but I think it is important to have this there now. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:38: 5. Tap the **+ sign**. The last step should be 'Confirm that the URL has successfully been entered into the 'Your Whitelist' section below. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:42: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Maxthon, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:45: 3. Enter the website URL and click **Add domain**. The user should also have a step here where they need to check that the URL has been entered correctly into the box below. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:46: 4. Click **Done**. Clicking Done in Maxthon 5 already closes the window. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:51: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. It would help the user to have it worded as 'Click the Opera Menu icon' as the icon already has the word 'Menu' on it. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:57: 5. Enter the website URL and click **Add domain**. The user should also have a step here where they need to check that the URL has been entered correctly into the box below. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:66: 4. Close the tab. The user should also have a step here where they need to check that the URL has been entered correctly into the box below. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:77: 6. Close the tab. The user should also have a step here where they need to check that the URL has been entered correctly into the box below.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/blocking-all-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/blocking-all-ads.md:41: 1. Open the Adblock Plus for iOS app. There is a step after step 1. where the user needs to click the tools icon at the bottom of the page. It might be worth adding this step in for consistency. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/blocking-all-ads.md:43: 3. Tap the box labeled **Allow some nonintrusive ads**. This should read 'Tap the toggle labeled' https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/blocking-all-ads.md:47: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Maxthon, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/blocking-all-ads.md:55: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. This should read 'Clock the Opera Menu icon' as the icon already has the wording 'Menu' on it.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/configuring-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/configuring-automatic-updates.md:8: - **On Wi-Fi only** - Updates the app only when you are connected to Wi-Fi. Technically, this does not update the app but rather updates the filter lists. The wording 'Updates the filter lists only when you are connected to Wi-Fi' would work. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/configuring-automatic-updates.md:9: - **Always** - Updates the app at any time, using either Wi-Fi or mobile data. Technically, this does not update the app but rather updates the filter lists. The wording 'Updates the filter lists at any time, using either Wi-Fi or mobile data.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/downloading-and-installing-adblock-plus.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:12: 4. Click **Add**. Should read 'Click **Add extension** button. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:20: 3. Click **Add**. Should read 'Click **Add extension** button. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:30: 4. Click **Install Now**. The dialog box for me reads 'Install' not 'Install Now' (Firefox 47) https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:39: <br>A dialog box opens. It would be useful to state what this dialog box is actually telling the user. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:40: 4. Click **Yes**. There is an additional window that opens for me, if the user has IE open at the time of installing the extension. So, step 3 and 4 need to be duplicated in step 5 also. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:49: 10. Click **Enable**. Step 11. should include that the user needs to restart IE for the changes to take effect. This is an important step. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:54: 1. Go to the App Store and search for **Adblock Plus for iOS**. This should definitely work, but, could we not also supply a direct link for people viewing this help article on an iOS device? This would make things a lot more smoother for them. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:55: 2. Tap **Install**. There should be a step three that then tells the user to open the app. It may seem obvious to us, but this will then also help with the next steps below in enabling content blocking in Safari (the first run screens have a guide also). https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:81: 4. Click **Install**. For me, the dialogue box states 'Trust', not 'Install'. Once the 'Trust' button is selected, the extension is installed. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:86: 1. Open the **Finder**. I think that the first step should clearly state that the user follows these guidelines AFTER clicking install for Safari on our main page. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:90: 5. Click **Install**. Again, I am presented with 'Trust' and not 'Install'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:94: 1. Go to the Google Play Store and search for **Adblock Plus for Samsung Browser**. Could we not also link to the play store entry, so that people viewing this article from an Android device are able to just click the link directly and load into the Play store? https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:95: 2. Tap **Install**. Step three should state that the user should open the app first as the app itself has a step by step to enable Adblock Plus in Sbrowser and will help with the steps also supplied below.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/hiding-the-adblock-plus-icon.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/hiding-the-adblock-plus-icon.md:14: 1. Click **Chrome** and select **Preferences**. I am unable to see any 'Show icon' button anywhere in the extensions page. I have navigated around for some time and the only way I see to enable the icon after hiding it in Chrome is to Select the Settings tab in Chrome (the icon is shown in the menu at the top) and to then right-click the ABP icon and select 'Show in Toolbar'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/hiding-the-adblock-plus-icon.md:42: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. This should read 'Click the Opera Menu icon' as Menu is already stated on the icon. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/hiding-the-adblock-plus-icon.md:50: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. This should read 'Click the Opera Menu icon' as Menu is already stated on the icon.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/not-compatible-error-message.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/not-compatible-error-message.md:5: To ensure that your browser is up-to-date, visit <https://whatbrowser.org/>. We should probably refer to some form of documentation that displays on what Android versions and iOS version /devices ABP iOS/Android and Sbrowser function on.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/removing-afilter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-afilter-list.md:41: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. This should read 'Click the **Opera Menu icon**' as the icon already has 'Menu' on it. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-afilter-list.md:71: 5. Click **OK**. It is trivial, but in Yandex browser it is 'Yes' not, 'OK'.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/removing-afilter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-afilter-list.md:61: 3. Select the **filter list** you would like to remove below *Other Languages*. We should add a step after to state that the user should press 'back'. The UI does not refresh in the app, so to see that it is actually removed (apart from it being un-selected), the user should select back and then can see the change when entering the UI again. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/removing-awebsite-from-the-whitelist.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:33: <br>**Tip**: If you do not see the Adblock Plus icon, right-click the tab bar (the empty area near the tabs) and select **Status bar**. We should also try to put in suggestions here for if then the icon does not appear in the status bar. As, in some cases the extension might be disabled. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:41: 1. Open the Adblock Plus for iOS app. There is a step before step 2. that requires the user to select the 'tools' icon at the bottom of the screen. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:47: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Maxthon, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:51: 4. Click **Done**. Selecting Done already closes the window in Maxthon 5. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:56: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. This should read 'Click the Opera Menu icon' as the word 'Menu' is already located on the icon itself.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/unblocking-ablocked-item.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:38: 1. Click the **Adblock Plus icon** and select **Adblock Plus options**. For consistency here, we should always have the same way to access the extension. For example, with the situation given here in Maxthon, if the user has the extension disabled, then there would not be any ABP icon for them to select. In addition to this, some browsers allow hiding of icons in the extensions bar, so it's safer for the user to navigate to the extensions page from within the browser menu first. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:41: 3. Select the filter you want to remove and click **Remove selected**. In Maxthon 5, this works a little differently. The user selects the 'Add your own filter' tab, but then instead of selecting 'Remove selected' they need to right click the required filter and then select 'Delete'. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:45: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. This should read 'Click the **Opera Menu icon**' as the icon already has the word 'menu' on it.
What are acceptable ads https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/what-are-acceptable-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/what-are-acceptable-ads.md:9: - Are appropriate Are appropriate to the site that we are on - Should be clear that the ads should emit similar content to the one found on the website. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/what-are-acceptable-ads.md:11: The Acceptable Ads criteria was developed in 2011 as a joint effort between Adblock Plus and its community of users. When you install Adblock Plus and Adblock Browser, all annoying ads are blocked by default. Should mention "However ABP allows non-intrusive ads by default which can be switched off in the Settings panel under the Filter list tab"
using ABP to disable tracking https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/using-adblock-plus-to-disable-tracking.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/using-adblock-plus-to-disable-tracking.md:4: ### Adblock Bowser for Android 1. Open Adblock Browser app 2. Tap in the top right corner on the three vertical dots for "more" 3. Tap **Settings** 4. Select **Ad blocking** Change ad blocking language, options, default settings 5. Access **More blocking options** Disable tracking and malware sites or add custom filter lists 6. Enable **Disable tracking**
using ABP to disable social media buttons https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/using-adblock-plus-to-disable-social-media-buttons.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/using-adblock-plus-to-disable-social-media-buttons.md:4: ### Adblock Bowser for Android 1. Open Adblock Browser app 2. Tap in the top right corner on the three vertical dots for "more" 3. Tap **Settings** 4. Select **Ad blocking** Change ad blocking language, options, default settings 5. Access **More blocking options** Disable tracking and malware sites or add custom filter lists 6. Enable **Disable social media buttons**
Using ABP to disable malware domains https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/using-adblock-plus-to-disable-malware-domains.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/using-adblock-plus-to-disable-malware-domains.md:4: ### Adblock Bowser for Android 1. Open Adblock Browser app 2. Tap in the top right corner on the three vertical dots for "more" 3. Tap **Settings** 4. Select **Ad blocking** Change ad blocking language, options, default settings 5. Access **More blocking options** Disable tracking and malware sites or add custom filter lists 6. Tap **Disable malware domains** to block domains known to spread malicious software, such as viruses, Trojan horses, worms and spyware.
ABP same thing as Adblock https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/is-adblock-plus-the-same-thing-as-ad-block.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/is-adblock-plus-the-same-thing-as-ad-block.md:3: In short - no. Both are ad blockers, but they are separate projects. Adblock Plus is a version of the original "ad-blocking" project; AdBlock originated in 2009 for Google Chrome. "The developer of AdBlock, Michael Gundlach, claims to have been inspired by the Adblock Plus extension for Firefox"- Quote from Wikipedia, perhaps we should add "Adblock originated in 2009 for Google Chrome and was inspired by Adblock Plus"
ABP is blocking too much content https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/adblock-plus-is-blocking-too-much-content.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-is-blocking-too-much-content.md:4: This can be caused by another issue than filters, if the topic is to direct user to only verify for filter issues then we should tell him to disable his current filter rather than disabling ABP (An example of such an issue is the whitelisting feature is not working in which case all filter lists are bad). https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-is-blocking-too-much-content.md:8: Also "Adblock Browser for Android" to be added in the list.
remove whitelist for IE https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-internetexplorer.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-internetexplorer.md:3: 1. From the status bar, click the **Adblock Plus icon** and select **Settings**. It's really hard to notice so perhaps should add an indication: From the status bar (located at the bottom of your browser), click the **Adblock Plus icon** and select **Settings**.
I started reviewing your feedback. I'm about half way through the files (started from the top). https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-chrome.md:3: 1. **Mac OS X and Linux**: Click **Chrome** and select **Preferences**. On 2016/11/23 08:02:22, scott wrote: > I am not sure about Linux, but on OS X I don't quite understand where the user > is meant to navigate to? If this is implying that 'whilst in Chrome, select > preferences' then this should be clearly stated. We can't assume that users when > reading the help page, are already in the correct browser. > > In addition to this, OS X (for me at least) worked more like Windows Chrome than > Linux - as in, whilst in Chrome in OS X, the user would need to 'Click the > **Chrome menu icon** and select **Settings** and not 'Click **Chrome** and > select **Preferences**'. Changed to: 1. Click the **Chrome menu icon** in the upper right corner of the toolbar and select **Settings**. Removed Mac/Linux instructions. Will change each instance of this. https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-firefox.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-firefox.md:12: 7. If a filter rule appears in the right window, do one of the following: On 2016/11/24 11:40:32, scott wrote: > Should this be worded more 'If a filter rule appears in the right Window for the > website you are seeing ads on'? Otherwise, they could well just delete a whole > bunch of filter rules that don't relate to the issue at hand? Updated https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-internetexplorer.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-internetexplorer.md:3: 1. From the status bar, click the **Adblock Plus icon** and select **Settings**. On 2016/12/01 02:48:42, robert wrote: > It's really hard to notice so perhaps should add an indication: From the status > bar (located at the bottom of your browser), click the **Adblock Plus icon** and > select **Settings**. The original content included images (for this reason). Since we can't use images or icons in the help center, I'll change it. https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-maxthon.md:3: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/11/24 11:40:32, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Maxthon, if the user > has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. > > In Maxthon 5+ the steps are as follows: > > Select the Options Menu from the top right > Select Tools > Select Extensions Updated. Was using Maxthon 4.9 (according to the About tab, I was up-to-date). https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-maxthon.md:3: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/11/25 07:21:36, Philip Hill wrote: > On 2016/11/24 11:40:32, scott wrote: > > For consistency here, we should always have the same way to access the > > extension. For example, with the situation given here in Maxthon, if the user > > has > > the extension disabled, then there would not be any ABP icon for them to > select. > > In addition to this, some browsers allow hiding of icons in the extensions > bar, > > so it's safer for the user to navigate to the extensions page from within the > > browser menu first. > > > > In Maxthon 5+ the steps are as follows: > > > > Select the Options Menu from the top right > > Select Tools > > Select Extensions > > Good points. What if we always go the short way via the ABP icon but add some > "What if I don't see the ABP icon" section as include everywhere? There is a hiding/showing ABP icon topic. I'd prefer to leave it as the "long way." https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-opera.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-opera.md:3: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. On 2016/11/23 14:20:41, scott wrote: > 'Opera menu icon' would sound better. To make this even clearer, but would be > significantly more text, you could put 'Click the Opera menu icon in the top > left....' Updated. https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-safari.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-safari.md:3: 1. Click the **Adblock Plus icon** and select **Options**. On 2016/11/24 11:40:32, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Safari, if the user has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. > > To navigate to the extensions page in Safari: > > With Safari open, select Safari in the OS X option bar at the top of the screen > Select Preferences > Select Extensions Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:10: On 2016/11/23 14:20:41, scott wrote: > It's stated that 'A default list - Easylist - based on your browser's language > settings is automatically activated'. This is a tad confusing, as, if the user > is French, then the default list would not be - Easylist -, but rather - ListeFR > + Easylist -. As not to confuse other language browser users, restructuring the > sentence to 'A default filter list based on your browser's language settings is > automatically activated when you install Adblock Plus.' Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:21: On 2016/11/23 14:20:41, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Chrome, if the user has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:31: On 2016/11/23 14:20:41, scott wrote: > The same issue as the above Firefox issue applies to Internet Explorer. The > state of the 'Disable Everywhere' button needs to be taken into account. If the > button is not enabled and they select this option, then they are disabling the > app everywhere, which counteracts the point of this help article. So, we need to > word this differently. Additionally, in Internet Explorer, you are able to also > disable and enable the extension via the add-ons page of the browser. So, as > well as the 'Disable Everywhere' option, the add-ons page also needs to be > checked to ensure that ABP is enabled. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:36: On 2016/11/23 14:20:41, scott wrote: > This is currently different for the latest Maxthon 5 version. With Maxthon 5 the > user needs to select the settings menu, then select tools and then extensions. > After this, just like Chrome, they then need to select the check box to enable > the extension. Do we want to have two entries here, one for Maxthon 4.9 and > below and one from 5.0 and up? Updated. The best practice in tech writing is to always use the latest version of the browser, software, etc. If we add Maxthon 4.9 steps, then we would have to consider adding other outdated versions to the other platforms. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:41: On 2016/11/23 14:20:41, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Opera, if the user has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:47: On 2016/11/23 14:20:41, scott wrote: > Speaking purely from a non-OS-X user here - I think it might be easier for the > user to understand step 1. if it stated 'From the OS-X Menu bar at the top of > the screen, click **Safari** and select **Preferences**'. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:52: On 2016/11/23 14:20:41, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Yandex, if the user has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/adblock-plus-will-not-install.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:24: <br> The version is displayed next to the Firefox icon. If your browser is out-of-date, Chrome will automatically start the update process. On 2016/11/24 11:40:32, scott wrote: > 'Chrome will automatically start the update process.' Should be 'Firefox will > automatically start the update process.' > Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:33: 2. Click the **Help icon**. On 2016/11/24 11:40:32, scott wrote: > There is no help icon. The user needs to select the options menu (the cog on the > top right of the browser), to then be able to select 'About Internet Explorer'. I see a '?' icon, or help icon. I'm on version 11.447.14398.0 https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:37: 3. [Uninstall](https://support.microsoft.com/en-us/search?query=uninstall%20a%20program) and reinstall Adblock Plus. On 2016/11/24 11:40:32, scott wrote: > Why do we suggest to re-install Adblock Plus here, but no on other browsers? I > understand that resetting settings from browsers like Chrome and Firefox is good > advice, but if we suggest an uninstall and re-install in IE, then we should also > suggest this in all other browsers. Updated all browser with uninstall instructions. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:44: 2. Click the **Opera icon**. On 2016/11/24 11:40:32, scott wrote: > **Opera Menu icon** would help in guiding the user as the icon itself has 'Menu' > on it. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adblock-plus-will-not-install.md:65: <br> The version is displayed below the Yandex.Browser icon. On 2016/11/24 11:40:32, scott wrote: > The version is displayed to the left of the Yandex Browser icon. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/adding-afilter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:3: Adblock Plus requires filter lists to block ads. A default filter list - EasyList - based on your browser's language settings is automatically activated when you install Adblock Plus. It blocks ads from the most popular (often English language-based) websites. However, it does not block ads on less popular national websites. For example, if you live in Germany you should subscribe to the national German filter list. On 2016/11/29 09:08:43, scott wrote: > As stated in a previous comment, if the user already has their browser in a > different language, then that language filter list would have already been > installed and not '- EasyList -' to stop confusion here, I would simply omit - > EasyList - from the sentence. 'Adblock Plus requires filter lists to block ads. > A default filter list, based on your browser's language settings, is > automatically activated when you install Adblock Plus. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:19: 7. Close the tab. On 2016/11/29 09:08:43, scott wrote: > The user should make sure that the list has correctly been downloaded before > closing the tab. The suggested step would be 'Make sure that the list you have > selected show 'Last Updated' as 'Just Now'. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:33: 8. Close the window. On 2016/11/29 09:08:43, scott wrote: > The user should make sure that the list has correctly been downloaded before > closing the tab. The suggested step would be 'Make sure that the list you have > selected show 'Last Updated' as 'Just Now' (Success). Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:50: 5. Click **Done**. On 2016/11/29 09:08:43, scott wrote: > The user should make sure that the list has correctly been downloaded before > closing the tab. The suggested step would be 'Make sure that the list you have > selected show 'Last Updated' as 'Just Now'. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:54: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. On 2016/11/29 09:08:43, scott wrote: > It would help the user if it was 'Click on the Opera Menu icon' as Menu is what > is written on the icon in question. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:62: 7. Close the tab. On 2016/11/29 09:08:43, scott wrote: > The user should make sure that the list has correctly been downloaded before > closing the tab. The suggested step would be 'Make sure that the list you have > selected show 'Last Updated' as 'Just Now'. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:70: 4. Click **Add**. On 2016/11/29 09:08:43, scott wrote: > The step to close the window afterwards is missing here (it is shown in every > last step above for each browser). In addition to this, the user should make > sure that the list has correctly been downloaded before closing the tab. The > suggested step would be 'Make sure that the list you have selected show 'Last > Updated' as 'Just Now'. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:76: 3. Select the **filter list** you would like to subscribe to below *Other Languages*. On 2016/11/29 09:08:43, scott wrote: > Because the app does not refresh it's UI state when a list is selected, I would > suggest having the last step here as 'Select back', so that the user returns > back and when entering the Filter List again, they can see that it has been > successfully added. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-afilter-list.md:88: 7. Close the tab. On 2016/11/29 09:08:43, scott wrote: > The user should make sure that the list has correctly been downloaded before > closing the tab. The suggested step would be 'Make sure that the list you have > selected show 'Last Updated' as 'Just Now'. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/adding-awebsite-to-the-whitelist.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:19: 1. Go to the website that you want to whitelist. On 2016/11/29 09:31:43, scott wrote: > I am unsure as to why we are showing how to whitelist via icon here, but not > above with Chrome or even vice versa? We should either always show the same way > to whitelist or show both. Having one way on one browser and a different one on > another when both options are available seems odd and inconsistent. I am unsure how to add a website to the whitelist on Firefox. Any tips? https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/adding-awebsite-to-the-whitelist.md:42: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/11/29 09:31:43, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Maxthon, if the user > has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/blocking-all-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/blocking-all-ads.md:41: 1. Open the Adblock Plus for iOS app. On 2016/11/29 10:09:43, scott wrote: > There is a step after step 1. where the user needs to click the tools icon at > the bottom of the page. It might be worth adding this step in for consistency. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/blocking-all-ads.md:43: 3. Tap the box labeled **Allow some nonintrusive ads**. On 2016/11/29 10:09:43, scott wrote: > This should read 'Tap the toggle labeled' Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/blocking-all-ads.md:47: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/11/29 10:09:43, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Maxthon, if the user > has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/blocking-all-ads.md:55: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. On 2016/11/29 10:09:43, scott wrote: > This should read 'Clock the Opera Menu icon' as the icon already has the wording > 'Menu' on it. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/configuring-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/configuring-automatic-updates.md:8: - **On Wi-Fi only** - Updates the app only when you are connected to Wi-Fi. On 2016/11/29 10:22:09, scott wrote: > Technically, this does not update the app but rather updates the filter lists. > The wording 'Updates the filter lists only when you are connected to Wi-Fi' > would work. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/configuring-automatic-updates.md:9: - **Always** - Updates the app at any time, using either Wi-Fi or mobile data. On 2016/11/29 10:22:09, scott wrote: > Technically, this does not update the app but rather updates the filter lists. > The wording 'Updates the filter lists at any time, using either Wi-Fi or mobile > data. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/downloading-and-installing-adblock-plus.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:12: 4. Click **Add**. On 2016/11/29 11:20:17, scott wrote: > Should read 'Click **Add extension** button. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:20: 3. Click **Add**. On 2016/11/29 11:20:18, scott wrote: > Should read 'Click **Add extension** button. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:30: 4. Click **Install Now**. On 2016/11/29 11:20:18, scott wrote: > The dialog box for me reads 'Install' not 'Install Now' (Firefox 47) Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:39: <br>A dialog box opens. On 2016/11/29 11:20:18, scott wrote: > It would be useful to state what this dialog box is actually telling the user. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:40: 4. Click **Yes**. On 2016/11/29 11:20:18, scott wrote: > There is an additional window that opens for me, if the user has IE open at the > time of installing the extension. So, step 3 and 4 need to be duplicated in step > 5 also. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:49: 10. Click **Enable**. On 2016/11/29 11:20:18, scott wrote: > Step 11. should include that the user needs to restart IE for the changes to > take effect. This is an important step. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:55: 2. Tap **Install**. On 2016/11/29 11:20:18, scott wrote: > There should be a step three that then tells the user to open the app. It may > seem obvious to us, but this will then also help with the next steps below in > enabling content blocking in Safari (the first run screens have a guide also). Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:81: 4. Click **Install**. On 2016/11/29 11:20:18, scott wrote: > For me, the dialogue box states 'Trust', not 'Install'. Once the 'Trust' button > is selected, the extension is installed. I'm on 10.10 and I see 'Install' or 'Don't install.' What version are you using? https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:86: 1. Open the **Finder**. On 2016/11/29 11:20:19, scott wrote: > I think that the first step should clearly state that the user follows these > guidelines AFTER clicking install for Safari on our main page. Updated. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/downloading-and-installing-adblock-plus.md:90: 5. Click **Install**. On 2016/11/29 11:20:19, scott wrote: > Again, I am presented with 'Trust' and not 'Install'. Same comment as above. I see 'Install'
uninstalling ABP https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/uninstalling-adblock-plus.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/uninstalling-adblock-plus.md:56: 1. Click the **Maxthon main menu icon** and select the *Extensions* tab. Maxton main menu icon, hover mouse over tools and select Extensions (i guess everybody is going with Google's menu format nowadays) https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/uninstalling-adblock-plus.md:87: Perhaps we should mention to first access the apps page, because the user might just delete the shortcut, which would only remove the icon but won't uninstall the application.
https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... File includes/removewhitelist-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-maxthon.md:3: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/12/01 18:40:24, Lisa wrote: > On 2016/11/24 11:40:32, scott wrote: > > For consistency here, we should always have the same way to access the > > extension. For example, with the situation given here in Maxthon, if the user > > has > > the extension disabled, then there would not be any ABP icon for them to > select. > > In addition to this, some browsers allow hiding of icons in the extensions > bar, > > so it's safer for the user to navigate to the extensions page from within the > > browser menu first. > > > > In Maxthon 5+ the steps are as follows: > > > > Select the Options Menu from the top right > > Select Tools > > Select Extensions > > Updated. Was using Maxthon 4.9 (according to the About tab, I was up-to-date). Yep. Maxthon 5 was released somewhat recently. I wonder if we need to describe both ways then, maybe Vicky has insights on the user distribution. https://codereview.adblockplus.org/29363713/diff/29363714/includes/removewhit... includes/removewhitelist-maxthon.md:3: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/12/01 18:40:25, Lisa wrote: > On 2016/11/25 07:21:36, Philip Hill wrote: > > On 2016/11/24 11:40:32, scott wrote: > > > For consistency here, we should always have the same way to access the > > > extension. For example, with the situation given here in Maxthon, if the > user > > > has > > > the extension disabled, then there would not be any ABP icon for them to > > select. > > > In addition to this, some browsers allow hiding of icons in the extensions > > bar, > > > so it's safer for the user to navigate to the extensions page from within > the > > > browser menu first. > > > > > > In Maxthon 5+ the steps are as follows: > > > > > > Select the Options Menu from the top right > > > Select Tools > > > Select Extensions > > > > Good points. What if we always go the short way via the ABP icon but add some > > "What if I don't see the ABP icon" section as include everywhere? > > There is a hiding/showing ABP icon topic. I'd prefer to leave it as the "long > way." Since this is a common issue on many platforms, I wonder if we should crosslink to the ABP icon hiding article with smtg like "What if I don't see the ABP icon" from every such text, otherwise we take the user to a detour in all cases or leave him searching for this issue himself. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/acceptable-ads-is-turned-off-but-i-still-see-ads.md:36: On 2016/12/01 18:40:25, Lisa wrote: > On 2016/11/23 14:20:41, scott wrote: > > This is currently different for the latest Maxthon 5 version. With Maxthon 5 > the > > user needs to select the settings menu, then select tools and then extensions. > > After this, just like Chrome, they then need to select the check box to enable > > the extension. Do we want to have two entries here, one for Maxthon 4.9 and > > below and one from 5.0 and up? > > Updated. The best practice in tech writing is to always use the latest version > of the browser, software, etc. If we add Maxthon 4.9 steps, then we would have > to consider adding other outdated versions to the other platforms. Which versions we should address should depend on the number/percentage of users using them.
https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/hiding-the-adblock-plus-icon.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/hiding-the-adblock-plus-icon.md:14: 1. Click **Chrome** and select **Preferences**. On 2016/11/29 12:45:49, scott wrote: > I am unable to see any 'Show icon' button anywhere in the extensions page. I > have navigated around for some time and the only way I see to enable the icon > after hiding it in Chrome is to Select the Settings tab in Chrome (the icon is > shown in the menu at the top) and to then right-click the ABP icon and select > 'Show in Toolbar'. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/hiding-the-adblock-plus-icon.md:42: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. On 2016/11/29 12:45:49, scott wrote: > This should read 'Click the Opera Menu icon' as Menu is already stated on the > icon. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/hiding-the-adblock-plus-icon.md:50: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. On 2016/11/29 12:45:49, scott wrote: > This should read 'Click the Opera Menu icon' as Menu is already stated on the > icon. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/is-adblock-plus-the-same-thing-as-ad-block.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/is-adblock-plus-the-same-thing-as-ad-block.md:3: In short - no. Both are ad blockers, but they are separate projects. Adblock Plus is a version of the original "ad-blocking" project; AdBlock originated in 2009 for Google Chrome. On 2016/12/01 02:34:46, robert wrote: > "The developer of AdBlock, Michael Gundlach, claims to have been inspired by the > Adblock Plus extension for Firefox"- Quote from Wikipedia, perhaps we should add > "Adblock originated in 2009 for Google Chrome and was inspired by Adblock Plus" Acknowledged. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/not-compatible-error-message.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/not-compatible-error-message.md:5: To ensure that your browser is up-to-date, visit <https://whatbrowser.org/>. On 2016/11/29 12:49:13, scott wrote: > We should probably refer to some form of documentation that displays on what > Android versions and iOS version /devices ABP iOS/Android and Sbrowser function > on. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/removing-afilter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-afilter-list.md:41: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. On 2016/11/30 09:10:34, scott wrote: > This should read 'Click the **Opera Menu icon**' as the icon already has 'Menu' > on it. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-afilter-list.md:61: 3. Select the **filter list** you would like to remove below *Other Languages*. On 2016/11/30 10:15:22, scott wrote: > We should add a step after to state that the user should press 'back'. The UI > does not refresh in the app, so to see that it is actually removed (apart from > it being un-selected), the user should select back and then can see the change > when entering the UI again. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-afilter-list.md:71: 5. Click **OK**. On 2016/11/30 09:10:34, scott wrote: > It is trivial, but in Yandex browser it is 'Yes' not, 'OK'. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/removing-awebsite-from-the-whitelist.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:33: <br>**Tip**: If you do not see the Adblock Plus icon, right-click the tab bar (the empty area near the tabs) and select **Status bar**. On 2016/11/30 10:15:22, scott wrote: > We should also try to put in suggestions here for if then the icon does not > appear in the status bar. As, in some cases the extension might be disabled. Acknowledged. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:41: 1. Open the Adblock Plus for iOS app. On 2016/11/30 10:15:22, scott wrote: > There is a step before step 2. that requires the user to select the 'tools' icon > at the bottom of the screen. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:47: 1. Click the **Adblock Plus icon** and select **Adblock Plus Options**. On 2016/11/30 10:15:22, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Maxthon, if the user > has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:51: 4. Click **Done**. On 2016/11/30 10:15:22, scott wrote: > Selecting Done already closes the window in Maxthon 5. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/removing-awebsite-from-the-whitelist.md:56: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. On 2016/11/30 10:15:22, scott wrote: > This should read 'Click the Opera Menu icon' as the word 'Menu' is already > located on the icon itself. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/unblocking-ablocked-item.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:38: 1. Click the **Adblock Plus icon** and select **Adblock Plus options**. On 2016/11/30 10:27:56, scott wrote: > For consistency here, we should always have the same way to access the > extension. For example, with the situation given here in Maxthon, if the user > has > the extension disabled, then there would not be any ABP icon for them to select. > In addition to this, some browsers allow hiding of icons in the extensions bar, > so it's safer for the user to navigate to the extensions page from within the > browser menu first. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:41: 3. Select the filter you want to remove and click **Remove selected**. On 2016/11/30 10:27:56, scott wrote: > In Maxthon 5, this works a little differently. The user selects the 'Add your > own filter' tab, but then instead of selecting 'Remove selected' they need to > right click the required filter and then select 'Delete'. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:45: 1. Click the **Opera icon**, hover over **Extensions** and select **Manage extensions**. On 2016/11/30 10:27:56, scott wrote: > This should read 'Click the **Opera Menu icon**' as the icon already has the > word 'menu' on it. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/uninstalling-adblock-plus.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/uninstalling-adblock-plus.md:56: 1. Click the **Maxthon main menu icon** and select the *Extensions* tab. On 2016/12/02 03:58:49, robert wrote: > Maxton main menu icon, hover mouse over tools and select Extensions (i guess > everybody is going with Google's menu format nowadays) Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/uninstalling-adblock-plus.md:87: On 2016/12/02 03:58:49, robert wrote: > Perhaps we should mention to first access the apps page, because the user might > just delete the shortcut, which would only remove the icon but won't uninstall > the application. Acknowledged. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/using-adblock-plus-to-disable-malware-domains.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/using-adblock-plus-to-disable-malware-domains.md:4: On 2016/12/01 02:28:44, robert wrote: > ### Adblock Bowser for Android > > 1. Open Adblock Browser app > 2. Tap in the top right corner on the three vertical dots for "more" > 3. Tap **Settings** > 4. Select **Ad blocking** Change ad blocking language, options, default settings > 5. Access **More blocking options** Disable tracking and malware sites or add > custom filter lists > 6. Tap **Disable malware domains** to block domains known to spread malicious > software, such as viruses, Trojan horses, worms and spyware. Acknowledged. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/using-adblock-plus-to-disable-social-media-buttons.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/using-adblock-plus-to-disable-social-media-buttons.md:4: On 2016/12/01 02:26:19, robert wrote: > ### Adblock Bowser for Android > > 1. Open Adblock Browser app > 2. Tap in the top right corner on the three vertical dots for "more" > 3. Tap **Settings** > 4. Select **Ad blocking** Change ad blocking language, options, default settings > 5. Access **More blocking options** Disable tracking and malware sites or add > custom filter lists > 6. Enable **Disable social media buttons** Acknowledged. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/using-adblock-plus-to-disable-tracking.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/using-adblock-plus-to-disable-tracking.md:4: On 2016/12/01 02:23:02, robert wrote: > ### Adblock Bowser for Android > > 1. Open Adblock Browser app > 2. Tap in the top right corner on the three vertical dots for "more" > 3. Tap **Settings** > 4. Select **Ad blocking** Change ad blocking language, options, default settings > 5. Access **More blocking options** Disable tracking and malware sites or add > custom filter lists > 6. Enable **Disable tracking** Acknowledged. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... File pages/adblock-plus/what-are-acceptable-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/what-are-acceptable-ads.md:9: - Are appropriate On 2016/12/01 02:09:53, robert wrote: > Are appropriate to the site that we are on - Should be clear that the ads should > emit similar content to the one found on the website. Done. https://codereview.adblockplus.org/29363713/diff/29363714/pages/adblock-plus/... pages/adblock-plus/what-are-acceptable-ads.md:11: The Acceptable Ads criteria was developed in 2011 as a joint effort between Adblock Plus and its community of users. When you install Adblock Plus and Adblock Browser, all annoying ads are blocked by default. On 2016/12/01 02:09:53, robert wrote: > Should mention "However ABP allows non-intrusive ads by default which can be > switched off in the Settings panel under the Filter list tab" Done.
Added @Lisa as a contributor.
- Uploaded Draft 2 content - Applied page name changes - There was one unintended side effect resulting in some h3s turning into strongs (my fault) - Please ignore in functional QA - @Lisa and/or I will fix if needed
https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-a... File includes/blockads-adblockplusforios.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-a... includes/blockads-adblockplusforios.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-a... includes/blockads-adblockplusforios.md:5: 3. Tap the box labeled **Allow some nonintrusive ads**. 'tap the toggle' would sound better here. As, if the user selects the box with the text nothing actually happens. A small thing, but worth changing I feel. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-c... File includes/blockads-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-c... includes/blockads-chrome.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-f... File includes/blockads-firefox.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-f... includes/blockads-firefox.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-i... File includes/blockads-internetexplorer.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-i... includes/blockads-internetexplorer.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-m... File includes/blockads-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-m... includes/blockads-maxthon.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-o... File includes/blockads-opera.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-o... includes/blockads-opera.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... File includes/blockads-safari.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... includes/blockads-safari.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... includes/blockads-safari.md:6: 3. Locate Adblock Plus and click **Options**. Much to my stupidity, I forgot that the user is unable to select the ABP options page from the Safari Extensions tab and the would indeed need to select the ABP icon in browser to see ABP's options page. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... File includes/blockads-samsung.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... includes/blockads-samsung.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-y... File includes/blockads-yandexbrowser.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-y... includes/blockads-yandexbrowser.md:2: Would it be more beneficial to also include our normal piece on acceptable ads here? Nothing massive, just something small. As, when I just read this it feels like it is more implying for people to simply de-select the acceptable ads option to block everything. I feel it would be better to have a small explanation before giving these steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... File includes/removewhitelist-safari.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... includes/removewhitelist-safari.md:3: 1. Click the **Adblock Plus icon** and select **Options**. Much to my stupidity, I didn't remember that you are actually unable to select the Options for Adblock Plus within Safari's extensions pane. It is correct that the user would need to select options from the icon within the browser. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/adding-a-filter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:19: 7. Verify that the filter list update status appears as **Just Now**. Looking at this a bit more, in some cases, the update will show as just now or as only the date and time. Maybe we could just cover ourselves here by saying 'appears as **Just Now** or will display the current date and time'. It does make this sentence a bit longer, but at least the user doesn't sit and wait for that particular **Just Now** message. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:34: 8. Verify that the filter list update status appears as **Just Now**. **Just Now** now shows **(Success)** as well as the current date and time of update. Maybe we could change it to 'appears as **(success)** and the current date and time'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:54: 6. Verify that the filter list update status appears as **Just Now**. Currently displays as 'Last update (Date) (Time)'. Maybe we can change this part of the sentence to 'appears as 'Last update (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:67: 7. Verify that the filter list update status appears as **Just Now**. Looking at this a bit more, in some cases, the update will show as just now or as only the date and time. Maybe we could just cover ourselves here by saying 'appears as **Just Now** or will display the current date and time'. It does make this sentence a bit longer, but at least the user doesn't sit and wait for that particular **Just Now** message. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:75: 3. Locate Adblock Plus and click **Options**. Much to my stupidity the user is not able to select the option from within the Extension tab of Safari. The user would need to select the icon from within Safari and then select the option. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:80: 7. Verify that the filter list update status appears as **Just Now**. Looking at this a bit more, in some cases, the update will show as just now or as only the date and time. Maybe we could just cover ourselves here by saying 'appears as **Just Now** or will display the current date and time'. It does make this sentence a bit longer, but at least the user doesn't sit and wait for that particular **Just Now** message. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:100: 7. Verify that the filter list update status appears as **Just Now**. Looking at this a bit more, in some cases, the update will show as just now or as only the date and time. Maybe we could just cover ourselves here by saying 'appears as **Just Now** or will display the current date and time'. It does make this sentence a bit longer, but at least the user doesn't sit and wait for that particular **Just Now** message. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-all-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-all-ads.md:72: 3. Locate Adblock Plus and click **Options**. Sadly this is wrong, the user is unable to access the options page from the Safari Extensions tab. The user would need to (as previously stated) access the options page from the icon within the browser itself. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-malware.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-malware.md:12: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-malware.md:21: 4. Click **Add subscription**. We need to also add the step to check that the list was successfully downloaded. Because we don't currently see the subscriptions list settings with this method, we would need to add in some more steps for them to open the filter list options menu and check themselves. An example would be: 4. Click **Add subscription**. 5. Now select the Safari Menu and then select Add-Ons 6. Select Extensions on the left side 7. Find Adblock Plus and select Options 8. Select Filter Preferences 9. Confirm that the Disable Malware filter list is added and updated recently '(Date) (Time) (success)'. <br> Close the window. Obviously, the variant for Linux/OSX needs to be input. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-malware.md:31: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-malware.md:41: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-tracking.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:12: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:21: 4. Click **Add subscription**. We need to also add the step to check that the list was successfully downloaded. Because we don't currently see the subscriptions list settings with this method, we would need to add in some more steps for them to open the filter list options menu and check themselves. An example would be: 4. Click **Add subscription**. 5. Now select the Safari Menu and then select Add-Ons 6. Select Extensions on the left side 7. Find Adblock Plus and select Options 8. Select Filter Preferences 9. Confirm that the Disable Malware filter list is added and updated recently '(Date) (Time) (success)'. <br> Close the window. Obviously, the variant for Linux/OSX needs to be input. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:31: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:41: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/broken-website.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:14: 4. Click the **Update Now** button. In this case, clicking the update button and simply closing does not actually check anything. The user should also be asked to make sure that the filter list has updated correctly before closing the tab as, if the download fails, then the issue could still be present. Maybe the new sentence structure could be '4. Click the 'Update now' button. 5. Check that the filter has been successfully updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) should be when you selected to update the lists. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:27: 6. Select **Update filters**. In this case, clicking the update button and simply closing does not actually check anything. The user should also be asked to make sure that the filter list has updated correctly before closing the window as, if the download fails, then the issue could still be present. Maybe the new sentence structure could be '6. Select 'Update filters' button. 5. Check that the filter has been successfully updated by checking the '(Date) (Time) (success) where (Date) and (Time) should be when you selected to update the list. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:33: NOTE: I can't access this on TestObject so I'm not sure if you are able to manually update filter lists. Hey, yes you can update the filter list. The steps would be as follows: 1. Launch the ABP for iOS app 2. Select the tools icon 3. Select the 'Update Filters' button 4. Wait 10-20 seconds for the lists to finish updating 5. Check that the 'Last Filter update' text below the 'Update Filters' button shows the current date and time 5. Close the app https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:41: 3. Click the **Update Now** button. In this case, clicking the update button and simply closing does not actually check anything. The user should also be asked to make sure that the filter list has updated correctly before closing the tab as, if the download fails, then the issue could still be present. Maybe the new sentence structure could be '4. Click the 'Update now' button. 5. Check that the filter has been successfully updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) should be when you selected to update the lists. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:51: 4. Click the **Update Now** button. In this case, clicking the update button and simply closing does not actually check anything. The user should also be asked to make sure that the filter list has updated correctly before closing the tab as, if the download fails, then the issue could still be present. Maybe the new sentence structure could be '4. Click the 'Update now' button. 5. Check that the filter has been successfully updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) should be when you selected to update the lists. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:59: 3. Locate Adblock Plus and click **Options**. The user is unable to select the ABP Options from the Safari Extensions pane. For the user to reach the ABP Options page, they would need to select the icon in the browser first, then select options. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:61: 4. Click the **Update Now** button. In this case, clicking the update button and simply closing does not actually check anything. The user should also be asked to make sure that the filter list has updated correctly before closing the tab as, if the download fails, then the issue could still be present. Maybe the new sentence structure could be '4. Click the 'Update now' button. 5. Check that the filter has been successfully updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) should be when you selected to update the lists. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:66: NOTE: I can't access this on TestObject so I'm not sure if you are able to manually update filter lists. Hey, the steps would be as follows: 1. Open ABP for Samsung Browser 2. Select 'Configure Filters' 3. De-Select the filter you wish to update 4. Press back 5. Select 'Configure Filters' 6. Select the filter you wish to update 7. Check that the Filter list states 'Updated: (Date), (Time)' where (Date) and (Time) are when you re-selected the list to update. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:75: 4. Click the **Update Now** button. In this case, clicking the update button and simply closing does not actually check anything. The user should also be asked to make sure that the filter list has updated correctly before closing the tab as, if the download fails, then the issue could still be present. Maybe the new sentence structure could be '4. Click the 'Update now' button. 5. Check that the filter has been successfully updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) should be when you selected to update the lists. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/disable-social-media-buttons.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:12: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:21: 4. Click **Add subscription**. We need to also add the step to check that the list was successfully downloaded. Because we don't currently see the subscriptions list settings with this method, we would need to add in some more steps for them to open the filter list options menu and check themselves. An example would be: 4. Click **Add subscription**. 5. Now select the Safari Menu and then select Add-Ons 6. Select Extensions on the left side 7. Find Adblock Plus and select Options 8. Select Filter Preferences 9. Confirm that the Disable Malware filter list is added and updated recently '(Date) (Time) (success)'. <br> Close the window. Obviously, the variant for Linux/OSX needs to be input. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:31: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:41: 4. Click **Add**. We need to also add the step to check that the list was successfully downloaded. So, a sentence like '5. If the list is successfully downloaded it should read 'Last updated (Date) (Time)'. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/download-and-install.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/download-and-install.md:54: 1. Go to the App Store and search for **Adblock Plus for iOS**. Can we not supply a store link here? or maybe even a QR code? https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/download-and-install.md:70: <br>The *Opera add-ons* page opens. There appears to be an error here between the Opera and Safari sections? https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/download-and-install.md:92: ### Adblock Plus for Samsung Browser There appears to be another error here showing no install method for Sbrowser? https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/i-still-see-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:34: 3. Locate Adblock Plus and verify that it is enabled. We should be clearer here and state that they should check that the selection box has a tick in it or such so that they understand that this means it is enabled. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:57: 2. Locate Adblock Plus and verify that it is enabled. We should be clearer here and state that they should check that the selection box has a tick in it or such so that they understand that this means it is enabled. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:73: 3. Locate Adblock Plus and verify that it is enabled. It would be good to note to the user that enabling and disabling extensions within the Extension pane is done by a tick box that needs to be ticked on the left-hand side. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:80: 3. Locate Adblock Plus and verify that it is turned on. 'verify that it is toggled on' sounds a bit better. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/remove-a-filter-list.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/remove-a-filter-list.md:61: 3. Select the **filter list** you would like to remove below *Other Languages*. The user actually needs to de-select the filter list they want to remove ABOVE 'Other Languages' https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/remove-a-filter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/remove-a-filter-list.md:56: 3. Locate Adblock Plus and click **Options**. To access options from within Safari for ABP, the user must use the ABP icon within the browser itself. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/unblocking-ablocked-item.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:63: 3. Locate Adblock Plus and click **Options**. The user can only access ABP Options from the ABP icon within the browser itself. Sadly, you are unable to access these options via the Extensions pane in Safari Preferences. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/uninstall.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/uninstall.md:34: 2. Click **Uninstall a Program**. For Windows 8 & 10 the user needs to select 'Programs' and then 'Programs and Features' https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/uninstall.md:42: 2. Click **Uninstall a Program**. For Windows 7 the user needs to select 'Programs' and then 'Programs and Features' https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/uninstall.md:50: 2. Tap the **X** in the upper-left corner. This would read better ' 2. Tap the **X** in the upper-left corner of the ABP App Icon. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/uninstall.md:88: 1. Long-tap the Adblock Plus icon. ABP for Samsung Browser doesn't function like iOS and in-fact works like a normal Android App. For this, the user needs to navigate to the control panel and manually uninstall it. The step by step for this would be: 1. Open Android Settings 2. Select Applications 3. Select Application Manager 4. Select Adblock Plus from Samsung Browser 5. Select 'Uninstall' 6. Select 'OK' Note that, in some other Android cases, the Application menu is different. Maybe we need to look at a way to cover this a bit more if the need arises. Otherwise, the above steps are still pretty clear for the other devices where this flow changes. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/what-are-acceptable-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/what-are-acceptable-ads.md:9: - Are appropriate to the site we are on the site 'we' are on or'you' are on?
https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/i-still-see-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:5: ### Turn off Acceptable Ads Shouldn't we better start with ABP enabled, then Filter lists, then whitelisted sites, then AA? Otherwise we make many people disable AA where this wasn't their issue at all. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:44: In Firefox, there is an additional toggle switch in ABP itself, which also needs to be checked ("Disable everywhere" from icon menu).
https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... File includes/removewhitelist-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... includes/removewhitelist-chrome.md:3: 1. Click the **Chrome menu icon** in the upper right corner of the toolbar and select **Settings**. Would it be benefitial to go the default easy route via the icon menu? Should work for most users and for those who it doesn't, we could have some "What if I don't see that icon" page. This remark is true for other browsers as well.
Hi All, I just had a read through of the content again, from a higher level user perspective and made some comments. Let me know if anything is unclear. Thanks! Jeen https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-all-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-all-ads.md:3: If you choose to block all ads, Adblock Plus will block annoying ads *and* ads that are considered nonintrusive. To learn more about the Acceptable Ads initiative, please visit the [Acceptable Ads webpage](https://acceptableads.com/en/). This could be a nitpick, but perhaps a line introducing Acceptable Ads / linking Acceptable Ads with nonintrusive ads is missing? https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-tracking.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:3: Many companies collect data about your browsing habits across multiple websites - your browsing history is even examined and collected. Use Adblock Plus to prohibit your online behavior from being tracked. For more advanced users, they may want to know how disabling tracking will affect their cookies and if this will log them out of their accounts/ stop sites from remembering their passwords etc. (This was brought up in a latest round of user-testing for the Options page) FYI: Turning on this function will not clear cookies that are already on the user's computer, and will only block cookies from ads. Cookies from first-party domains should not be blocked, therefore saved passwords etc. are not affected. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/configure-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:3: Currently, it is possible to configure automatic updates for Adblock Plus for Samsung Browser only. Update: 'Adblock Plus for Samsung Browser' to 'Adblock Plus for Samsung Internet' https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:5: 1. Open the Adblock Plus for Samsung Browser app. Update: 'Samsung Browser' to 'Samsung Internet' https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/disable-social-media-buttons.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:3: Use Adblock Plus to disable social media buttons that track your online browsing activities. Even if you never click one of these buttons, a profile based on your browsing habits can be created and sent to various social network servers. Minor note: perhaps re-ordering the sentences. With the title already reading: Disable social media buttons It might read better to start by describing what social media buttons do as most users are not aware of this? And describe visually what happens on page when this feature is enabled. I.e. Social media buttons track your online browsing activities. Even if you never click one of these buttons, a profile based on your browsing habits can be created and sent to various social network servers. Use Adblock Plus to stop social media sites from tracking your online activity. This means all social media buttons will be hidden. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/download-and-install.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/download-and-install.md:97: ### Adblock Plus for Samsung Browser Name change: Samsung Internet https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/unblocking-ablocked-item.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:3: Follow the steps below to unblock a blocked item. This provides the same instructions as the 'remove a filter list' article. Would it be better to perhaps link to the 'Remove a filter list' article instead, so we don't have to update the instructions twice if ever this changes? And add a sentence briefly introducing filter lists and describe how filter lists may cause too much content to be blocked.
https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-a... File includes/blockads-adblockplusforios.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-a... includes/blockads-adblockplusforios.md:2: On 2017/01/05 08:08:35, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-a... includes/blockads-adblockplusforios.md:5: 3. Tap the box labeled **Allow some nonintrusive ads**. On 2017/01/05 08:08:35, scott wrote: > 'tap the toggle' would sound better here. As, if the user selects the box with > the text nothing actually happens. A small thing, but worth changing I feel. Done. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-c... File includes/blockads-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-c... includes/blockads-chrome.md:2: On 2017/01/05 08:08:37, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-f... File includes/blockads-firefox.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-f... includes/blockads-firefox.md:2: On 2017/01/05 08:08:38, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-i... File includes/blockads-internetexplorer.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-i... includes/blockads-internetexplorer.md:2: On 2017/01/05 08:08:38, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-m... File includes/blockads-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-m... includes/blockads-maxthon.md:2: On 2017/01/05 08:08:38, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-o... File includes/blockads-opera.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-o... includes/blockads-opera.md:2: On 2017/01/05 08:08:39, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... File includes/blockads-safari.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... includes/blockads-safari.md:2: On 2017/01/05 08:08:40, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... includes/blockads-safari.md:6: 3. Locate Adblock Plus and click **Options**. On 2017/01/05 08:08:39, scott wrote: > Much to my stupidity, I forgot that the user is unable to select the ABP options > page from the Safari Extensions tab and the would indeed need to select the ABP > icon in browser to see ABP's options page. Done. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... File includes/blockads-samsung.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-s... includes/blockads-samsung.md:2: On 2017/01/05 08:08:40, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-y... File includes/blockads-yandexbrowser.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/blockads-y... includes/blockads-yandexbrowser.md:2: On 2017/01/05 08:08:41, scott wrote: > Would it be more beneficial to also include our normal piece on acceptable ads > here? Nothing massive, just something small. As, when I just read this it feels > like it is more implying for people to simply de-select the acceptable ads > option to block everything. I feel it would be better to have a small > explanation before giving these steps. These 'includes' are just snippets of text that can be used in multiple articles (so I don't have to copy-paste the same chunk of text 10 times). I added this sentence to the 'I still see ads' file: Please note that by turning off Acceptable Ads, website owners and content creators that abide by the Acceptable Ads criteria will lose ad revenue. https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... File includes/removewhitelist-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... includes/removewhitelist-chrome.md:3: 1. Click the **Chrome menu icon** in the upper right corner of the toolbar and select **Settings**. On 2017/01/05 13:03:57, Philip Hill wrote: > Would it be benefitial to go the default easy route via the icon menu? Should > work for most users and for those who it doesn't, we could have some "What if I > don't see that icon" page. This remark is true for other browsers as well. I see your point, but a major rule in technical writing is to always take the 'intended way' and not the shortcut. If we use the shortcut steps, we would have to include a bit about enabling the ABP icon in every set of steps. https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... File includes/removewhitelist-safari.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... includes/removewhitelist-safari.md:3: 1. Click the **Adblock Plus icon** and select **Options**. On 2017/01/05 08:08:41, scott wrote: > Much to my stupidity, I didn't remember that you are actually unable to select > the Options for Adblock Plus within Safari's extensions pane. It is correct that > the user would need to select options from the icon within the browser. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/adding-a-filter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:19: 7. Verify that the filter list update status appears as **Just Now**. On 2017/01/05 08:08:44, scott wrote: > Looking at this a bit more, in some cases, the update will show as just now or > as only the date and time. Maybe we could just cover ourselves here by saying > 'appears as **Just Now** or will display the current date and time'. It does > make this sentence a bit longer, but at least the user doesn't sit and wait for > that particular **Just Now** message. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:34: 8. Verify that the filter list update status appears as **Just Now**. On 2017/01/05 08:08:42, scott wrote: > **Just Now** now shows **(Success)** as well as the current date and time of > update. Maybe we could change it to 'appears as **(success)** and the current > date and time'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:54: 6. Verify that the filter list update status appears as **Just Now**. On 2017/01/05 08:08:43, scott wrote: > Currently displays as 'Last update (Date) (Time)'. Maybe we can change this part > of the sentence to 'appears as 'Last update (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:67: 7. Verify that the filter list update status appears as **Just Now**. On 2017/01/05 08:08:44, scott wrote: > Looking at this a bit more, in some cases, the update will show as just now or > as only the date and time. Maybe we could just cover ourselves here by saying > 'appears as **Just Now** or will display the current date and time'. It does > make this sentence a bit longer, but at least the user doesn't sit and wait for > that particular **Just Now** message. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:75: 3. Locate Adblock Plus and click **Options**. On 2017/01/05 08:08:42, scott wrote: > Much to my stupidity the user is not able to select the option from within the > Extension tab of Safari. The user would need to select the icon from within > Safari and then select the option. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:80: 7. Verify that the filter list update status appears as **Just Now**. On 2017/01/05 08:08:43, scott wrote: > Looking at this a bit more, in some cases, the update will show as just now or > as only the date and time. Maybe we could just cover ourselves here by saying > 'appears as **Just Now** or will display the current date and time'. It does > make this sentence a bit longer, but at least the user doesn't sit and wait for > that particular **Just Now** message. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/adding-a-filter-list.md:100: 7. Verify that the filter list update status appears as **Just Now**. On 2017/01/05 08:08:42, scott wrote: > Looking at this a bit more, in some cases, the update will show as just now or > as only the date and time. Maybe we could just cover ourselves here by saying > 'appears as **Just Now** or will display the current date and time'. It does > make this sentence a bit longer, but at least the user doesn't sit and wait for > that particular **Just Now** message. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-all-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-all-ads.md:3: If you choose to block all ads, Adblock Plus will block annoying ads *and* ads that are considered nonintrusive. To learn more about the Acceptable Ads initiative, please visit the [Acceptable Ads webpage](https://acceptableads.com/en/). On 2017/01/06 14:39:24, jeen wrote: > This could be a nitpick, but perhaps a line introducing Acceptable Ads / linking > Acceptable Ads with nonintrusive ads is missing? Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-all-ads.md:72: 3. Locate Adblock Plus and click **Options**. On 2017/01/05 08:08:44, scott wrote: > Sadly this is wrong, the user is unable to access the options page from the > Safari Extensions tab. The user would need to (as previously stated) access the > options page from the icon within the browser itself. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-malware.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-malware.md:12: 4. Click **Add**. On 2017/01/05 08:08:46, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-malware.md:21: 4. Click **Add subscription**. On 2017/01/05 08:08:45, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > Because we don't currently see the subscriptions list settings with this method, > we would need to add in some more steps for them to open the filter list options > menu and check themselves. An example would be: > > 4. Click **Add subscription**. > 5. Now select the Safari Menu and then select Add-Ons > 6. Select Extensions on the left side > 7. Find Adblock Plus and select Options > 8. Select Filter Preferences > 9. Confirm that the Disable Malware filter list is added and updated recently > '(Date) (Time) (success)'. > <br> Close the window. > > Obviously, the variant for Linux/OSX needs to be input. 1. Go to the [Adblock Plus Features](https://adblockplus.org/en/features) page. 2. Click the **Disable Malware Domains** link at the top of the page. 3. Click the **open this dialogue** link. <br>**Note**: Do not right-click (Windows)/control-click (Mac) the above link to open in a new tab or window. 4. Click **Add subscription**. 5. **Mac OS X and Linux**: From the Mac menu bar, click **Tools** and select **Add-ons**. <br>**Windows**: Click the **Firefox menu icon** in the upper right corner of the toolbar and select **Add-ons**. <br>The *Add-ons Manager* tab opens. 6. Select **Extensions** from the left menu. 7. Locate Adblock Plus and click **Preferences** (Mac)/**Options** (Windows). 8. Click **Filter Preferences**. <br>The download is successful if **Last updated (Date) (Time)** appears next to the list. <br> Close the window. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-malware.md:31: 4. Click **Add**. On 2017/01/05 08:08:45, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-malware.md:41: 4. Click **Add**. On 2017/01/05 08:08:46, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-tracking.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:12: 4. Click **Add**. On 2017/01/05 08:08:47, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:21: 4. Click **Add subscription**. On 2017/01/05 08:08:46, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > Because we don't currently see the subscriptions list settings with this method, > we would need to add in some more steps for them to open the filter list options > menu and check themselves. An example would be: > > 4. Click **Add subscription**. > 5. Now select the Safari Menu and then select Add-Ons > 6. Select Extensions on the left side > 7. Find Adblock Plus and select Options > 8. Select Filter Preferences > 9. Confirm that the Disable Malware filter list is added and updated recently > '(Date) (Time) (success)'. > <br> Close the window. > > Obviously, the variant for Linux/OSX needs to be input. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:31: 4. Click **Add**. On 2017/01/05 08:08:47, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:41: 4. Click **Add**. On 2017/01/05 08:08:48, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/block-tracking.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/block-tracking.md:3: Many companies collect data about your browsing habits across multiple websites - your browsing history is even examined and collected. Use Adblock Plus to prohibit your online behavior from being tracked. On 2017/01/06 14:39:24, jeen wrote: > For more advanced users, they may want to know how disabling tracking will > affect their cookies and if this will log them out of their accounts/ stop sites > from remembering their passwords etc. (This was brought up in a latest round of > user-testing for the Options page) > FYI: Turning on this function will not clear cookies that are already on the > user's computer, and will only block cookies from ads. Cookies from first-party > domains should not be blocked, therefore saved passwords etc. are not affected. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/broken-website.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:14: 4. Click the **Update Now** button. On 2017/01/05 08:08:50, scott wrote: > In this case, clicking the update button and simply closing does not actually > check anything. The user should also be asked to make sure that the filter list > has updated correctly before closing the tab as, if the download fails, then the > issue could still be present. Maybe the new sentence structure could be '4. > Click the 'Update now' button. 5. Check that the filter has been successfully > updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) > should be when you selected to update the lists. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:27: 6. Select **Update filters**. On 2017/01/05 08:08:49, scott wrote: > In this case, clicking the update button and simply closing does not actually > check anything. The user should also be asked to make sure that the filter list > has updated correctly before closing the window as, if the download fails, then > the issue could still be present. Maybe the new sentence structure could be '6. > Select 'Update filters' button. 5. Check that the filter has been successfully > updated by checking the '(Date) (Time) (success) where (Date) and (Time) should > be when you selected to update the list. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:33: NOTE: I can't access this on TestObject so I'm not sure if you are able to manually update filter lists. On 2017/01/05 08:08:50, scott wrote: > Hey, yes you can update the filter list. The steps would be as follows: > > 1. Launch the ABP for iOS app > 2. Select the tools icon > 3. Select the 'Update Filters' button > 4. Wait 10-20 seconds for the lists to finish updating > 5. Check that the 'Last Filter update' text below the 'Update Filters' button > shows the current date and time > 5. Close the app Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:41: 3. Click the **Update Now** button. On 2017/01/05 08:08:48, scott wrote: > In this case, clicking the update button and simply closing does not actually > check anything. The user should also be asked to make sure that the filter list > has updated correctly before closing the tab as, if the download fails, then the > issue could still be present. Maybe the new sentence structure could be '4. > Click the 'Update now' button. 5. Check that the filter has been successfully > updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) > should be when you selected to update the lists. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:51: 4. Click the **Update Now** button. On 2017/01/05 08:08:51, scott wrote: > In this case, clicking the update button and simply closing does not actually > check anything. The user should also be asked to make sure that the filter list > has updated correctly before closing the tab as, if the download fails, then the > issue could still be present. Maybe the new sentence structure could be '4. > Click the 'Update now' button. 5. Check that the filter has been successfully > updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) > should be when you selected to update the lists. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:61: 4. Click the **Update Now** button. On 2017/01/05 08:08:50, scott wrote: > In this case, clicking the update button and simply closing does not actually > check anything. The user should also be asked to make sure that the filter list > has updated correctly before closing the tab as, if the download fails, then the > issue could still be present. Maybe the new sentence structure could be '4. > Click the 'Update now' button. 5. Check that the filter has been successfully > updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) > should be when you selected to update the lists. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:66: NOTE: I can't access this on TestObject so I'm not sure if you are able to manually update filter lists. On 2017/01/05 08:08:48, scott wrote: > Hey, the steps would be as follows: > > 1. Open ABP for Samsung Browser > 2. Select 'Configure Filters' > 3. De-Select the filter you wish to update > 4. Press back > 5. Select 'Configure Filters' > 6. Select the filter you wish to update > 7. Check that the Filter list states 'Updated: (Date), (Time)' where (Date) and > (Time) are when you re-selected the list to update. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/broken-website.md:75: 4. Click the **Update Now** button. On 2017/01/05 08:08:49, scott wrote: > In this case, clicking the update button and simply closing does not actually > check anything. The user should also be asked to make sure that the filter list > has updated correctly before closing the tab as, if the download fails, then the > issue could still be present. Maybe the new sentence structure could be '4. > Click the 'Update now' button. 5. Check that the filter has been successfully > updated by checking the 'Last updated (Date) (Time) where (Date) and (Time) > should be when you selected to update the lists. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/configure-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:3: Currently, it is possible to configure automatic updates for Adblock Plus for Samsung Browser only. On 2017/01/06 14:39:25, jeen wrote: > Update: 'Adblock Plus for Samsung Browser' to 'Adblock Plus for Samsung > Internet' Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:5: 1. Open the Adblock Plus for Samsung Browser app. On 2017/01/06 14:39:25, jeen wrote: > Update: 'Samsung Browser' to 'Samsung Internet' Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/disable-social-media-buttons.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:12: 4. Click **Add**. On 2017/01/05 08:08:52, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:21: 4. Click **Add subscription**. On 2017/01/05 08:08:52, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > Because we don't currently see the subscriptions list settings with this method, > we would need to add in some more steps for them to open the filter list options > menu and check themselves. An example would be: > > 4. Click **Add subscription**. > 5. Now select the Safari Menu and then select Add-Ons > 6. Select Extensions on the left side > 7. Find Adblock Plus and select Options > 8. Select Filter Preferences > 9. Confirm that the Disable Malware filter list is added and updated recently > '(Date) (Time) (success)'. > <br> Close the window. > > Obviously, the variant for Linux/OSX needs to be input. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:31: 4. Click **Add**. On 2017/01/05 08:08:53, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:41: 4. Click **Add**. On 2017/01/05 08:08:53, scott wrote: > We need to also add the step to check that the list was successfully downloaded. > So, a sentence like '5. If the list is successfully downloaded it should read > 'Last updated (Date) (Time)'. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/disable-social-media-buttons.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:3: Use Adblock Plus to disable social media buttons that track your online browsing activities. Even if you never click one of these buttons, a profile based on your browsing habits can be created and sent to various social network servers. On 2017/01/06 14:39:25, jeen wrote: > Minor note: perhaps re-ordering the sentences. > > With the title already reading: Disable social media buttons > It might read better to start by describing what social media buttons do as most > users are not aware of this? And describe visually what happens on page when > this feature is enabled. > > I.e. Social media buttons track your online browsing activities. Even if you > never click one of these buttons, a profile based on your browsing habits can be > created and sent to various social network servers. Use Adblock Plus to stop > social media sites from tracking your online activity. This means all social > media buttons will be hidden. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/download-and-install.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/download-and-install.md:54: 1. Go to the App Store and search for **Adblock Plus for iOS**. On 2017/01/05 08:08:57, scott wrote: > Can we not supply a store link here? or maybe even a QR code? Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/download-and-install.md:70: <br>The *Opera add-ons* page opens. On 2017/01/05 08:08:57, scott wrote: > There appears to be an error here between the Opera and Safari sections I'm not seeing an error. What's the error that you see? https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/download-and-install.md:92: ### Adblock Plus for Samsung Browser On 2017/01/05 08:08:57, scott wrote: > There appears to be another error here showing no install method for Sbrowser? Not sure what isn't showing. I can see all of the steps? https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/download-and-install.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/download-and-install.md:97: ### Adblock Plus for Samsung Browser On 2017/01/06 14:39:26, jeen wrote: > Name change: Samsung Internet Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/i-still-see-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:5: ### Turn off Acceptable Ads On 2017/01/05 12:57:53, Philip Hill wrote: > Shouldn't we better start with ABP enabled, then Filter lists, then whitelisted > sites, then AA? Otherwise we make many people disable AA where this wasn't their > issue at all. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:34: 3. Locate Adblock Plus and verify that it is enabled. On 2017/01/05 08:08:59, scott wrote: > We should be clearer here and state that they should check that the selection > box has a tick in it or such so that they understand that this means it is > enabled. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:44: On 2017/01/05 12:57:53, Philip Hill wrote: > In Firefox, there is an additional toggle switch in ABP itself, which also needs > to be checked ("Disable everywhere" from icon menu). Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:57: 2. Locate Adblock Plus and verify that it is enabled. On 2017/01/05 08:08:59, scott wrote: > We should be clearer here and state that they should check that the selection > box has a tick in it or such so that they understand that this means it is > enabled. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:73: 3. Locate Adblock Plus and verify that it is enabled. On 2017/01/05 08:08:58, scott wrote: > It would be good to note to the user that enabling and disabling extensions > within the Extension pane is done by a tick box that needs to be ticked on the > left-hand side. Acknowledged. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/i-still-see-ads.md:80: 3. Locate Adblock Plus and verify that it is turned on. On 2017/01/05 08:08:58, scott wrote: > 'verify that it is toggled on' sounds a bit better. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/remove-a-filter-list.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/remove-a-filter-list.md:61: 3. Select the **filter list** you would like to remove below *Other Languages*. On 2017/01/05 08:08:59, scott wrote: > The user actually needs to de-select the filter list they want to remove ABOVE > 'Other Languages' Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/remove-a-filter-list.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/remove-a-filter-list.md:56: 3. Locate Adblock Plus and click **Options**. On 2017/01/05 08:09:00, scott wrote: > To access options from within Safari for ABP, the user must use the ABP icon > within the browser itself. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/unblocking-ablocked-item.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:3: Follow the steps below to unblock a blocked item. On 2017/01/06 14:39:26, jeen wrote: > This provides the same instructions as the 'remove a filter list' article. Would > it be better to perhaps link to the 'Remove a filter list' article instead, so > we don't have to update the instructions twice if ever this changes? And add a > sentence briefly introducing filter lists and describe how filter lists may > cause too much content to be blocked. This refers to custom filters whereas the 'Remove a filter list' article refers to pre-made filters. Per our last help center meeting discussion, I've added a bit at the beginning about custome filters. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/unblocking-ablocked-item.md:63: 3. Locate Adblock Plus and click **Options**. On 2017/01/05 08:09:00, scott wrote: > The user can only access ABP Options from the ABP icon within the browser > itself. Sadly, you are unable to access these options via the Extensions pane in > Safari Preferences. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/uninstall.md (left): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/uninstall.md:34: 2. Click **Uninstall a Program**. On 2017/01/05 08:09:00, scott wrote: > For Windows 8 & 10 the user needs to select 'Programs' and then 'Programs and > Features' I have Win 10 and when I open the Control Panel, I see Programs > Uninstall a program. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/uninstall.md:42: 2. Click **Uninstall a Program**. On 2017/01/05 08:09:01, scott wrote: > For Windows 7 the user needs to select 'Programs' and then 'Programs and > Features' Same comment as above. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/uninstall.md:50: 2. Tap the **X** in the upper-left corner. On 2017/01/05 08:09:01, scott wrote: > This would read better ' 2. Tap the **X** in the upper-left corner of the ABP > App Icon. Done. https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/uninstall.md:88: 1. Long-tap the Adblock Plus icon. On 2017/01/05 08:09:02, scott wrote: > ABP for Samsung Browser doesn't function like iOS and in-fact works like a > normal Android App. For this, the user needs to navigate to the control panel > and manually uninstall it. The step by step for this would be: > > 1. Open Android Settings > 2. Select Applications > 3. Select Application Manager > 4. Select Adblock Plus from Samsung Browser > 5. Select 'Uninstall' > 6. Select 'OK' > > Note that, in some other Android cases, the Application menu is different. Maybe > we need to look at a way to cover this a bit more if the need arises. Otherwise, > the above steps are still pretty clear for the other devices where this flow > changes. I thought long-tapping and dragging and dropping to the uninstall button was standard in recent versions of Android? https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... File pages/adblock-plus/what-are-acceptable-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/pages/adblock-plus/... pages/adblock-plus/what-are-acceptable-ads.md:9: - Are appropriate to the site we are on On 2017/01/05 08:09:02, scott wrote: > the site 'we' are on or'you' are on? Done.
Uploaded Draft 3.
https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... File includes/removewhitelist-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29367438/includes/removewhit... includes/removewhitelist-chrome.md:3: 1. Click the **Chrome menu icon** in the upper right corner of the toolbar and select **Settings**. On 2017/01/12 15:09:15, Lisa wrote: > On 2017/01/05 13:03:57, Philip Hill wrote: > > Would it be benefitial to go the default easy route via the icon menu? Should > > work for most users and for those who it doesn't, we could have some "What if > I > > don't see that icon" page. This remark is true for other browsers as well. > > I see your point, but a major rule in technical writing is to always take the > 'intended way' and not the shortcut. If we use the shortcut steps, we would have > to include a bit about enabling the ABP icon in every set of steps. How is the long way more intended as the short one? By default, the icon _is_ displayed in Chrome. This remark is true for other browsers as well. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/compatibility-issues.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/compatibility-issues.md:2: The previous here was more explicit, while this version here leaves plenty of room for interpretation of what "Compatibility issues" might be, something, that user's usually aren't very strong in. We should also link to what the supported versions are: https://adblockplus.org/requirements https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/compatibility-issues.md:5: To ensure that your platform is up-to-date, visit: I opened the whatbrowser link in Chrome 48 on one of our test clients at Win 7 64 bit with English language preference but got the site in italian, telling me that my version would be the latest available. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/configure-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:3: Currently, it is possible to configure automatic updates for Adblock Plus for Samsung Internet only. Almost all our products do receive App updates, either via built in updaters or app stores. If you refer to filter list updates, then also most of our platforms do receive those. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/what-are-acceptable-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/what-are-acceptable-ads.md:3: Acceptable Ads are nonitrusive ads that: I think we should rather refrain from duplicating the description of what exactly Acceptable Ads are to here. This seems a legally very critical topic, so it might be better to have only one public description in once place (eg acceptableads.com or whatever officially approves page on adblockplus.org). At the very least, we need to triple-check this description with management and legal.
https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-a... File includes/blockads-adblockplusforios.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-a... includes/blockads-adblockplusforios.md:8: <br>All ads are now blocked. I guess that I might need to better see how this is laid out on the help page, but if this is simply 'block ads' solution as it states in the title, then I think it could be a bit misleading. We need to make sure that users don't think that the 'only' reason they might be seeing ads is because AA is enabled. This should be one of the options to 'check' if this is why they are seeing ads - not that this is why they are and this is the answer. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-c... File includes/blockads-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-c... includes/blockads-chrome.md:10: <br>All ads are now blocked. Again as previously stated in the ABP for iOS section. I wonder if we should check that we are not simply directing the user to disable AA as a remedy to them seeing ads. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-f... File includes/blockads-firefox.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-f... includes/blockads-firefox.md:12: <br>All ads are now blocked. Again as previously stated in the ABP for iOS section. I wonder if we should check that we are not simply directing the user to disable AA as a remedy to them seeing ads. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-i... File includes/blockads-internetexplorer.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-i... includes/blockads-internetexplorer.md:8: <br>All ads are now blocked. Again as previously stated in the ABP for iOS section. I wonder if we should check that we are not simply directing the user to disable AA as a remedy to them seeing ads. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-m... File includes/blockads-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-m... includes/blockads-maxthon.md:17: <br>All ads are now blocked. Again as previously stated in the ABP for iOS section. I wonder if we should check that we are not simply directing the user to disable AA as a remedy to them seeing ads. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-o... File includes/blockads-opera.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-o... includes/blockads-opera.md:10: <br>All ads are now blocked. Again as previously stated in the ABP for iOS section. I wonder if we should check that we are not simply directing the user to disable AA as a remedy to them seeing ads. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-s... File includes/blockads-safari.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-s... includes/blockads-safari.md:7: <br>All ads are now blocked. Again as previously stated in the ABP for iOS section. I wonder if we should check that we are not simply directing the user to disable AA as a remedy to them seeing ads. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-s... File includes/blockads-samsung.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-s... includes/blockads-samsung.md:6: <br>All ads are now blocked. Again as previously stated in the ABP for iOS section. I wonder if we should check that we are not simply directing the user to disable AA as a remedy to them seeing ads. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-y... File includes/blockads-yandexbrowser.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-y... includes/blockads-yandexbrowser.md:10: <br>All ads are now blocked. Again as previously stated in the ABP for iOS section. I wonder if we should check that we are not simply directing the user to disable AA as a remedy to them seeing ads. https://codereview.adblockplus.org/29363713/diff/29371637/includes/removewhit... File includes/removewhitelist-adblockplusforios.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/removewhit... includes/removewhitelist-adblockplusforios.md:4: 2. Tap **Whitelisted Websites**. Step 2. here should be 'select the tools symbol'. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/adblock-plus-breaks-the-websites-i-visit.md (left): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/adblock-plus-breaks-the-websites-i-visit.md:3: In rare instances, Adblock Plus may prevent some websites from functioning correctly. This is typically not a bug but rather a problem with the filters (or filter subscription). The filter lists may be directing Adblock Plus to block something that should be allowed. To verify that the issue lies within the filter list, temporarily disable Adblock Plus. If the issue is fixed after disabling Adblock Plus, you can be certain that the problem lies within the filters. 'If the issue is fixed after disabling Adblock Plus, you can be certain that the problem lies within the filters' - I don't think this is something we should have in this sentence. Someone who is navigated to this help page and tries this only (without first checking if it is Adblock plus causing the issue) then stating that disabling ABP means that it is a filter list issue is a bit of a porky pie. In addition to this, maybe we need to be more specific that the user needs to pause/whitelist the website to check if it is a filter list issue and not disable/remove it from the Extensions page? I just feel some clarity is needed here. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/configure-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:3: Currently, it is possible to configure automatic updates for Adblock Plus for Samsung Internet only. On 2017/01/13 09:47:12, Philip Hill wrote: > Almost all our products do receive App updates, either via built-in updaters or > app stores. If you refer to filter list updates, then also most of our platforms > do receive those. I guess the definition here is that only ABP for Samsung Browser has the option to either update via Wifi, or over mobile data. Obviously, nearly all of our products automatically fetch for filter updates every X days and Extension updates are generally pushed or the user is at least notified. The question remaining, do we look at also writing a section how to search for APP/Extension updates also? (Play Store for Android, iTunes App Store for iOS, CWS for Chrome etc.)
@Scott Can you reply to my question for the article, "Adblock Plus breaks the websites I visit"? https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-a... File includes/blockads-adblockplusforios.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-a... includes/blockads-adblockplusforios.md:8: <br>All ads are now blocked. On 2017/02/06 13:38:44, scott wrote: > I guess that I might need to better see how this is laid out on the help page, > but if this is simply 'block ads' solution as it states in the title, then I > think it could be a bit misleading. We need to make sure that users don't think > that the 'only' reason they might be seeing ads is because AA is enabled. This > should be one of the options to 'check' if this is why they are seeing ads - not > that this is why they are and this is the answer. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-c... File includes/blockads-chrome.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-c... includes/blockads-chrome.md:10: <br>All ads are now blocked. On 2017/02/06 13:38:44, scott wrote: > Again as previously stated in the ABP for iOS section. I wonder if we should > check that we are not simply directing the user to disable AA as a remedy to > them seeing ads. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-f... File includes/blockads-firefox.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-f... includes/blockads-firefox.md:12: <br>All ads are now blocked. On 2017/02/06 13:38:45, scott wrote: > Again as previously stated in the ABP for iOS section. I wonder if we should > check that we are not simply directing the user to disable AA as a remedy to > them seeing ads. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-i... File includes/blockads-internetexplorer.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-i... includes/blockads-internetexplorer.md:8: <br>All ads are now blocked. On 2017/02/06 13:38:45, scott wrote: > Again as previously stated in the ABP for iOS section. I wonder if we should > check that we are not simply directing the user to disable AA as a remedy to > them seeing ads. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-m... File includes/blockads-maxthon.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-m... includes/blockads-maxthon.md:17: <br>All ads are now blocked. On 2017/02/06 13:38:46, scott wrote: > Again as previously stated in the ABP for iOS section. I wonder if we should > check that we are not simply directing the user to disable AA as a remedy to > them seeing ads. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-o... File includes/blockads-opera.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-o... includes/blockads-opera.md:10: <br>All ads are now blocked. On 2017/02/06 13:38:46, scott wrote: > Again as previously stated in the ABP for iOS section. I wonder if we should > check that we are not simply directing the user to disable AA as a remedy to > them seeing ads. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-s... File includes/blockads-safari.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-s... includes/blockads-safari.md:7: <br>All ads are now blocked. On 2017/02/06 13:38:47, scott wrote: > Again as previously stated in the ABP for iOS section. I wonder if we should > check that we are not simply directing the user to disable AA as a remedy to > them seeing ads. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-s... File includes/blockads-samsung.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-s... includes/blockads-samsung.md:6: <br>All ads are now blocked. On 2017/02/06 13:38:47, scott wrote: > Again as previously stated in the ABP for iOS section. I wonder if we should > check that we are not simply directing the user to disable AA as a remedy to > them seeing ads. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-y... File includes/blockads-yandexbrowser.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/blockads-y... includes/blockads-yandexbrowser.md:10: <br>All ads are now blocked. On 2017/02/06 13:38:48, scott wrote: > Again as previously stated in the ABP for iOS section. I wonder if we should > check that we are not simply directing the user to disable AA as a remedy to > them seeing ads. I can see how this sentence may be confusing to users since this text is used in multiple articles. I'll remove it. https://codereview.adblockplus.org/29363713/diff/29371637/includes/removewhit... File includes/removewhitelist-adblockplusforios.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/includes/removewhit... includes/removewhitelist-adblockplusforios.md:4: 2. Tap **Whitelisted Websites**. On 2017/02/06 13:38:48, scott wrote: > Step 2. here should be 'select the tools symbol'. Done. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/adblock-plus-breaks-the-websites-i-visit.md (left): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/adblock-plus-breaks-the-websites-i-visit.md:3: In rare instances, Adblock Plus may prevent some websites from functioning correctly. This is typically not a bug but rather a problem with the filters (or filter subscription). The filter lists may be directing Adblock Plus to block something that should be allowed. To verify that the issue lies within the filter list, temporarily disable Adblock Plus. If the issue is fixed after disabling Adblock Plus, you can be certain that the problem lies within the filters. On 2017/02/06 13:38:49, scott wrote: > 'If the issue is fixed after disabling Adblock Plus, you can be certain that the > problem lies within the filters' - I don't think this is something we should > have in this sentence. Someone who is navigated to this help page and tries this > only (without first checking if it is Adblock plus causing the issue) then > stating that disabling ABP means that it is a filter list issue is a bit of a > porky pie. In addition to this, maybe we need to be more specific that the user > needs to pause/whitelist the website to check if it is a filter list issue and > not disable/remove it from the Extensions page? I just feel some clarity is > needed here. I took this from the current website (almost word-for-word). It reads as though the user has to disable ABP, not temporarily whitelist the website. Just to verify, the user needs to temporarily whitelist the website and NOT disable ABP? https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/compatibility-issues.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/compatibility-issues.md:2: On 2017/01/13 09:47:12, Philip Hill wrote: > The previous here was more explicit, while this version here leaves plenty of > room for interpretation of what "Compatibility issues" might be, something, that > user's usually aren't very strong in. We should also link to what the supported > versions are: https://adblockplus.org/requirements Done. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/compatibility-issues.md:5: To ensure that your platform is up-to-date, visit: On 2017/01/13 09:47:11, Philip Hill wrote: > I opened the whatbrowser link in Chrome 48 on one of our test clients at Win 7 > 64 bit with English language preference but got the site in italian, telling me > that my version would be the latest available. I tried with Chrome and Firefox and got the correct information. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/configure-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:3: Currently, it is possible to configure automatic updates for Adblock Plus for Samsung Internet only. On 2017/02/06 13:38:49, scott wrote: > On 2017/01/13 09:47:12, Philip Hill wrote: > > Almost all our products do receive App updates, either via built-in updaters > or > > app stores. If you refer to filter list updates, then also most of our > platforms > > do receive those. > > I guess the definition here is that only ABP for Samsung Browser has the option > to either update via Wifi, or over mobile data. Obviously, nearly all of our > products automatically fetch for filter updates every X days and Extension > updates are generally pushed or the user is at least notified. > > The question remaining, do we look at also writing a section how to search for > APP/Extension updates also? (Play Store for Android, iTunes App Store for iOS, > CWS for Chrome etc.) Done. https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/what-are-acceptable-ads.md (right): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/what-are-acceptable-ads.md:3: Acceptable Ads are nonitrusive ads that: On 2017/01/13 09:47:12, Philip Hill wrote: > I think we should rather refrain from duplicating the description of what > exactly Acceptable Ads are to here. This seems a legally very critical topic, so > it might be better to have only one public description in once place (eg > http://acceptableads.com or whatever officially approves page on http://adblockplus.org). At > the very least, we need to triple-check this description with management and > legal. Done.
https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/adblock-plus-breaks-the-websites-i-visit.md (left): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/adblock-plus-breaks-the-websites-i-visit.md:3: In rare instances, Adblock Plus may prevent some websites from functioning correctly. This is typically not a bug but rather a problem with the filters (or filter subscription). The filter lists may be directing Adblock Plus to block something that should be allowed. To verify that the issue lies within the filter list, temporarily disable Adblock Plus. If the issue is fixed after disabling Adblock Plus, you can be certain that the problem lies within the filters. On 2017/02/08 16:52:20, Lisa wrote: > On 2017/02/06 13:38:49, scott wrote: > > 'If the issue is fixed after disabling Adblock Plus, you can be certain that > the > > problem lies within the filters' - I don't think this is something we should > > have in this sentence. Someone who is navigated to this help page and tries > this > > only (without first checking if it is Adblock plus causing the issue) then > > stating that disabling ABP means that it is a filter list issue is a bit of a > > porky pie. In addition to this, maybe we need to be more specific that the > user > > needs to pause/whitelist the website to check if it is a filter list issue and > > not disable/remove it from the Extensions page? I just feel some clarity is > > needed here. > > I took this from the current website (almost word-for-word). It reads as though > the user has to disable ABP, not temporarily whitelist the website. Just to > verify, the user needs to temporarily whitelist the website and NOT disable ABP? I guess this 'might' need to be changed on the website too?? From what I read and understand here (And the user would also in my opinion) is that they need to disable ABP completely. I think it is quite possible, that this sentence is referring more to disabling ABP on the page. As disabling ABP on the page would maybe identify it as a list issue, but disabling the whole extension would not. Maybe we could simply add in 'temporarily disable Adblock Plus on the website experiencing the issue'. This would at least point towards them disabling it on page as opposed to in the extensions tab (disabling the whole extension).
https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... File pages/adblock-plus/adblock-plus-breaks-the-websites-i-visit.md (left): https://codereview.adblockplus.org/29363713/diff/29371637/pages/adblock-plus/... pages/adblock-plus/adblock-plus-breaks-the-websites-i-visit.md:3: In rare instances, Adblock Plus may prevent some websites from functioning correctly. This is typically not a bug but rather a problem with the filters (or filter subscription). The filter lists may be directing Adblock Plus to block something that should be allowed. To verify that the issue lies within the filter list, temporarily disable Adblock Plus. If the issue is fixed after disabling Adblock Plus, you can be certain that the problem lies within the filters. On 2017/02/09 08:24:50, scott wrote: > On 2017/02/08 16:52:20, Lisa wrote: > > On 2017/02/06 13:38:49, scott wrote: > > > 'If the issue is fixed after disabling Adblock Plus, you can be certain that > > the > > > problem lies within the filters' - I don't think this is something we should > > > have in this sentence. Someone who is navigated to this help page and tries > > this > > > only (without first checking if it is Adblock plus causing the issue) then > > > stating that disabling ABP means that it is a filter list issue is a bit of > a > > > porky pie. In addition to this, maybe we need to be more specific that the > > user > > > needs to pause/whitelist the website to check if it is a filter list issue > and > > > not disable/remove it from the Extensions page? I just feel some clarity is > > > needed here. > > > > I took this from the current website (almost word-for-word). It reads as > though > > the user has to disable ABP, not temporarily whitelist the website. Just to > > verify, the user needs to temporarily whitelist the website and NOT disable > ABP? > > I guess this 'might' need to be changed on the website too?? From what I read > and understand here (And the user would also in my opinion) is that they need to > disable ABP completely. I think it is quite possible, that this sentence is > referring more to disabling ABP on the page. As disabling ABP on the page would > maybe identify it as a list issue, but disabling the whole extension would not. > > Maybe we could simply add in 'temporarily disable Adblock Plus on the website > experiencing the issue'. This would at least point towards them disabling it on > page as opposed to in the extensions tab (disabling the whole extension). Ok makes sense. This whole time, I took it to mean the user had to completely disable the extension. Thanks!
> Ok makes sense. This whole time, I took it to mean the user had to completely > disable the extension. Thanks! Can someone please say something about the overall status of this review?
On 2017/04/05 12:03:04, juliandoucette wrote: > > Ok makes sense. This whole time, I took it to mean the user had to completely > > disable the extension. Thanks! > > Can someone please say something about the overall status of this review? Well, it seems there were many remarks on the 3rd patch set but no 4th one yet to address them.
On 2017/04/05 13:04:05, Philip Hill wrote: > On 2017/04/05 12:03:04, juliandoucette wrote: > > > Ok makes sense. This whole time, I took it to mean the user had to > completely > > > disable the extension. Thanks! > > > > Can someone please say something about the overall status of this review? > > Well, it seems there were many remarks on the 3rd patch set but no 4th one yet > to address them. I made the majority of the suggested changes a month ago (if you read the comments, most of them are the same). I did not upload a 4th patch because the project was stalled. @Jeen: Should I remove the “Disable malware” and “Disable tracking” topics (per your conversation with Legal)?
Have you already created titles and descriptions?
On 2017/04/14 19:40:51, juliandoucette wrote: > Have you already created titles and descriptions? I haven't created the titles and descriptions yet. I plan on doing that as well as going through the content for a final time later this week.
The latest patchset has been uploaded.
https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/configure-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:6: Currently, it is only possible to configure automatic updates via Wi-Fi or mobile data for Adblock Plus for Samsung Internet. I wonder if here we should change it to `Currently, it is only possible to configure automatic updates via Wi-Fi or mobile data for filter lists in Adblock Plus for Samsung Internet.´ This way, they understand that they are not updating the app itself, but the filter list within the app. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/disable-social-media-buttons.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:30: 8. Click **Filter Preferences**. Maybe in-between here, we should state ´Fanboys Social Blocking List is displayed´. So, they are not looking at another random list that had already been installed and they are actively checking that the correct one is there.I say this on this particular one, as they are not automatically directed to the settings page in ABP for Firefox. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/disable-tracking.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/disable-tracking.md:33: 8. Click **Filter Preferences**. I wonder if in-between here we should add a sentence stating they need to make sure that the filter list ´Malware Domains´is shown so that they are not checking another list that was already there. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/download-and-install-adblock-plus.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/download-and-install-adblock-plus.md:29: 2. Click the **Install** button. **Install for Firefox** https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/download-and-install-adblock-plus.md:103: In Samsung Internet 5.0 the UI has slightly changed. The below directions should also remain, however, as there will be some users that never upgrade to Samsung Internet 5.0 (Because of Android level restriction). For Samsung 5.0, the user would need to do the following: - Open Samsung Internet - Tap the **menu icon** and select **Extensions** - Tap **Block Content** - Turn on Content Blocking toggle - Enable the **Block content** option and tap **Adblock Plus for Samsung Internet**. - Exit Settings. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/uninstall-adblock-plus.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/uninstall-adblock-plus.md:100: On Android 7.0 this has slightly changed. The user now taps and holds the icon, then when letting go an uninstall option is presented in a bubble window. I would suggest: 1. Tap and hold the Adblock Plus for Samsung Internet icon 2. When the bubble window appears above the icon select 'Uninstall' 3. Tap OK
https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/configure-automatic-updates.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/configure-automatic-updates.md:6: Currently, it is only possible to configure automatic updates via Wi-Fi or mobile data for Adblock Plus for Samsung Internet. On 2017/04/30 17:34:15, scott wrote: > I wonder if here we should change it to `Currently, it is only possible to > configure automatic updates via Wi-Fi or mobile data for filter lists in Adblock > Plus for Samsung Internet.´ > > This way, they understand that they are not updating the app itself, but the > filter list within the app. Done. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/disable-social-media-buttons.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/disable-social-media-buttons.md:30: 8. Click **Filter Preferences**. On 2017/04/30 17:34:15, scott wrote: > Maybe in-between here, we should state ´Fanboys Social Blocking List is > displayed´. So, they are not looking at another random list that had already > been installed and they are actively checking that the correct one is there.I > say this on this particular one, as they are not automatically directed to the > settings page in ABP for Firefox. Done. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/disable-tracking.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/disable-tracking.md:33: 8. Click **Filter Preferences**. On 2017/04/30 17:34:15, scott wrote: > I wonder if in-between here we should add a sentence stating they need to make > sure that the filter list ´Malware Domains´is shown so that they are not > checking another list that was already there. Done. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/download-and-install-adblock-plus.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/download-and-install-adblock-plus.md:29: 2. Click the **Install** button. On 2017/04/30 17:34:16, scott wrote: > **Install for Firefox** Done. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/download-and-install-adblock-plus.md:103: On 2017/04/30 17:34:16, scott wrote: > In Samsung Internet 5.0 the UI has slightly changed. The below directions should > also remain, however, as there will be some users that never upgrade to Samsung > Internet 5.0 (Because of Android level restriction). For Samsung 5.0, the user > would need to do the following: > > - Open Samsung Internet > - Tap the **menu icon** and select **Extensions** > - Tap **Block Content** > - Turn on Content Blocking toggle > - Enable the **Block content** option and tap **Adblock Plus for Samsung > Internet**. > - Exit Settings. > Done. https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... File pages/adblock-plus/uninstall-adblock-plus.md (right): https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... pages/adblock-plus/uninstall-adblock-plus.md:100: On 2017/04/30 17:34:17, scott wrote: > On Android 7.0 this has slightly changed. The user now taps and holds the icon, > then when letting go an uninstall option is presented in a bubble window. I > would suggest: > > 1. Tap and hold the Adblock Plus for Samsung Internet icon > 2. When the bubble window appears above the icon select 'Uninstall' > 3. Tap OK Done.
On 2017/05/09 14:50:23, Lisa wrote: > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > File pages/adblock-plus/configure-automatic-updates.md (right): > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > pages/adblock-plus/configure-automatic-updates.md:6: Currently, it is only > possible to configure automatic updates via Wi-Fi or mobile data for Adblock > Plus for Samsung Internet. > On 2017/04/30 17:34:15, scott wrote: > > I wonder if here we should change it to `Currently, it is only possible to > > configure automatic updates via Wi-Fi or mobile data for filter lists in > Adblock > > Plus for Samsung Internet.´ > > > > This way, they understand that they are not updating the app itself, but the > > filter list within the app. > > Done. > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > File pages/adblock-plus/disable-social-media-buttons.md (right): > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > pages/adblock-plus/disable-social-media-buttons.md:30: 8. Click **Filter > Preferences**. > On 2017/04/30 17:34:15, scott wrote: > > Maybe in-between here, we should state ´Fanboys Social Blocking List is > > displayed´. So, they are not looking at another random list that had already > > been installed and they are actively checking that the correct one is there.I > > say this on this particular one, as they are not automatically directed to the > > settings page in ABP for Firefox. > > Done. > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > File pages/adblock-plus/disable-tracking.md (right): > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > pages/adblock-plus/disable-tracking.md:33: 8. Click **Filter Preferences**. > On 2017/04/30 17:34:15, scott wrote: > > I wonder if in-between here we should add a sentence stating they need to make > > sure that the filter list ´Malware Domains´is shown so that they are not > > checking another list that was already there. > > Done. > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > File pages/adblock-plus/download-and-install-adblock-plus.md (right): > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > pages/adblock-plus/download-and-install-adblock-plus.md:29: 2. Click the > **Install** button. > On 2017/04/30 17:34:16, scott wrote: > > **Install for Firefox** > > Done. > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > pages/adblock-plus/download-and-install-adblock-plus.md:103: > On 2017/04/30 17:34:16, scott wrote: > > In Samsung Internet 5.0 the UI has slightly changed. The below directions > should > > also remain, however, as there will be some users that never upgrade to > Samsung > > Internet 5.0 (Because of Android level restriction). For Samsung 5.0, the user > > would need to do the following: > > > > - Open Samsung Internet > > - Tap the **menu icon** and select **Extensions** > > - Tap **Block Content** > > - Turn on Content Blocking toggle > > - Enable the **Block content** option and tap **Adblock Plus for Samsung > > Internet**. > > - Exit Settings. > > > > Done. > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > File pages/adblock-plus/uninstall-adblock-plus.md (right): > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > pages/adblock-plus/uninstall-adblock-plus.md:100: > On 2017/04/30 17:34:17, scott wrote: > > On Android 7.0 this has slightly changed. The user now taps and holds the > icon, > > then when letting go an uninstall option is presented in a bubble window. I > > would suggest: > > > > 1. Tap and hold the Adblock Plus for Samsung Internet icon > > 2. When the bubble window appears above the icon select 'Uninstall' > > 3. Tap OK > > Done. We (Jeen+Winsley) want to add the help center topics to the help center specification. See: https://bitbucket.org/adblockplus/spec/pull-requests/19/added-help-center-spe... Afaict now is a good opportunity to switch the review over to the pull request because there are no open comments left and you could reopen/create new comments over in the pull request. If you agree could you please close this review and continue in the pull request so that we don't accidentally end up with different versions we later have to sync again. Thanks :)
On 2017/05/31 07:56:41, wspee wrote: > On 2017/05/09 14:50:23, Lisa wrote: > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > File pages/adblock-plus/configure-automatic-updates.md (right): > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > pages/adblock-plus/configure-automatic-updates.md:6: Currently, it is only > > possible to configure automatic updates via Wi-Fi or mobile data for Adblock > > Plus for Samsung Internet. > > On 2017/04/30 17:34:15, scott wrote: > > > I wonder if here we should change it to `Currently, it is only possible to > > > configure automatic updates via Wi-Fi or mobile data for filter lists in > > Adblock > > > Plus for Samsung Internet.´ > > > > > > This way, they understand that they are not updating the app itself, but the > > > filter list within the app. > > > > Done. > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > File pages/adblock-plus/disable-social-media-buttons.md (right): > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > pages/adblock-plus/disable-social-media-buttons.md:30: 8. Click **Filter > > Preferences**. > > On 2017/04/30 17:34:15, scott wrote: > > > Maybe in-between here, we should state ´Fanboys Social Blocking List is > > > displayed´. So, they are not looking at another random list that had already > > > been installed and they are actively checking that the correct one is > there.I > > > say this on this particular one, as they are not automatically directed to > the > > > settings page in ABP for Firefox. > > > > Done. > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > File pages/adblock-plus/disable-tracking.md (right): > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > pages/adblock-plus/disable-tracking.md:33: 8. Click **Filter Preferences**. > > On 2017/04/30 17:34:15, scott wrote: > > > I wonder if in-between here we should add a sentence stating they need to > make > > > sure that the filter list ´Malware Domains´is shown so that they are not > > > checking another list that was already there. > > > > Done. > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > File pages/adblock-plus/download-and-install-adblock-plus.md (right): > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > pages/adblock-plus/download-and-install-adblock-plus.md:29: 2. Click the > > **Install** button. > > On 2017/04/30 17:34:16, scott wrote: > > > **Install for Firefox** > > > > Done. > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > pages/adblock-plus/download-and-install-adblock-plus.md:103: > > On 2017/04/30 17:34:16, scott wrote: > > > In Samsung Internet 5.0 the UI has slightly changed. The below directions > > should > > > also remain, however, as there will be some users that never upgrade to > > Samsung > > > Internet 5.0 (Because of Android level restriction). For Samsung 5.0, the > user > > > would need to do the following: > > > > > > - Open Samsung Internet > > > - Tap the **menu icon** and select **Extensions** > > > - Tap **Block Content** > > > - Turn on Content Blocking toggle > > > - Enable the **Block content** option and tap **Adblock Plus for Samsung > > > Internet**. > > > - Exit Settings. > > > > > > > Done. > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > File pages/adblock-plus/uninstall-adblock-plus.md (right): > > > > > https://codereview.adblockplus.org/29363713/diff/29421645/pages/adblock-plus/... > > pages/adblock-plus/uninstall-adblock-plus.md:100: > > On 2017/04/30 17:34:17, scott wrote: > > > On Android 7.0 this has slightly changed. The user now taps and holds the > > icon, > > > then when letting go an uninstall option is presented in a bubble window. I > > > would suggest: > > > > > > 1. Tap and hold the Adblock Plus for Samsung Internet icon > > > 2. When the bubble window appears above the icon select 'Uninstall' > > > 3. Tap OK > > > > Done. > > We (Jeen+Winsley) want to add the help center topics to the help center > specification. See: > > https://bitbucket.org/adblockplus/spec/pull-requests/19/added-help-center-spe... > > Afaict now is a good opportunity to switch the review over to the pull request > because there are no open comments left and you could reopen/create new comments > over in the pull request. > > If you agree could you please close this review and continue in the pull request > so that we don't accidentally end up with different versions we later have to > sync again. Thanks :) Unfortunately, there was no new patch set provided after the last round of review, so I cannot consider the review to be done yet.
All checked - LGTM. 
|
