Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(746)

Issue 29550574: Issue 5693 - Add Article Content to help.eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by ire
Modified:
2 months ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 5693 - Add Article Content to help.eyeo.com

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add message in place of no content for platform #

Total comments: 28

Patch Set 3 : Rebased, addressed comments #

Patch Set 4 : Move no-content-for-platform-message to template #

Total comments: 3

Patch Set 5 : Remove empty sections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1703 lines, -16 lines) Patch
A includes/adblockplus/block-all-ads.md View 1 2 3 4 1 chunk +103 lines, -0 lines 0 comments Download
A includes/adblockplus/remove-a-website-from-the-whitelist.md View 1 2 3 4 1 chunk +104 lines, -0 lines 0 comments Download
R pages/adblockplus/adblock-plus-breaks-the-websites-i-visit.md View 1 1 chunk +0 lines, -4 lines 0 comments Download
A pages/adblockplus/add-a-filter-list.md View 1 2 3 4 1 chunk +128 lines, -0 lines 0 comments Download
A pages/adblockplus/add-a-website-to-the-whitelist.md View 1 2 3 4 1 chunk +107 lines, -0 lines 0 comments Download
A pages/adblockplus/block-all-ads.md View 1 chunk +8 lines, -0 lines 0 comments Download
A pages/adblockplus/block-malware-sites.md View 1 2 3 4 1 chunk +82 lines, -0 lines 0 comments Download
R pages/adblockplus/blockads.md View 1 1 chunk +0 lines, -5 lines 0 comments Download
A pages/adblockplus/broken-website.md View 1 2 3 4 1 chunk +198 lines, -0 lines 0 comments Download
A pages/adblockplus/compatibility-issues.md View 1 1 chunk +13 lines, -0 lines 0 comments Download
A pages/adblockplus/configure-automatic-updates.md View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A pages/adblockplus/disable-social-media-buttons.md View 1 2 3 4 1 chunk +75 lines, -0 lines 0 comments Download
A pages/adblockplus/disable-tracking.md View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download
M pages/adblockplus/download-and-install-adblock-plus.md View 1 2 3 4 1 chunk +144 lines, -1 line 0 comments Download
A pages/adblockplus/hide-the-adblock-plus-icon.md View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download
A pages/adblockplus/i-still-see-ads.md View 1 2 3 4 1 chunk +116 lines, -0 lines 0 comments Download
M pages/adblockplus/is-adblock-plus-the-same-thing-as-adblock.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
A pages/adblockplus/problems-installing.md View 1 2 3 4 1 chunk +88 lines, -0 lines 0 comments Download
A pages/adblockplus/remove-a-filter-list.md View 1 2 3 4 1 chunk +102 lines, -0 lines 0 comments Download
A pages/adblockplus/remove-a-website-from-the-whitelist.md View 1 chunk +7 lines, -0 lines 0 comments Download
R pages/adblockplus/removewhitelist.md View 1 1 chunk +0 lines, -5 lines 0 comments Download
A pages/adblockplus/unblock-ablocked-item.md View 1 2 3 4 1 chunk +102 lines, -0 lines 0 comments Download
A pages/adblockplus/uninstall-adblock-plus.md View 1 2 3 4 1 chunk +132 lines, -0 lines 0 comments Download
M pages/adblockplus/what-are-acceptable-ads.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
M templates/article.tmpl View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 17
ire
2 months, 3 weeks ago (2017-09-20 08:08:45 UTC) #1
ire
Ready for review. See my comments below https://codereview.adblockplus.org/29550574/diff/29550575/includes/adblockplus/block-all-ads.md File includes/adblockplus/block-all-ads.md (right): https://codereview.adblockplus.org/29550574/diff/29550575/includes/adblockplus/block-all-ads.md#newcode1 includes/adblockplus/block-all-ads.md:1: <div class="platform-ios" ...
2 months, 3 weeks ago (2017-09-20 08:18:03 UTC) #2
juliandoucette
Responses before review. https://codereview.adblockplus.org/29550574/diff/29550575/includes/adblockplus/block-all-ads.md File includes/adblockplus/block-all-ads.md (right): https://codereview.adblockplus.org/29550574/diff/29550575/includes/adblockplus/block-all-ads.md#newcode1 includes/adblockplus/block-all-ads.md:1: <div class="platform-ios" markdown="1"> On 2017/09/20 08:18:03, ...
2 months, 3 weeks ago (2017-09-22 14:42:14 UTC) #3
juliandoucette
Do you want me to review anything else before proceeding?
2 months, 3 weeks ago (2017-09-22 14:49:25 UTC) #4
ire
On 2017/09/22 14:49:25, juliandoucette wrote: > Do you want me to review anything else before ...
2 months, 3 weeks ago (2017-09-22 14:54:31 UTC) #5
juliandoucette
On 2017/09/22 14:54:31, ire wrote: > On 2017/09/22 14:49:25, juliandoucette wrote: > > Do you ...
2 months, 3 weeks ago (2017-09-22 18:08:03 UTC) #6
ire
On 2017/09/22 18:08:03, juliandoucette wrote: > On 2017/09/22 14:54:31, ire wrote: > > On 2017/09/22 ...
2 months, 2 weeks ago (2017-09-25 07:04:51 UTC) #7
ire
UPDATE: Jeen agrees with us and prefers the solution of displaying a message to users ...
2 months, 2 weeks ago (2017-09-25 08:51:48 UTC) #8
ire
> 1. Show a friendly message if the platform is missing Done. I have asked ...
2 months, 2 weeks ago (2017-09-26 07:16:02 UTC) #9
ire
https://codereview.adblockplus.org/29550574/diff/29556555/pages/adblockplus/what-are-acceptable-ads.md File pages/adblockplus/what-are-acceptable-ads.md (right): https://codereview.adblockplus.org/29550574/diff/29556555/pages/adblockplus/what-are-acceptable-ads.md#newcode7 pages/adblockplus/what-are-acceptable-ads.md:7: hide_browser_selector=true For articles without browser-specific content, I will hide ...
2 months, 2 weeks ago (2017-09-26 07:17:00 UTC) #10
juliandoucette
TOL = Thinking Out Loud (I don't know if I just made that up) https://codereview.adblockplus.org/29550574/diff/29556555/includes/adblockplus/block-all-ads.md ...
2 months ago (2017-10-09 16:41:06 UTC) #11
ire
Thanks Julian! New patch uploaded https://codereview.adblockplus.org/29550574/diff/29556555/includes/adblockplus/block-all-ads.md File includes/adblockplus/block-all-ads.md (right): https://codereview.adblockplus.org/29550574/diff/29556555/includes/adblockplus/block-all-ads.md#newcode1 includes/adblockplus/block-all-ads.md:1: <div class="platform-ios" markdown="1"> On ...
2 months ago (2017-10-09 20:20:48 UTC) #12
juliandoucette
https://codereview.adblockplus.org/29550574/diff/29556555/includes/adblockplus/block-all-ads.md File includes/adblockplus/block-all-ads.md (right): https://codereview.adblockplus.org/29550574/diff/29556555/includes/adblockplus/block-all-ads.md#newcode1 includes/adblockplus/block-all-ads.md:1: <div class="platform-ios" markdown="1"> On 2017/10/09 20:20:46, ire wrote: > ...
2 months ago (2017-10-09 22:41:32 UTC) #13
ire
Updated and ready for review https://codereview.adblockplus.org/29550574/diff/29556555/includes/adblockplus/remove-a-website-from-the-whitelist.md File includes/adblockplus/remove-a-website-from-the-whitelist.md (right): https://codereview.adblockplus.org/29550574/diff/29556555/includes/adblockplus/remove-a-website-from-the-whitelist.md#newcode96 includes/adblockplus/remove-a-website-from-the-whitelist.md:96: <? include no-content-for-platform-message ?> ...
2 months ago (2017-10-12 12:43:24 UTC) #14
juliandoucette
https://codereview.adblockplus.org/29550574/diff/29574617/pages/adblockplus/add-a-filter-list.md File pages/adblockplus/add-a-filter-list.md (right): https://codereview.adblockplus.org/29550574/diff/29574617/pages/adblockplus/add-a-filter-list.md#newcode13 pages/adblockplus/add-a-filter-list.md:13: <section class="platform-ios" markdown="1"> On 2017/10/12 12:43:23, ire wrote: > ...
2 months ago (2017-10-12 13:00:39 UTC) #15
ire
https://codereview.adblockplus.org/29550574/diff/29574617/pages/adblockplus/add-a-filter-list.md File pages/adblockplus/add-a-filter-list.md (right): https://codereview.adblockplus.org/29550574/diff/29574617/pages/adblockplus/add-a-filter-list.md#newcode13 pages/adblockplus/add-a-filter-list.md:13: <section class="platform-ios" markdown="1"> On 2017/10/12 13:00:38, juliandoucette wrote: > ...
2 months ago (2017-10-13 09:28:14 UTC) #16
juliandoucette
2 months ago (2017-10-13 11:09:33 UTC) #17
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5