Noissue - Imported issue reporter translations from adblockplus repository

Noissue - Imported issue reporter translations from adblockplus repository

[Wladimir Palant, 2017-10-25 12:35:36]

Note: ka, az, gu_IN, be, si_LK, ml_IN directories are new, these locales didn't
exist in the repository before. They do have translations on Crowdin however, I
guess that these merely weren't synced back.

https://codereview.adblockplus.org/29588613/diff/29588614/locale/en_GB/issue-...
File locale/en_GB/issue-reporter.json (right):

https://codereview.adblockplus.org/29588613/diff/29588614/locale/en_GB/issue-...
locale/en_GB/issue-reporter.json:29: "issueReporter_doneButton_label": "Done",
This is the only string not originating from the adblockplus repository.
Instead, it is coming from
https://hg.mozilla.org/l10n-central/en-GB/file/default/toolkit/chrome/global/...
- it's a default string from a Firefox wizard widget.

[kzar, 2017-10-25 12:45:08]

I'm not quite sure how to review this, but I can't see any obvious mistakes. I
also like how you've improved some of the string names whilst at it, LGTM.

[Wladimir Palant, 2017-10-25 13:13:41]

There was an issue here after all - the code importing Done button label didn't
add an object but rather a plain string.

[Wladimir Palant, 2017-10-25 13:25:02]

And another one: some languages with non-Latin script use Latin access keys in
Firefox. These strings look like "Label (&L)" then. These access keys weren't
completely removed by the conversion.

[kzar, 2017-10-25 13:43:44]

https://codereview.adblockplus.org/29588613/diff/29588742/locale/ja/issue-rep...
File locale/ja/issue-reporter.json (right):

https://codereview.adblockplus.org/29588613/diff/29588742/locale/ja/issue-rep...
locale/ja/issue-reporter.json:3: "message": "匿名で報告(A)"
Is this one? (Some more similar below too.)

[kzar, 2017-10-25 13:44:49]

https://codereview.adblockplus.org/29588613/diff/29588742/locale/zh_CN/issue-...
File locale/zh_CN/issue-reporter.json (right):

https://codereview.adblockplus.org/29588613/diff/29588742/locale/zh_CN/issue-...
locale/zh_CN/issue-reporter.json:15: "message": "注释（可选）：(C)"
Another one here?

[Sebastian Noack, 2017-10-25 13:46:36]

Not sure what the plan is here. But landing this change in adblockplusui (and
the related change in adblockpluschrome) is probably the wrong workflow. Please
just upload the strings to Crowdin, so that they get imported, next time we
import translations. The easiest way to do so would be with the "build.py
uploadtrans" command.

[Wladimir Palant, 2017-10-25 14:21:21]

On 2017/10/25 13:46:36, Sebastian Noack wrote:
> Not sure what the plan is here. But landing this change in adblockplusui (and
> the related change in adblockpluschrome) is probably the wrong workflow.
Please
> just upload the strings to Crowdin, so that they get imported, next time we
> import translations.

Whatever, I can upload without pushing to the repository of course. But we have
to make sure that we actually update translations, this hasn't happened for
adblockplusui since February 2016 it seems.

https://codereview.adblockplus.org/29588613/diff/29588742/locale/ja/issue-rep...
File locale/ja/issue-reporter.json (right):

https://codereview.adblockplus.org/29588613/diff/29588742/locale/ja/issue-rep...
locale/ja/issue-reporter.json:3: "message": "匿名で報告(A)"
On 2017/10/25 13:43:44, kzar wrote:
> Is this one? (Some more similar below too.)

That's a mistranslation, proper access key has to be at the end of the string
and separated by a whitespace. We can address these once they are in Crowdin,
but not in an automated fashion.

https://codereview.adblockplus.org/29588613/diff/29588742/locale/ja/issue-rep...
locale/ja/issue-reporter.json:15: "message": "コメント (的確に記述すれば良い対応が期待できます) (C):"
Note that this one has a colon after it - another mistranslation.

https://codereview.adblockplus.org/29588613/diff/29588742/locale/zh_CN/issue-...
File locale/zh_CN/issue-reporter.json (right):

https://codereview.adblockplus.org/29588613/diff/29588742/locale/zh_CN/issue-...
locale/zh_CN/issue-reporter.json:15: "message": "注释（可选）：(C)"
On 2017/10/25 13:44:48, kzar wrote:
> Another one here?

Same as before, missing whitespace.

[kzar, 2017-10-25 14:30:32]

Otherwise LGTM

https://codereview.adblockplus.org/29588613/diff/29588742/locale/ja/issue-rep...
File locale/ja/issue-reporter.json (right):

https://codereview.adblockplus.org/29588613/diff/29588742/locale/ja/issue-rep...
locale/ja/issue-reporter.json:3: "message": "匿名で報告(A)"
On 2017/10/25 14:21:20, Wladimir Palant wrote:
> On 2017/10/25 13:43:44, kzar wrote:
> > Is this one? (Some more similar below too.)
> 
> That's a mistranslation, proper access key has to be at the end of the string
> and separated by a whitespace. We can address these once they are in Crowdin,
> but not in an automated fashion.

Acknowledged.

[Wladimir Palant, 2017-10-26 08:40:11]

These translations have been uploaded to the Crowdin project. I am not pushing
to repository, the translations will rather be imported with the next Crowdin
sync. I corrected the issues noted by kzar on Crowdin.